Title: [98321] trunk/Source/_javascript_Core
- Revision
- 98321
- Author
- [email protected]
- Date
- 2011-10-24 22:43:15 -0700 (Mon, 24 Oct 2011)
Log Message
DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
https://bugs.webkit.org/show_bug.cgi?id=70798
Patch by Yuqiang Xian <[email protected]> on 2011-10-24
Reviewed by Filip Pizlo.
When filling an integer for a known integer node (not speculated), it
should accept DataFormatJSInteger as well.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98320 => 98321)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-25 04:57:36 UTC (rev 98320)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-25 05:43:15 UTC (rev 98321)
@@ -1,3 +1,16 @@
+2011-10-24 Yuqiang Xian <[email protected]>
+
+ DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
+ https://bugs.webkit.org/show_bug.cgi?id=70798
+
+ Reviewed by Filip Pizlo.
+
+ When filling an integer for a known integer node (not speculated), it
+ should accept DataFormatJSInteger as well.
+
+ * dfg/DFGJITCodeGenerator32_64.cpp:
+ (JSC::DFG::JITCodeGenerator::fillInteger):
+
2011-10-24 Geoffrey Garen <[email protected]>
Build fix: removed some cases of threadsafeCopy() that I missed in
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (98320 => 98321)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-25 04:57:36 UTC (rev 98320)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-25 05:43:15 UTC (rev 98321)
@@ -76,13 +76,27 @@
case DataFormatJS:
case DataFormatCell:
case DataFormatJSCell:
- case DataFormatJSInteger:
case DataFormatBoolean:
case DataFormatJSBoolean:
case DataFormatStorage:
// Should only be calling this function if we know this operand to be integer.
ASSERT_NOT_REACHED();
+ case DataFormatJSInteger: {
+ GPRReg tagGPR = info.tagGPR();
+ GPRReg payloadGPR = info.payloadGPR();
+ m_gprs.lock(tagGPR);
+ m_jit.jitAssertIsJSInt32(tagGPR);
+ m_gprs.unlock(tagGPR);
+ m_gprs.lock(payloadGPR);
+ m_gprs.release(tagGPR);
+ m_gprs.release(payloadGPR);
+ m_gprs.retain(payloadGPR, virtualRegister, SpillOrderInteger);
+ info.fillInteger(payloadGPR);
+ returnFormat = DataFormatInteger;
+ return payloadGPR;
+ }
+
case DataFormatInteger: {
GPRReg gpr = info.gpr();
m_gprs.lock(gpr);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
