Title: [204198] trunk
- Revision
- 204198
- Author
- [email protected]
- Date
- 2016-08-05 16:29:50 -0700 (Fri, 05 Aug 2016)
Log Message
ASSERTION FAILED: observer in WebCore::BitmapImage::drawPattern
https://bugs.webkit.org/show_bug.cgi?id=141637
<rdar://problem/27709864>
Reviewed by Tim Horton.
Source/WebCore:
Test: fast/images/image-source-assert.html
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern): Remove invalid assertion.
LayoutTests:
* fast/images/image-source-assert-expected.txt: Added.
* fast/images/image-source-assert.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (204197 => 204198)
--- trunk/LayoutTests/ChangeLog 2016-08-05 22:34:12 UTC (rev 204197)
+++ trunk/LayoutTests/ChangeLog 2016-08-05 23:29:50 UTC (rev 204198)
@@ -1,3 +1,14 @@
+2016-08-05 Brent Fulgham <[email protected]>
+
+ ASSERTION FAILED: observer in WebCore::BitmapImage::drawPattern
+ https://bugs.webkit.org/show_bug.cgi?id=141637
+ <rdar://problem/27709864>
+
+ Reviewed by Tim Horton.
+
+ * fast/images/image-source-assert-expected.txt: Added.
+ * fast/images/image-source-assert.html: Added.
+
2016-08-05 Simon Fraser <[email protected]>
marquee with "truespeed" animates at > 60fps, hogging CPU
Added: trunk/LayoutTests/fast/images/image-source-assert-expected.txt (0 => 204198)
--- trunk/LayoutTests/fast/images/image-source-assert-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/images/image-source-assert-expected.txt 2016-08-05 23:29:50 UTC (rev 204198)
@@ -0,0 +1 @@
+The test passes if it does not generate a debug assertion.
Added: trunk/LayoutTests/fast/images/image-source-assert.html (0 => 204198)
--- trunk/LayoutTests/fast/images/image-source-assert.html (rev 0)
+++ trunk/LayoutTests/fast/images/image-source-assert.html 2016-08-05 23:29:50 UTC (rev 204198)
@@ -0,0 +1,11 @@
+<style>
+* {
+ -webkit-mask-image: -webkit-canvas(viewport-mask);
+ -webkit-mask-source-type: luminance;
+}
+</style>
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+</script>
+<p>The test passes if it does not generate a debug assertion.</p>
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (204197 => 204198)
--- trunk/Source/WebCore/ChangeLog 2016-08-05 22:34:12 UTC (rev 204197)
+++ trunk/Source/WebCore/ChangeLog 2016-08-05 23:29:50 UTC (rev 204198)
@@ -1,3 +1,16 @@
+2016-08-05 Brent Fulgham <[email protected]>
+
+ ASSERTION FAILED: observer in WebCore::BitmapImage::drawPattern
+ https://bugs.webkit.org/show_bug.cgi?id=141637
+ <rdar://problem/27709864>
+
+ Reviewed by Tim Horton.
+
+ Test: fast/images/image-source-assert.html
+
+ * platform/graphics/BitmapImage.cpp:
+ (WebCore::BitmapImage::drawPattern): Remove invalid assertion.
+
2016-08-05 Simon Fraser <[email protected]>
marquee with "truespeed" animates at > 60fps, hogging CPU
Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (204197 => 204198)
--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp 2016-08-05 22:34:12 UTC (rev 204197)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp 2016-08-05 23:29:50 UTC (rev 204198)
@@ -611,7 +611,6 @@
return;
ImageObserver* observer = imageObserver();
- ASSERT(observer);
// Temporarily reset image observer, we don't want to receive any changeInRect() calls due to this relayout.
setImageObserver(nullptr);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
