Title: [204194] trunk/Tools
- Revision
- 204194
- Author
- [email protected]
- Date
- 2016-08-05 14:53:02 -0700 (Fri, 05 Aug 2016)
Log Message
run-api-tests should use a headed simulator
https://bugs.webkit.org/show_bug.cgi?id=160611
Reviewed by Sam Weinig.
CADisplayLink doesn't work in a headless simulator, but is
vital for the proper functioning of WebKit2 painting on iOS.
So, we should not use a headless simulator.
* Scripts/run-api-tests:
Launch a simulator app, don't just boot the simulator.
* TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
Re-enable a test that works now.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (204193 => 204194)
--- trunk/Tools/ChangeLog 2016-08-05 21:22:23 UTC (rev 204193)
+++ trunk/Tools/ChangeLog 2016-08-05 21:53:02 UTC (rev 204194)
@@ -1,3 +1,20 @@
+2016-08-05 Tim Horton <[email protected]>
+
+ run-api-tests should use a headed simulator
+ https://bugs.webkit.org/show_bug.cgi?id=160611
+
+ Reviewed by Sam Weinig.
+
+ CADisplayLink doesn't work in a headless simulator, but is
+ vital for the proper functioning of WebKit2 painting on iOS.
+ So, we should not use a headless simulator.
+
+ * Scripts/run-api-tests:
+ Launch a simulator app, don't just boot the simulator.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
+ Re-enable a test that works now.
+
2016-08-05 Dan Bernstein <[email protected]>
[Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
Modified: trunk/Tools/Scripts/run-api-tests (204193 => 204194)
--- trunk/Tools/Scripts/run-api-tests 2016-08-05 21:22:23 UTC (rev 204193)
+++ trunk/Tools/Scripts/run-api-tests 2016-08-05 21:53:02 UTC (rev 204194)
@@ -117,7 +117,7 @@
my $simulatorDevice;
if (willUseIOSSimulatorSDK()) {
$simulatorDevice = findOrCreateSimulatorForIOSDevice(SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT);
- restartIOSSimulatorDevice($simulatorDevice);
+ relaunchIOSSimulator($simulatorDevice);
}
my @testsToRun = listAllTests();
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm (204193 => 204194)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm 2016-08-05 21:22:23 UTC (rev 204193)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm 2016-08-05 21:53:02 UTC (rev 204194)
@@ -88,8 +88,6 @@
return webView;
}
-// FIXME (160516): This test fails when run in a headless simulator because only the first commit ever happens.
-#if 0
TEST(WebKit2, ResizeWithHiddenContentDoesNotHang)
{
auto webView = animatedResizeWebView();
@@ -109,7 +107,6 @@
didEndAnimatedResize = false;
}
}
-#endif
TEST(WebKit2, AnimatedResizeDoesNotHang)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
