Title: [98289] trunk/Source/WebCore
- Revision
- 98289
- Author
- t...@chromium.org
- Date
- 2011-10-24 15:39:16 -0700 (Mon, 24 Oct 2011)
Log Message
Unbreak binding generation tests
https://bugs.webkit.org/show_bug.cgi?id=70768
Patch by Joshua Bell <jsb...@chromium.org> on 2011-10-24
Reviewed by Darin Adler.
Update the expected output of V8 binding tests to match
results c/o https://bugs.webkit.org/show_bug.cgi?id=70065
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::idbKeyCallback):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (98288 => 98289)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 22:26:06 UTC (rev 98288)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 22:39:16 UTC (rev 98289)
@@ -1,3 +1,16 @@
+2011-10-24 Joshua Bell <jsb...@chromium.org>
+
+ Unbreak binding generation tests
+ https://bugs.webkit.org/show_bug.cgi?id=70768
+
+ Reviewed by Darin Adler.
+
+ Update the expected output of V8 binding tests to match
+ results c/o https://bugs.webkit.org/show_bug.cgi?id=70065
+
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjInternal::idbKeyCallback):
+
2011-10-21 Nat Duca <nd...@chromium.org>
[chromium] Add isTraceEventEnabled to PlatformSupport.
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (98288 => 98289)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-10-24 22:26:06 UTC (rev 98288)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-10-24 22:39:16 UTC (rev 98289)
@@ -780,19 +780,9 @@
{
INC_STATS("DOM.TestObj.idbKey");
TestObj* imp = V8TestObj::toNative(args.Holder());
- ExceptionCode ec = 0;
- {
- RefPtr<IDBKey> key = createIDBKeyFromValue(args[0]);
- if (UNLIKELY(!key)) {
- ec = TYPE_MISMATCH_ERR;
- goto fail;
- }
+ EXCEPTION_BLOCK(RefPtr<IDBKey>, key, createIDBKeyFromValue(MAYBE_MISSING_PARAMETER(args, 0, MissingIsUndefined)));
imp->idbKey(key);
return v8::Handle<v8::Value>();
- }
- fail:
- V8Proxy::setDOMException(ec);
- return v8::Handle<v8::Value>();
}
static v8::Handle<v8::Value> optionsObjectCallback(const v8::Arguments& args)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
