Title: [98197] trunk/LayoutTests
- Revision
- 98197
- Author
- [email protected]
- Date
- 2011-10-22 17:40:00 -0700 (Sat, 22 Oct 2011)
Log Message
Make relayout-nested-positioned-elements-crash.html more reliable
https://bugs.webkit.org/show_bug.cgi?id=70672
Reviewed by Kenneth Rohde Christiansen.
The test relayout-nested-positioned-elements-crash relies on implementation
details of the test runner. If the function runTest() is run
during the test, the result will be different than the expected results.
Change the test to use the _javascript_ test framework.
Ensure the element has the correct style in the final state.
* fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt:
* fast/block/positioning/relayout-nested-positioned-elements-crash.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (98196 => 98197)
--- trunk/LayoutTests/ChangeLog 2011-10-22 23:46:58 UTC (rev 98196)
+++ trunk/LayoutTests/ChangeLog 2011-10-23 00:40:00 UTC (rev 98197)
@@ -1,3 +1,20 @@
+2011-10-22 Benjamin Poulain <[email protected]>
+
+ Make relayout-nested-positioned-elements-crash.html more reliable
+ https://bugs.webkit.org/show_bug.cgi?id=70672
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ The test relayout-nested-positioned-elements-crash relies on implementation
+ details of the test runner. If the function runTest() is run
+ during the test, the result will be different than the expected results.
+
+ Change the test to use the _javascript_ test framework.
+ Ensure the element has the correct style in the final state.
+
+ * fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt:
+ * fast/block/positioning/relayout-nested-positioned-elements-crash.html:
+
2011-10-20 Pavel Feldman <[email protected]>
Web Inspector: get rid of View::hide, View::set visible, View::attach.
Modified: trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt (98196 => 98197)
--- trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt 2011-10-22 23:46:58 UTC (rev 98196)
+++ trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash-expected.txt 2011-10-23 00:40:00 UTC (rev 98197)
@@ -1,3 +1,10 @@
-This tests that we don't cause an assertion failure on relayout of nested positioned elements. This test PASSED if we don't cause an assertion failure.
+This tests that we don't cause an assertion failure on relayout of nested positioned elements. This test pass if we don't cause an assertion failure.
-PASS
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.getElementById("hideMe").style.display is "none"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Modified: trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash.html (98196 => 98197)
--- trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash.html 2011-10-22 23:46:58 UTC (rev 98196)
+++ trunk/LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash.html 2011-10-23 00:40:00 UTC (rev 98197)
@@ -1,27 +1,36 @@
<html>
<head>
-<title>Test case for bug 64286</title>
-<script>
-if (window.layoutTestController)
- layoutTestController.dumpAsText();
-</script>
+<link rel="stylesheet" href=""
+<script src=""
</head>
<body>
-<p>This tests that we don't cause an assertion failure on relayout of nested positioned elements. This test PASSED if we don't cause an assertion failure.</p>
+<p id="description"></p>
+<div id="console"></div>
<div style="position:absolute">
<span style="position:relative">
- PASS
<div style="position:absolute">
<input id="hideMe"/>
</div>
</span>
</div>
<script>
+description("This tests that we don't cause an assertion failure on relayout of nested positioned elements. This test pass if we don't cause an assertion failure.");
+window.jsTestIsAsync = true;
+
window.setTimeout(runTest, 0); // For some reason we need the setTimeout() for this test to work.
function runTest()
{
document.getElementById("hideMe").style.display = "none";
+ window.setTimeout(finalizeTest, 0);
}
+
+function finalizeTest()
+{
+ successfullyParsed = true;
+ shouldBeEqualToString('document.getElementById("hideMe").style.display', 'none');
+ finishJSTest();
+}
</script>
+<script src=""
</body>
</html>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
