Title: [203210] trunk/Source/WebCore
- Revision
- 203210
- Author
- cdu...@apple.com
- Date
- 2016-07-13 20:43:07 -0700 (Wed, 13 Jul 2016)
Log Message
Drop unnecessary check from ContainerNode::removeChild()
https://bugs.webkit.org/show_bug.cgi?id=159747
Reviewed by Andreas Kling.
Drop unnecessary check from ContainerNode::removeChild() to make sure that
the parent of the node being removed is |this|. We already do this check
a few lines above. The only thing that happens in between is the ref'ing
of the node, which does not cause any JS execution.
This check was introduced in r55783 because there used to be a call to
document()->removeFocusedNodeOfSubtree(child.get());
between the two checks. However, this call has been removed since then
and the extra parentNode() check was left in.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (203209 => 203210)
--- trunk/Source/WebCore/ChangeLog 2016-07-14 02:38:07 UTC (rev 203209)
+++ trunk/Source/WebCore/ChangeLog 2016-07-14 03:43:07 UTC (rev 203210)
@@ -1,3 +1,23 @@
+2016-07-13 Chris Dumez <cdu...@apple.com>
+
+ Drop unnecessary check from ContainerNode::removeChild()
+ https://bugs.webkit.org/show_bug.cgi?id=159747
+
+ Reviewed by Andreas Kling.
+
+ Drop unnecessary check from ContainerNode::removeChild() to make sure that
+ the parent of the node being removed is |this|. We already do this check
+ a few lines above. The only thing that happens in between is the ref'ing
+ of the node, which does not cause any JS execution.
+
+ This check was introduced in r55783 because there used to be a call to
+ document()->removeFocusedNodeOfSubtree(child.get());
+ between the two checks. However, this call has been removed since then
+ and the extra parentNode() check was left in.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::removeChild): Deleted.
+
2016-07-12 Ryosuke Niwa <rn...@webkit.org>
REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (203209 => 203210)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2016-07-14 02:38:07 UTC (rev 203209)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2016-07-14 03:43:07 UTC (rev 203210)
@@ -524,13 +524,6 @@
Ref<Node> child(oldChild);
- // Events fired when blurring currently focused node might have moved this
- // child into a different parent.
- if (child->parentNode() != this) {
- ec = NOT_FOUND_ERR;
- return false;
- }
-
willRemoveChild(*this, child);
// Mutation events might have moved this child into a different parent.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
