Title: [202323] trunk
Revision
202323
Author
[email protected]
Date
2016-06-21 22:47:58 -0700 (Tue, 21 Jun 2016)

Log Message

[Fetch API] Rename 'origin-only' referrer policy to 'origin'
https://bugs.webkit.org/show_bug.cgi?id=158982

Patch by Youenn Fablet <[email protected]> on 2016-06-21
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Renaming origin-only to origin.

* web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
* web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
* web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
* web-platform-tests/fetch/api/request/request-clone.sub.html:
* web-platform-tests/fetch/api/request/request-idl.html:
* web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
* web-platform-tests/fetch/api/request/request-init-001.sub.html:
* web-platform-tests/fetch/api/request/request-init-003.sub.html:

Source/WebCore:

Covered by updated tests.

* Modules/fetch/FetchRequest.cpp:
(WebCore::setReferrerPolicy): Renaming origin-only to origin.
* Modules/fetch/FetchRequest.idl: Ditto.
* loader/FetchOptions.h: Ditto.

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (202322 => 202323)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-06-22 05:47:58 UTC (rev 202323)
@@ -1,3 +1,21 @@
+2016-06-21  Youenn Fablet  <[email protected]>
+
+        [Fetch API] Rename 'origin-only' referrer policy to 'origin'
+        https://bugs.webkit.org/show_bug.cgi?id=158982
+
+        Reviewed by Alex Christensen.
+
+        Renaming origin-only to origin.
+
+        * web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
+        * web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
+        * web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
+        * web-platform-tests/fetch/api/request/request-clone.sub.html:
+        * web-platform-tests/fetch/api/request/request-idl.html:
+        * web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
+        * web-platform-tests/fetch/api/request/request-init-001.sub.html:
+        * web-platform-tests/fetch/api/request/request-init-003.sub.html:
+
 2016-06-20  Benjamin Poulain  <[email protected]>
 
         :default CSS pseudo-class should match checkboxes+radios with a `checked` attribute

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt (202322 => 202323)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt	2016-06-22 05:47:58 UTC (rev 202323)
@@ -1,7 +1,7 @@
 
 PASS Referrer policy: no-referrer 
 PASS Referrer policy: "" 
-PASS Referrer policy: origin-only 
+PASS Referrer policy: origin 
 PASS Referrer policy: origin-when-cross-origin 
 PASS Referrer policy: unsafe-url 
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt (202322 => 202323)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt	2016-06-22 05:47:58 UTC (rev 202323)
@@ -1,7 +1,7 @@
 
 PASS Referrer policy: no-referrer 
 PASS Referrer policy: "" 
-PASS Referrer policy: origin-only 
+PASS Referrer policy: origin 
 PASS Referrer policy: origin-when-cross-origin 
 PASS Referrer policy: unsafe-url 
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.js (202322 => 202323)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.js	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.js	2016-06-22 05:47:58 UTC (rev 202323)
@@ -32,7 +32,7 @@
 
 corsPreflightReferrer("Referrer policy: no-referrer", corsUrl, "no-referrer", "");
 corsPreflightReferrer("Referrer policy: \"\"", corsUrl, "", "");
-corsPreflightReferrer("Referrer policy: origin-only", corsUrl, "origin-only", origin);
+corsPreflightReferrer("Referrer policy: origin", corsUrl, "origin", origin);
 corsPreflightReferrer("Referrer policy: origin-when-cross-origin", corsUrl, "origin-when-cross-origin", origin);
 corsPreflightReferrer("Referrer policy: unsafe-url", corsUrl, "unsafe-url", location.toString());
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html (202322 => 202323)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html	2016-06-22 05:47:58 UTC (rev 202323)
@@ -16,7 +16,7 @@
 
       var initValuesDict = {"method" : "POST",
                             "referrer" : "http://{{host}}:{{ports[http][0]}}/",
-                            "referrerPolicy" : "origin-only",
+                            "referrerPolicy" : "origin",
                             "mode" : "same-origin",
                             "credentials" : "include",
                             "cache" : "no-cache",
@@ -28,7 +28,7 @@
 
       var expectedInitialized = {"method" : "POST",
                                  "referrer" : "http://{{host}}:{{ports[http][0]}}/",
-                                 "referrerPolicy" : "origin-only",
+                                 "referrerPolicy" : "origin",
                                  "mode" : "same-origin",
                                  "credentials" : "include",
                                  "cache" : "no-cache",

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl.html (202322 => 202323)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl.html	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-idl.html	2016-06-22 05:47:58 UTC (rev 202323)
@@ -70,7 +70,7 @@
       enum RequestCredentials { "omit", "same-origin", "include" };
       enum RequestCache { "default", "no-store", "reload", "no-cache", "force-cache", "only-if-cached" };
       enum RequestRedirect { "follow", "error", "manual" };
-      enum ReferrerPolicy { "", "no-referrer", "no-referrer-when-downgrade", "origin-only", "origin-when-cross-origin", "unsafe-url" };
+      enum ReferrerPolicy { "", "no-referrer", "no-referrer-when-downgrade", "origin", "origin-when-cross-origin", "unsafe-url" };
     </script>
     <script>
       var idlsArray = new IdlArray();

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt (202322 => 202323)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt	2016-06-22 05:47:58 UTC (rev 202323)
@@ -14,7 +14,7 @@
 PASS Check referrerPolicy init value of  and associated getter 
 PASS Check referrerPolicy init value of no-referrer and associated getter 
 PASS Check referrerPolicy init value of no-referrer-when-downgrade and associated getter 
-PASS Check referrerPolicy init value of origin-only and associated getter 
+PASS Check referrerPolicy init value of origin and associated getter 
 PASS Check referrerPolicy init value of origin-when-cross-origin and associated getter 
 PASS Check referrerPolicy init value of unsafe-url and associated getter 
 PASS Check mode init value of same-origin and associated getter 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html (202322 => 202323)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html	2016-06-22 05:47:58 UTC (rev 202323)
@@ -29,7 +29,7 @@
       var referrerPolicies = {"givenValues" : [ "",
                                                 "no-referrer",
                                                 "no-referrer-when-downgrade",
-                                                "origin-only",
+                                                "origin",
                                                 "origin-when-cross-origin",
                                                 "unsafe-url"
                                               ],
@@ -36,7 +36,7 @@
                               "expectedValues" : ["",
                                                   "no-referrer",
                                                   "no-referrer-when-downgrade",
-                                                  "origin-only",
+                                                  "origin",
                                                   "origin-when-cross-origin",
                                                   "unsafe-url"
                                                   ]

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html (202322 => 202323)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html	2016-06-22 05:47:58 UTC (rev 202323)
@@ -17,7 +17,7 @@
 
       var initValuesDict = {"method" : "POST",
                             "referrer" : "http://{{host}}:{{ports[http][0]}}/",
-                            "referrerPolicy" : "origin-only",
+                            "referrerPolicy" : "origin",
                             "mode" : "same-origin",
                             "credentials" : "include",
                             "cache" : "no-cache",
@@ -29,7 +29,7 @@
 
       var expectedInitialized = {"method" : "POST",
                                  "referrer" : "http://{{host}}:{{ports[http][0]}}/",
-                                 "referrerPolicy" : "origin-only",
+                                 "referrerPolicy" : "origin",
                                  "mode" : "same-origin",
                                  "credentials" : "include",
                                  "cache" : "no-cache",

Modified: trunk/Source/WebCore/ChangeLog (202322 => 202323)


--- trunk/Source/WebCore/ChangeLog	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/Source/WebCore/ChangeLog	2016-06-22 05:47:58 UTC (rev 202323)
@@ -1,3 +1,17 @@
+2016-06-21  Youenn Fablet  <[email protected]>
+
+        [Fetch API] Rename 'origin-only' referrer policy to 'origin'
+        https://bugs.webkit.org/show_bug.cgi?id=158982
+
+        Reviewed by Alex Christensen.
+
+        Covered by updated tests.
+
+        * Modules/fetch/FetchRequest.cpp:
+        (WebCore::setReferrerPolicy): Renaming origin-only to origin.
+        * Modules/fetch/FetchRequest.idl: Ditto.
+        * loader/FetchOptions.h: Ditto.
+
 2016-06-21  Chris Dumez  <[email protected]>
 
         Let the compiler generate the move constructor and assignment operator for ScriptExecutionContext::Task

Modified: trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp (202322 => 202323)


--- trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp	2016-06-22 05:47:58 UTC (rev 202323)
@@ -47,8 +47,8 @@
         options.referrerPolicy = FetchOptions::ReferrerPolicy::NoReferrer;
     else if (referrerPolicy == "no-referrer-when-downgrade")
         options.referrerPolicy = FetchOptions::ReferrerPolicy::NoReferrerWhenDowngrade;
-    else if (referrerPolicy == "origin-only")
-        options.referrerPolicy = FetchOptions::ReferrerPolicy::OriginOnly;
+    else if (referrerPolicy == "origin")
+        options.referrerPolicy = FetchOptions::ReferrerPolicy::Origin;
     else if (referrerPolicy == "origin-when-cross-origin")
         options.referrerPolicy = FetchOptions::ReferrerPolicy::OriginWhenCrossOrigin;
     else if (referrerPolicy == "unsafe-url")

Modified: trunk/Source/WebCore/Modules/fetch/FetchRequest.idl (202322 => 202323)


--- trunk/Source/WebCore/Modules/fetch/FetchRequest.idl	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/Source/WebCore/Modules/fetch/FetchRequest.idl	2016-06-22 05:47:58 UTC (rev 202323)
@@ -32,7 +32,7 @@
 enum RequestCredentials { "omit", "same-origin", "include" };
 enum RequestCache { "default", "no-store", "reload", "no-cache", "force-cache" };
 enum RequestRedirect { "follow", "error", "manual" };
-enum ReferrerPolicy { "", "no-referrer",  "no-referrer-when-downgrade", "origin-only", "origin-when-cross-origin", "unsafe-url" };
+enum ReferrerPolicy { "", "no-referrer",  "no-referrer-when-downgrade", "origin", "origin-when-cross-origin", "unsafe-url" };
 
 [
     ActiveDOMObject,

Modified: trunk/Source/WebCore/loader/FetchOptions.h (202322 => 202323)


--- trunk/Source/WebCore/loader/FetchOptions.h	2016-06-22 05:42:01 UTC (rev 202322)
+++ trunk/Source/WebCore/loader/FetchOptions.h	2016-06-22 05:47:58 UTC (rev 202323)
@@ -49,7 +49,7 @@
     enum class Redirect { Follow, Error, Manual };
     Redirect redirect { Redirect::Follow };
 
-    enum class ReferrerPolicy { EmptyString, NoReferrer, NoReferrerWhenDowngrade, OriginOnly, OriginWhenCrossOrigin, UnsafeUrl };
+    enum class ReferrerPolicy { EmptyString, NoReferrer, NoReferrerWhenDowngrade, Origin, OriginWhenCrossOrigin, UnsafeUrl };
     ReferrerPolicy referrerPolicy { ReferrerPolicy::EmptyString };
 };
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to