Title: [202318] trunk/PerformanceTests
- Revision
- 202318
- Author
- [email protected]
- Date
- 2016-06-21 20:26:57 -0700 (Tue, 21 Jun 2016)
Log Message
Update canvas size when benchmark begins
https://bugs.webkit.org/show_bug.cgi?id=159010
Reviewed by Dean Jackson.
Previously we would evaluate the media queries and assign the canvas size to the test
on body.onload. Instead, do it once the user starts the benchmark.
* Animometer/resources/debug-runner/animometer.js: Move benchmarkController.determineCanvasSize()
to benchmarkController._startBenchmark.
* Animometer/resources/runner/animometer.js: Ditto.
Modified Paths
Diff
Modified: trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js (202317 => 202318)
--- trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js 2016-06-22 03:26:24 UTC (rev 202317)
+++ trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js 2016-06-22 03:26:57 UTC (rev 202318)
@@ -507,7 +507,6 @@
if (benchmarkController.startBenchmarkImmediatelyIfEncoded())
return;
- benchmarkController.determineCanvasSize();
benchmarkController.addOrientationListenerIfNecessary();
suitesManager.createElements();
suitesManager.updateUIFromLocalStorage();
@@ -568,6 +567,7 @@
startBenchmark: function()
{
+ benchmarkController.determineCanvasSize();
benchmarkController.options = optionsManager.updateLocalStorageFromUI();
benchmarkController.suites = suitesManager.updateLocalStorageFromUI();
this._startBenchmark(benchmarkController.suites, benchmarkController.options, "running-test");
Modified: trunk/PerformanceTests/Animometer/resources/runner/animometer.js (202317 => 202318)
--- trunk/PerformanceTests/Animometer/resources/runner/animometer.js 2016-06-22 03:26:24 UTC (rev 202317)
+++ trunk/PerformanceTests/Animometer/resources/runner/animometer.js 2016-06-22 03:26:57 UTC (rev 202318)
@@ -436,7 +436,6 @@
window.benchmarkController = {
initialize: function()
{
- benchmarkController.determineCanvasSize();
benchmarkController.addOrientationListenerIfNecessary();
},
@@ -488,6 +487,8 @@
_startBenchmark: function(suites, options, frameContainerID)
{
+ benchmarkController.determineCanvasSize();
+
var configuration = document.body.className.match(/small|medium|large/);
if (configuration)
options[Strings.json.configuration] = configuration[0];
Modified: trunk/PerformanceTests/ChangeLog (202317 => 202318)
--- trunk/PerformanceTests/ChangeLog 2016-06-22 03:26:24 UTC (rev 202317)
+++ trunk/PerformanceTests/ChangeLog 2016-06-22 03:26:57 UTC (rev 202318)
@@ -1,5 +1,19 @@
2016-06-21 Jon Lee <[email protected]>
+ Update canvas size when benchmark begins
+ https://bugs.webkit.org/show_bug.cgi?id=159010
+
+ Reviewed by Dean Jackson.
+
+ Previously we would evaluate the media queries and assign the canvas size to the test
+ on body.onload. Instead, do it once the user starts the benchmark.
+
+ * Animometer/resources/debug-runner/animometer.js: Move benchmarkController.determineCanvasSize()
+ to benchmarkController._startBenchmark.
+ * Animometer/resources/runner/animometer.js: Ditto.
+
+2016-06-21 Jon Lee <[email protected]>
+
Add new timestamp option
https://bugs.webkit.org/show_bug.cgi?id=159006
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
