Title: [201209] trunk/Source/WebInspectorUI
- Revision
- 201209
- Author
- [email protected]
- Date
- 2016-05-19 21:13:33 -0700 (Thu, 19 May 2016)
Log Message
Web Inspector: Visual Style connectors are not always centered properly
https://bugs.webkit.org/show_bug.cgi?id=157932
Patch by Joseph Pecoraro <[email protected]> on 2016-05-19
Reviewed by Timothy Hatcher.
* UserInterface/Views/VisualStylePropertyEditorLink.css:
(.visual-style-property-editor-link):
Remove the 1px margin on @2x that would cause jitter at different
sidebar widths. It is however needed on @1x.
(.visual-style-property-editor-link:not(.link-all)):
Make the height 20 so these both move closer to the center of the
<select> elements they are next to. They are not perfectly centered
as that would require a half pixel.
(.visual-style-property-editor-link.link-vertical):
Move the top line up a pixel so it is "up 0.5" from center and
the bottom one is already "down 0.5" from the center.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201208 => 201209)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-20 02:44:02 UTC (rev 201208)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-20 04:13:33 UTC (rev 201209)
@@ -1,3 +1,24 @@
+2016-05-19 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Visual Style connectors are not always centered properly
+ https://bugs.webkit.org/show_bug.cgi?id=157932
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/VisualStylePropertyEditorLink.css:
+ (.visual-style-property-editor-link):
+ Remove the 1px margin on @2x that would cause jitter at different
+ sidebar widths. It is however needed on @1x.
+
+ (.visual-style-property-editor-link:not(.link-all)):
+ Make the height 20 so these both move closer to the center of the
+ <select> elements they are next to. They are not perfectly centered
+ as that would require a half pixel.
+
+ (.visual-style-property-editor-link.link-vertical):
+ Move the top line up a pixel so it is "up 0.5" from center and
+ the bottom one is already "down 0.5" from the center.
+
2016-05-19 Nikita Vasilyev <[email protected]>
REGRESSION (r189385): Web Inspector: CSS properties modified via JS don't update in the Styles sidebar
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.css (201208 => 201209)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.css 2016-05-20 02:44:02 UTC (rev 201208)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.css 2016-05-20 04:13:33 UTC (rev 201209)
@@ -31,6 +31,12 @@
margin-left: 1px;
}
+@media (-webkit-min-device-pixel-ratio: 2) {
+ .visual-style-property-editor-link {
+ margin-left: 0;
+ }
+}
+
.visual-style-property-editor-link.disabled {
visibility: hidden;
}
@@ -87,6 +93,15 @@
right: 0;
}
+.visual-style-property-editor-link.link-vertical {
+ position: relative;
+ top: -1px;
+}
+
+.visual-style-property-editor-link:not(.link-all) {
+ height: 20px;
+}
+
.visual-style-property-editor-link:not(.link-all) > .visual-style-property-editor-link-border {
width: 10px;
top: 50%;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
