Title: [97762] trunk/Source/WebCore
Revision
97762
Author
[email protected]
Date
2011-10-18 09:07:06 -0700 (Tue, 18 Oct 2011)

Log Message

Change TextTrack to use the word DISABLED instead of OFF for mode
https://bugs.webkit.org/show_bug.cgi?id=70268

Reviewed by Daniel Bates.

No new tests. No new functionality.

* html/TextTrack.cpp:
(WebCore::TextTrack::setMode): use Disabled instead of Off
* html/TextTrack.h: update Mode enum to use Disabled instead of Off

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (97761 => 97762)


--- trunk/Source/WebCore/ChangeLog	2011-10-18 16:04:48 UTC (rev 97761)
+++ trunk/Source/WebCore/ChangeLog	2011-10-18 16:07:06 UTC (rev 97762)
@@ -1,3 +1,16 @@
+2011-10-18  Anna Cavender  <[email protected]>
+
+        Change TextTrack to use the word DISABLED instead of OFF for mode
+        https://bugs.webkit.org/show_bug.cgi?id=70268
+
+        Reviewed by Daniel Bates.
+
+        No new tests. No new functionality.
+
+        * html/TextTrack.cpp:
+        (WebCore::TextTrack::setMode): use Disabled instead of Off
+        * html/TextTrack.h: update Mode enum to use Disabled instead of Off
+
 2011-10-18  Chris Fleizach  <[email protected]>
 
         AX: buttons of number type <input> controls are not fully accessible

Modified: trunk/Source/WebCore/html/TextTrack.cpp (97761 => 97762)


--- trunk/Source/WebCore/html/TextTrack.cpp	2011-10-18 16:04:48 UTC (rev 97761)
+++ trunk/Source/WebCore/html/TextTrack.cpp	2011-10-18 16:07:06 UTC (rev 97762)
@@ -85,7 +85,7 @@
 {
     // 4.8.10.12.5 On setting the mode, if the new value is not either 0, 1, or 2,
     // the user agent must throw an INVALID_ACCESS_ERR exception.
-    if (mode == TextTrack::Off || mode == TextTrack::Hidden || mode == TextTrack::Showing)
+    if (mode == TextTrack::Disabled || mode == TextTrack::Hidden || mode == TextTrack::Showing)
         m_mode = static_cast<Mode>(mode);
     else
         ec = INVALID_ACCESS_ERR;

Modified: trunk/Source/WebCore/html/TextTrack.h (97761 => 97762)


--- trunk/Source/WebCore/html/TextTrack.h	2011-10-18 16:04:48 UTC (rev 97761)
+++ trunk/Source/WebCore/html/TextTrack.h	2011-10-18 16:07:06 UTC (rev 97762)
@@ -61,7 +61,7 @@
     enum ReadyState { None, Loading, Loaded, Error };
     ReadyState readyState() const;
 
-    enum Mode { Off = 0, Hidden = 1, Showing = 2 };
+    enum Mode { Disabled = 0, Hidden = 1, Showing = 2 };
     Mode mode() const;
     void setMode(unsigned short, ExceptionCode&);
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to