Title: [97759] trunk/Source/WebCore
- Revision
- 97759
- Author
- [email protected]
- Date
- 2011-10-18 08:50:25 -0700 (Tue, 18 Oct 2011)
Log Message
AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241
Staged commit, part 5.
Reviewed by Darin Adler.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97758 => 97759)
--- trunk/Source/WebCore/ChangeLog 2011-10-18 15:48:47 UTC (rev 97758)
+++ trunk/Source/WebCore/ChangeLog 2011-10-18 15:50:25 UTC (rev 97759)
@@ -1,3 +1,17 @@
+2011-10-18 Chris Fleizach <[email protected]>
+
+ AX: buttons of number type <input> controls are not fully accessible
+ https://bugs.webkit.org/show_bug.cgi?id=70241
+
+ Staged commit, part 5.
+
+ Reviewed by Darin Adler.
+
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::getOrCreate):
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::boundingBoxRect):
+
2011-10-18 Antti Koivisto <[email protected]>
Move default stylesheet loading to a separate function
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (97758 => 97759)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2011-10-18 15:48:47 UTC (rev 97758)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2011-10-18 15:50:25 UTC (rev 97759)
@@ -45,6 +45,7 @@
#include "AccessibilityScrollView.h"
#include "AccessibilityScrollbar.h"
#include "AccessibilitySlider.h"
+#include "AccessibilitySpinButton.h"
#include "AccessibilityTable.h"
#include "AccessibilityTableCell.h"
#include "AccessibilityTableColumn.h"
@@ -324,6 +325,12 @@
case MenuListOptionRole:
obj = AccessibilityMenuListOption::create();
break;
+ case SpinButtonRole:
+ obj = AccessibilitySpinButton::create();
+ break;
+ case SpinButtonPartRole:
+ obj = AccessibilitySpinButtonPart::create();
+ break;
default:
obj = 0;
}
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (97758 => 97759)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2011-10-18 15:48:47 UTC (rev 97758)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2011-10-18 15:50:25 UTC (rev 97759)
@@ -32,6 +32,7 @@
#include "AXObjectCache.h"
#include "AccessibilityImageMapLink.h"
#include "AccessibilityListBox.h"
+#include "AccessibilitySpinButton.h"
#include "EventNames.h"
#include "FloatRect.h"
#include "Frame.h"
@@ -69,12 +70,14 @@
#include "RenderMenuList.h"
#include "RenderText.h"
#include "RenderTextControl.h"
+#include "RenderTextControlSingleLine.h"
#include "RenderTextFragment.h"
#include "RenderTheme.h"
#include "RenderView.h"
#include "RenderWidget.h"
#include "RenderedPosition.h"
#include "Text.h"
+#include "TextControlInnerElements.h"
#include "TextIterator.h"
#include "htmlediting.h"
#include "visible_units.h"
@@ -1440,20 +1443,9 @@
obj->absoluteQuads(quads);
else
obj->absoluteFocusRingQuads(quads);
- const size_t n = quads.size();
- if (!n)
- return LayoutRect();
+
+ LayoutRect result = boundingBoxForQuads(obj, quads);
- LayoutRect result;
- for (size_t i = 0; i < n; ++i) {
- LayoutRect r = quads[i].enclosingBoundingBox();
- if (!r.isEmpty()) {
- if (obj->style()->hasAppearance())
- obj->theme()->adjustRepaintRect(obj, r);
- result.unite(r);
- }
- }
-
// The size of the web area should be the content size, not the clipped size.
if (isWebArea() && obj->frame()->view())
result.setSize(obj->frame()->view()->contentsSize());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
