Title: [97703] trunk/Source/WebCore
- Revision
- 97703
- Author
- [email protected]
- Date
- 2011-10-17 19:25:32 -0700 (Mon, 17 Oct 2011)
Log Message
[TexMap][QT] The BGRA32PremultimpliedBuffer should not inherit the RefCounted class.
https://bugs.webkit.org/show_bug.cgi?id=70098
The BitmapTexture has a BGRA32PremultimpliedBuffer object using OwnPtr, not RefPtr.
It causes following assertion fail, RefCountedBase::m_deletionHasBegun.
It is better that the BGRA32PremultimpliedBuffer does not inherit the RefCounted
because the BitmapTexture only has and uses a BGRA32PremultimpliedBuffer object.
Patch by Huang Dongsung <[email protected]> on 2011-10-17
Reviewed by Noam Rosenthal.
* platform/graphics/opengl/TextureMapperGL.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97702 => 97703)
--- trunk/Source/WebCore/ChangeLog 2011-10-18 02:19:36 UTC (rev 97702)
+++ trunk/Source/WebCore/ChangeLog 2011-10-18 02:25:32 UTC (rev 97703)
@@ -1,3 +1,17 @@
+2011-10-17 Huang Dongsung <[email protected]>
+
+ [TexMap][QT] The BGRA32PremultimpliedBuffer should not inherit the RefCounted class.
+ https://bugs.webkit.org/show_bug.cgi?id=70098
+
+ The BitmapTexture has a BGRA32PremultimpliedBuffer object using OwnPtr, not RefPtr.
+ It causes following assertion fail, RefCountedBase::m_deletionHasBegun.
+ It is better that the BGRA32PremultimpliedBuffer does not inherit the RefCounted
+ because the BitmapTexture only has and uses a BGRA32PremultimpliedBuffer object.
+
+ Reviewed by Noam Rosenthal.
+
+ * platform/graphics/opengl/TextureMapperGL.h:
+
2011-10-17 Vsevolod Vlasov <[email protected]>
Web Inspector: Search in resource crashes when there is no resource with given url.
Modified: trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.h (97702 => 97703)
--- trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.h 2011-10-18 02:19:36 UTC (rev 97702)
+++ trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.h 2011-10-18 02:25:32 UTC (rev 97703)
@@ -63,7 +63,8 @@
};
// An offscreen buffer to be rendered by software.
-class BGRA32PremultimpliedBuffer : public RefCounted<BGRA32PremultimpliedBuffer> {
+class BGRA32PremultimpliedBuffer {
+ WTF_MAKE_FAST_ALLOCATED;
public:
virtual ~BGRA32PremultimpliedBuffer() { }
virtual PlatformGraphicsContext* beginPaint(const IntRect& dirtyRect, bool opaque) = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
