Title: [97658] trunk/Source/WebCore
- Revision
- 97658
- Author
- [email protected]
- Date
- 2011-10-17 15:30:57 -0700 (Mon, 17 Oct 2011)
Log Message
HTMLKeygenElement: Don't cache keytype and challenge attributes.
https://bugs.webkit.org/show_bug.cgi?id=68365
Patch by Andreas Kling <[email protected]> on 2011-10-17
Reviewed by Darin Adler.
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::parseMappedAttribute):
(WebCore::HTMLKeygenElement::appendFormData):
* html/HTMLKeygenElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97657 => 97658)
--- trunk/Source/WebCore/ChangeLog 2011-10-17 22:21:34 UTC (rev 97657)
+++ trunk/Source/WebCore/ChangeLog 2011-10-17 22:30:57 UTC (rev 97658)
@@ -1,3 +1,15 @@
+2011-10-17 Andreas Kling <[email protected]>
+
+ HTMLKeygenElement: Don't cache keytype and challenge attributes.
+ https://bugs.webkit.org/show_bug.cgi?id=68365
+
+ Reviewed by Darin Adler.
+
+ * html/HTMLKeygenElement.cpp:
+ (WebCore::HTMLKeygenElement::parseMappedAttribute):
+ (WebCore::HTMLKeygenElement::appendFormData):
+ * html/HTMLKeygenElement.h:
+
2011-09-22 Ojan Vafai <[email protected]>
incorrect height with height:auto and writing-mode:vertical-rl
Modified: trunk/Source/WebCore/html/HTMLKeygenElement.cpp (97657 => 97658)
--- trunk/Source/WebCore/html/HTMLKeygenElement.cpp 2011-10-17 22:21:34 UTC (rev 97657)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.cpp 2011-10-17 22:30:57 UTC (rev 97658)
@@ -99,20 +99,16 @@
if (attr->name() == disabledAttr)
shadowSelect()->setAttribute(attr->name(), attr->value());
- if (attr->name() == challengeAttr)
- m_challenge = attr->value();
- else if (attr->name() == keytypeAttr)
- m_keyType = attr->value();
- else
- HTMLFormControlElement::parseMappedAttribute(attr);
+ HTMLFormControlElement::parseMappedAttribute(attr);
}
bool HTMLKeygenElement::appendFormData(FormDataList& encoded_values, bool)
{
// Only RSA is supported at this time.
- if (!m_keyType.isNull() && !equalIgnoringCase(m_keyType, "rsa"))
+ const AtomicString& keyType = fastGetAttribute(keytypeAttr);
+ if (!keyType.isNull() || !equalIgnoringCase(keyType, "rsa"))
return false;
- String value = signedPublicKeyAndChallengeString(shadowSelect()->selectedIndex(), m_challenge, document()->baseURL());
+ String value = signedPublicKeyAndChallengeString(shadowSelect()->selectedIndex(), fastGetAttribute(challengeAttr), document()->baseURL());
if (value.isNull())
return false;
encoded_values.appendData(name(), value.utf8());
Modified: trunk/Source/WebCore/html/HTMLKeygenElement.h (97657 => 97658)
--- trunk/Source/WebCore/html/HTMLKeygenElement.h 2011-10-17 22:21:34 UTC (rev 97657)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.h 2011-10-17 22:30:57 UTC (rev 97658)
@@ -52,9 +52,6 @@
virtual void reset();
HTMLSelectElement* shadowSelect() const;
-
- AtomicString m_challenge;
- AtomicString m_keyType;
};
} //namespace
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
