Diff
Modified: trunk/LayoutTests/ChangeLog (97653 => 97654)
--- trunk/LayoutTests/ChangeLog 2011-10-17 21:46:50 UTC (rev 97653)
+++ trunk/LayoutTests/ChangeLog 2011-10-17 21:50:12 UTC (rev 97654)
@@ -1,3 +1,18 @@
+2011-09-22 Ojan Vafai <[email protected]>
+
+ incorrect height with height:auto and writing-mode:vertical-rl
+ https://bugs.webkit.org/show_bug.cgi?id=68497
+
+ Reviewed by David Hyatt.
+
+ I'm not sure I completely understand the changes to the height/width
+ of the body/html elements, but the new height/width look correct to me.
+
+ * platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt:
+ * platform/mac/fast/table/028-vertical-expected.txt:
+ * platform/mac/fast/table/height-percent-test-vertical-expected.txt:
+ * platform/mac/fast/writing-mode/fallback-orientation-expected.txt:
+
2011-10-12 Ojan Vafai <[email protected]>
display:inline-block elements don't correctly handle orthogonal writing-modes
Modified: trunk/LayoutTests/platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt (97653 => 97654)
--- trunk/LayoutTests/platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt 2011-10-17 21:46:50 UTC (rev 97653)
+++ trunk/LayoutTests/platform/mac/fast/backgrounds/background-leakage-transforms-expected.txt 2011-10-17 21:50:12 UTC (rev 97654)
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x912
+layer at (0,0) size 785x852
RenderView at (0,0) size 785x600
-layer at (0,0) size 785x912
- RenderBlock {HTML} at (0,0) size 785x912
- RenderBody {BODY} at (8,8) size 769x896
+layer at (0,0) size 785x852
+ RenderBlock {HTML} at (0,0) size 785x852
+ RenderBody {BODY} at (8,8) size 769x836
RenderBlock {DIV} at (0,0) size 769x148
RenderBlock {DIV} at (10,10) size 268x128
RenderBlock {DIV} at (12,12) size 110x100 [bgcolor=#000000] [border: (20px solid #FFFFFF)]
@@ -36,8 +36,8 @@
RenderBlock {DIV} at (146,12) size 110x100 [bgcolor=#FFFFFF] [border: (20px double #0000FF7F)]
RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
-layer at (8,304) size 158x600
- RenderBlock {DIV} at (0,296) size 158x600
+layer at (8,304) size 158x540
+ RenderBlock {DIV} at (0,296) size 158x540
RenderBlock {DIV} at (10,10) size 138x248
RenderBlock {DIV} at (16,12) size 110x100 [bgcolor=#000000] [border: (20px solid #FFFFFF)]
RenderText {#text} at (2,122) size 18x4
Modified: trunk/LayoutTests/platform/mac/fast/table/028-vertical-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/mac/fast/table/028-vertical-expected.txt (97653 => 97654)
--- trunk/LayoutTests/platform/mac/fast/table/028-vertical-expected.txt 2011-10-17 21:46:50 UTC (rev 97653)
+++ trunk/LayoutTests/platform/mac/fast/table/028-vertical-expected.txt 2011-10-17 21:50:12 UTC (rev 97654)
@@ -1,12 +1,12 @@
-layer at (0,0) size 785x634
- RenderView at (0,0) size 785x600
-layer at (0,0) size 785x634
- RenderBlock {HTML} at (0,0) size 785x634
- RenderBody {BODY} at (8,8) size 769x618
- RenderBlock (anonymous) at (0,0) size 769x18
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock (anonymous) at (0,0) size 784x18
RenderText {#text} at (0,0) size 277x18
text run at (0,0) width 277: "These two tables should be the same height."
- RenderBlock {DIV} at (0,18) size 78x600
+ RenderBlock {DIV} at (0,18) size 78x320
RenderTable {TABLE} at (0,0) size 22x320
RenderTableSection {TBODY} at (0,0) size 22x320
RenderTableRow {TR} at (0,0) size 22x320
@@ -18,7 +18,7 @@
text run at (1,1) width 8: "2"
RenderTableCell {TD} at (0,314) size 22x6 [border: (1px solid #008000)] [r=0 c=2 rs=1 cs=1]
RenderImage {IMG} at (1,1) size 20x4 [bgcolor=#FFA500]
- RenderBlock {P} at (38,0) size 0x600
+ RenderBlock {P} at (38,0) size 0x320
RenderTable {TABLE} at (38,0) size 40x320
RenderTableSection {TBODY} at (0,0) size 40x320
RenderTableRow {TR} at (0,0) size 20x320
Modified: trunk/LayoutTests/platform/mac/fast/table/height-percent-test-vertical-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/mac/fast/table/height-percent-test-vertical-expected.txt (97653 => 97654)
--- trunk/LayoutTests/platform/mac/fast/table/height-percent-test-vertical-expected.txt 2011-10-17 21:46:50 UTC (rev 97653)
+++ trunk/LayoutTests/platform/mac/fast/table/height-percent-test-vertical-expected.txt 2011-10-17 21:50:12 UTC (rev 97654)
@@ -1,24 +1,24 @@
-layer at (0,0) size 1282x601
- RenderView at (0,0) size 785x585
-layer at (0,0) size 785x601
- RenderBlock {HTML} at (0,0) size 785x601
- RenderBody {BODY} at (8,8) size 769x585
- RenderBlock {DIV} at (0,0) size 1274x585
- RenderBlock {DIV} at (16,16) size 26x553 [border: (1px solid #000000)]
+layer at (0,0) size 1282x585
+ RenderView at (0,0) size 800x585
+layer at (0,0) size 800x585
+ RenderBlock {HTML} at (0,0) size 800x585
+ RenderBody {BODY} at (8,8) size 784x569
+ RenderBlock {DIV} at (0,0) size 1274x134
+ RenderBlock {DIV} at (16,16) size 26x102 [border: (1px solid #000000)]
RenderBlock (floating) {DIV} at (1,1) size 24x100
RenderBlock {DIV} at (0,0) size 24x100 [bgcolor=#008000]
- RenderBlock {DIV} at (58,16) size 26x553 [border: (1px solid #000000)]
+ RenderBlock {DIV} at (58,16) size 26x102 [border: (1px solid #000000)]
RenderBlock (floating) {DIV} at (1,1) size 24x96
RenderTable {TABLE} at (0,0) size 24x96 [bgcolor=#FF0000]
RenderTableSection {TBODY} at (0,0) size 24x96
RenderTableRow {TR} at (0,0) size 24x96
RenderTableCell {TD} at (0,1) size 24x94 [r=0 c=0 rs=1 cs=1]
RenderImage {IMG} at (1,-1) size 22x96 [bgcolor=#008000]
- RenderBlock {DIV} at (100,16) size 571x553 [border: (1px solid #000000)]
- RenderBlock {DIV} at (1,1) size 569x551
+ RenderBlock {DIV} at (100,16) size 571x102 [border: (1px solid #000000)]
+ RenderBlock {DIV} at (1,1) size 569x100
RenderBlock {DIV} at (0,0) size 569x100 [bgcolor=#008000]
- RenderBlock {DIV} at (687,16) size 571x553 [border: (1px solid #000000)]
- RenderBlock {DIV} at (1,1) size 569x551
+ RenderBlock {DIV} at (687,16) size 571x102 [border: (1px solid #000000)]
+ RenderBlock {DIV} at (1,1) size 569x100
RenderTable {TABLE} at (0,0) size 569x96 [bgcolor=#FF0000]
RenderTableSection {TBODY} at (0,0) size 569x96
RenderTableRow {TR} at (0,0) size 569x96
Modified: trunk/LayoutTests/platform/mac/fast/writing-mode/fallback-orientation-expected.txt (97653 => 97654)
--- trunk/LayoutTests/platform/mac/fast/writing-mode/fallback-orientation-expected.txt 2011-10-17 21:46:50 UTC (rev 97653)
+++ trunk/LayoutTests/platform/mac/fast/writing-mode/fallback-orientation-expected.txt 2011-10-17 21:50:12 UTC (rev 97654)
@@ -1,11 +1,11 @@
-layer at (0,0) size 785x650
- RenderView at (0,0) size 785x600
-layer at (0,0) size 785x650
- RenderBlock {HTML} at (0,0) size 785x650
- RenderBody {BODY} at (8,8) size 769x634
- RenderBlock {P} at (0,0) size 769x18
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x18
RenderText {#text} at (0,0) size 211x18
text run at (0,0) width 211: "This should be pointing upwards:"
- RenderBlock {DIV} at (0,34) size 120x600
+ RenderBlock {DIV} at (0,34) size 120x81
RenderText {#text} at (20,0) size 80x81
text run at (20,0) width 81: "\x{3008}"
Modified: trunk/Source/WebCore/ChangeLog (97653 => 97654)
--- trunk/Source/WebCore/ChangeLog 2011-10-17 21:46:50 UTC (rev 97653)
+++ trunk/Source/WebCore/ChangeLog 2011-10-17 21:50:12 UTC (rev 97654)
@@ -1,3 +1,13 @@
+2011-09-22 Ojan Vafai <[email protected]>
+
+ incorrect height with height:auto and writing-mode:vertical-rl
+ https://bugs.webkit.org/show_bug.cgi?id=68497
+
+ Reviewed by David Hyatt.
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
+
2011-10-12 Ojan Vafai <[email protected]>
display:inline-block elements don't correctly handle orthogonal writing-modes
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (97653 => 97654)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2011-10-17 21:46:50 UTC (rev 97653)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2011-10-17 21:50:12 UTC (rev 97654)
@@ -1816,6 +1816,9 @@
if (logicalWidth.type() == Auto && !(parent()->isDeprecatedFlexibleBox() && parent()->style()->boxOrient() == VERTICAL && parent()->style()->boxAlign() == BSTRETCH) && node() && (node()->hasTagName(inputTag) || node()->hasTagName(selectTag) || node()->hasTagName(buttonTag) || node()->hasTagName(textareaTag) || node()->hasTagName(legendTag)))
return true;
+ if (isHorizontalWritingMode() != containingBlock()->isHorizontalWritingMode())
+ return true;
+
return false;
}
