Title: [97431] trunk
- Revision
- 97431
- Author
- [email protected]
- Date
- 2011-10-13 17:57:31 -0700 (Thu, 13 Oct 2011)
Log Message
Implement an OverflowEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=70017
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/overflow-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added an OverflowEvent constructor.
* dom/OverflowEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
LayoutTests:
Enabled overflow-event-constructor.html, since now V8 has the OverflowEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (97430 => 97431)
--- trunk/LayoutTests/ChangeLog 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/LayoutTests/ChangeLog 2011-10-14 00:57:31 UTC (rev 97431)
@@ -1,5 +1,16 @@
2011-10-13 Kentaro Hara <[email protected]>
+ Implement an OverflowEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=70017
+
+ Reviewed by Adam Barth.
+
+ Enabled overflow-event-constructor.html, since now V8 has the OverflowEvent constructor.
+
+ * platform/chromium/test_expectations.txt:
+
+2011-10-13 Kentaro Hara <[email protected]>
+
Implement a BeforeLoadEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=69980
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97430 => 97431)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-14 00:57:31 UTC (rev 97431)
@@ -92,9 +92,6 @@
BUGCR10395 SKIP : svg/custom/image-with-prefix-in-webarchive.svg = PASS FAIL
BUGCR10395 SKIP : http/tests/webarchive = PASS FAIL
-// This will soon be fixed after implementing an OverflowEvent constructor for V8.
-BUGWK69907 : fast/events/constructors/overflow-event-constructor.html = FAIL
-
// According to the Chromium bug, we need to write some sort of workaround for
// how clipboards on Windows work, or something? That doesn't explain why this
// fails for other platforms...
Modified: trunk/Source/WebCore/ChangeLog (97430 => 97431)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 00:57:31 UTC (rev 97431)
@@ -1,3 +1,15 @@
+2011-10-13 Kentaro Hara <[email protected]>
+
+ Implement an OverflowEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=70017
+
+ Reviewed by Adam Barth.
+
+ Test: fast/events/constructors/overflow-event-constructor.html
+
+ * bindings/v8/custom/V8EventConstructors.cpp: Added an OverflowEvent constructor.
+ * dom/OverflowEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
+
2011-10-13 Anantanarayanan G Iyengar <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=70064
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (97430 => 97431)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-14 00:57:31 UTC (rev 97431)
@@ -39,6 +39,7 @@
#include "ErrorEvent.h"
#include "HashChangeEvent.h"
#include "Node.h"
+#include "OverflowEvent.h"
#include "PageTransitionEvent.h"
#include "PopStateEvent.h"
#include "ProgressEvent.h"
@@ -56,6 +57,7 @@
#include "V8Event.h"
#include "V8HashChangeEvent.h"
#include "V8Node.h"
+#include "V8OverflowEvent.h"
#include "V8PageTransitionEvent.h"
#include "V8PopStateEvent.h"
#include "V8ProgressEvent.h"
@@ -126,6 +128,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_BEFORE_LOAD_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_OVERFLOW_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/OverflowEvent.idl (97430 => 97431)
--- trunk/Source/WebCore/dom/OverflowEvent.idl 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/Source/WebCore/dom/OverflowEvent.idl 2011-10-14 00:57:31 UTC (rev 97431)
@@ -27,7 +27,7 @@
interface [
CanBeConstructed,
- JSCustomConstructor
+ CustomConstructor
] OverflowEvent : Event {
const unsigned short HORIZONTAL = 0;
const unsigned short VERTICAL = 1;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
