Title: [97419] trunk
- Revision
- 97419
- Author
- [email protected]
- Date
- 2011-10-13 16:16:09 -0700 (Thu, 13 Oct 2011)
Log Message
Implement a BeforeLoadEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=69980
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/before-load-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added a BeforeLoadEvent constructor.
* dom/BeforeLoadEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
LayoutTests:
Enabled before-load-event-constructor.html, since now V8 has the BeforeLoadEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (97418 => 97419)
--- trunk/LayoutTests/ChangeLog 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 23:16:09 UTC (rev 97419)
@@ -1,3 +1,14 @@
+2011-10-13 Kentaro Hara <[email protected]>
+
+ Implement a BeforeLoadEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=69980
+
+ Reviewed by Adam Barth.
+
+ Enabled before-load-event-constructor.html, since now V8 has the BeforeLoadEvent constructor.
+
+ * platform/chromium/test_expectations.txt:
+
2011-10-13 Dimitri Glazkov <[email protected]>
[Chromium] Add a colon to make expectation valid.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97418 => 97419)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 23:16:09 UTC (rev 97419)
@@ -92,9 +92,6 @@
BUGCR10395 SKIP : svg/custom/image-with-prefix-in-webarchive.svg = PASS FAIL
BUGCR10395 SKIP : http/tests/webarchive = PASS FAIL
-// This will soon be fixed after implementing a BeforeLoadEvent constructor for V8.
-BUGWK69893 : fast/events/constructors/before-load-event-constructor.html = FAIL
-
// This will soon be fixed after implementing an OverflowEvent constructor for V8.
BUGWK69907 : fast/events/constructors/overflow-event-constructor.html = FAIL
Modified: trunk/Source/WebCore/ChangeLog (97418 => 97419)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 23:16:09 UTC (rev 97419)
@@ -1,3 +1,15 @@
+2011-10-13 Kentaro Hara <[email protected]>
+
+ Implement a BeforeLoadEvent constructor for V8
+ https://bugs.webkit.org/show_bug.cgi?id=69980
+
+ Reviewed by Adam Barth.
+
+ Test: fast/events/constructors/before-load-event-constructor.html
+
+ * bindings/v8/custom/V8EventConstructors.cpp: Added a BeforeLoadEvent constructor.
+ * dom/BeforeLoadEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
+
2011-10-13 Joshua Bell <[email protected]>
make IDBFactory.open wait for pending setVersion transactions to complete
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (97418 => 97419)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-13 23:16:09 UTC (rev 97419)
@@ -31,6 +31,7 @@
#include "config.h"
#include "EventConstructors.h"
+#include "BeforeLoadEvent.h"
#include "CloseEvent.h"
#include "CustomEvent.h"
#include "Document.h"
@@ -45,6 +46,7 @@
#include "WebKitTransitionEvent.h"
#include "OptionsObject.h"
+#include "V8BeforeLoadEvent.h"
#include "V8Binding.h"
#include "V8BindingMacros.h"
#include "V8CloseEvent.h"
@@ -123,6 +125,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_ERROR_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_BEFORE_LOAD_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/BeforeLoadEvent.idl (97418 => 97419)
--- trunk/Source/WebCore/dom/BeforeLoadEvent.idl 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/Source/WebCore/dom/BeforeLoadEvent.idl 2011-10-13 23:16:09 UTC (rev 97419)
@@ -28,7 +28,7 @@
interface [
CanBeConstructed,
- JSCustomConstructor
+ CustomConstructor
] BeforeLoadEvent : Event {
void initBeforeLoadEvent(in [Optional=CallWithDefaultValue] DOMString type,
in [Optional=CallWithDefaultValue] boolean canBubble,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
