Title: [97311] trunk/Tools
- Revision
- 97311
- Author
- [email protected]
- Date
- 2011-10-12 15:44:46 -0700 (Wed, 12 Oct 2011)
Log Message
_run_tests is a confusing variable name in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=69971
Reviewed by Eric Seidel.
Eric and I thought this was a function.
* Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (97310 => 97311)
--- trunk/Tools/ChangeLog 2011-10-12 22:30:39 UTC (rev 97310)
+++ trunk/Tools/ChangeLog 2011-10-12 22:44:46 UTC (rev 97311)
@@ -1,3 +1,14 @@
+2011-10-12 Adam Barth <[email protected]>
+
+ _run_tests is a confusing variable name in webkitpy
+ https://bugs.webkit.org/show_bug.cgi?id=69971
+
+ Reviewed by Eric Seidel.
+
+ Eric and I thought this was a function.
+
+ * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
+
2011-10-12 Tony Chang <[email protected]>
Fix test-webkitpy after r97307 and r97293.
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py (97310 => 97311)
--- trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py 2011-10-12 22:30:39 UTC (rev 97310)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py 2011-10-12 22:44:46 UTC (rev 97311)
@@ -40,9 +40,9 @@
class EarlyWarningSystemTask(PatchAnalysisTask):
- def __init__(self, delegate, patch, run_tests=True):
+ def __init__(self, delegate, patch, should_run_tests=True):
PatchAnalysisTask.__init__(self, delegate, patch)
- self._run_tests = run_tests
+ self._should_run_tests = should_run_tests
def validate(self):
self._patch = self._delegate.refetch_patch(self._patch)
@@ -67,6 +67,6 @@
if not self._build_without_patch():
return False
return self.report_failure()
- if not self._run_tests:
+ if not self._should_run_tests:
return True
return self._test_patch()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
