Title: [97176] trunk/Tools
- Revision
- 97176
- Author
- [email protected]
- Date
- 2011-10-11 13:44:37 -0700 (Tue, 11 Oct 2011)
Log Message
garden-o-matic links to flakiness dashboard should open in a new tab
https://bugs.webkit.org/show_bug.cgi?id=69864
Reviewed by Dimitri Glazkov.
This bug was obvious in the first five minutes of using this new
feature. :)
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (97175 => 97176)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-10-11 20:44:22 UTC (rev 97175)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-10-11 20:44:37 UTC (rev 97176)
@@ -92,6 +92,7 @@
init: function(groupName, testNameList)
{
var link = this.appendChild(document.createElement('a'));
+ link.target = '_blank';
link.href = ""
link.textContent = groupName;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (97175 => 97176)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-10-11 20:44:22 UTC (rev 97175)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-10-11 20:44:37 UTC (rev 97176)
@@ -79,7 +79,7 @@
test('FailingTestGroup', 2, function() {
var failingTest = new ui.notifications.FailingTestGroup('test', ['test.html']);
equal(failingTest.tagName, 'LI');
- equal(failingTest.innerHTML, '<a href=""
+ equal(failingTest.innerHTML, '<a target="_blank" href=""
});
test('SuspiciousCommit', 2, function() {
@@ -130,7 +130,7 @@
'<div class="what">' +
'<div class="problem">' +
'<ul class="effects">' +
- '<li><a href="" +
+ '<li><a target="_blank" href="" +
'</ul>' +
'<ul class="actions">' +
'<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
@@ -153,7 +153,7 @@
'<div class="what">' +
'<div class="problem">' +
'<ul class="effects">' +
- '<li><a href="" +
+ '<li><a target="_blank" href="" +
'</ul>' +
'<ul class="actions">' +
'<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
@@ -178,7 +178,7 @@
'<div class="what">' +
'<div class="problem">' +
'<ul class="effects">' +
- '<li><a href="" +
+ '<li><a target="_blank" href="" +
'</ul>' +
'<ul class="actions">' +
'<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
@@ -218,8 +218,8 @@
'<div class="what">' +
'<div class="problem">' +
'<ul class="effects">' +
- '<li><a href="" +
- '<li><a href="" +
+ '<li><a target="_blank" href="" +
+ '<li><a target="_blank" href="" +
'</ul>' +
'<ul class="actions">' +
'<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
@@ -263,8 +263,8 @@
'<div class="what">' +
'<div class="problem">' +
'<ul class="effects">' +
- '<li><a href="" +
- '<li><a href="" +
+ '<li><a target="_blank" href="" +
+ '<li><a target="_blank" href="" +
'</ul>' +
'<ul class="actions">' +
'<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
@@ -304,8 +304,8 @@
'<div class="what">' +
'<div class="problem">' +
'<ul class="effects">' +
- '<li><a href="" (4 tests)</a></li>' +
- '<li><a href="" +
+ '<li><a target="_blank" href="" (4 tests)</a></li>' +
+ '<li><a target="_blank" href="" +
'</ul>' +
'<ul class="actions">' +
'<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
Modified: trunk/Tools/ChangeLog (97175 => 97176)
--- trunk/Tools/ChangeLog 2011-10-11 20:44:22 UTC (rev 97175)
+++ trunk/Tools/ChangeLog 2011-10-11 20:44:37 UTC (rev 97176)
@@ -1,5 +1,18 @@
2011-10-11 Adam Barth <[email protected]>
+ garden-o-matic links to flakiness dashboard should open in a new tab
+ https://bugs.webkit.org/show_bug.cgi?id=69864
+
+ Reviewed by Dimitri Glazkov.
+
+ This bug was obvious in the first five minutes of using this new
+ feature. :)
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
+
+2011-10-11 Adam Barth <[email protected]>
+
Tweak the Content-Security-Policy for garden-o-matic. It turns out
that * doesn't really mean "all". I've emailed the W3C working group
about changing the spec.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
