Title: [96947] trunk/Source/WebCore
- Revision
- 96947
- Author
- [email protected]
- Date
- 2011-10-07 09:42:54 -0700 (Fri, 07 Oct 2011)
Log Message
Functions that return "const Color" should simply return "Color".
Rubber-stamped by Antti Koivisto.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::rendererBackgroundColor):
* rendering/RenderLayerBacking.h:
* rendering/RenderTable.h:
(WebCore::RenderTable::bgColor):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
* rendering/style/RenderStyle.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (96946 => 96947)
--- trunk/Source/WebCore/ChangeLog 2011-10-07 16:35:29 UTC (rev 96946)
+++ trunk/Source/WebCore/ChangeLog 2011-10-07 16:42:54 UTC (rev 96947)
@@ -1,3 +1,19 @@
+2011-10-07 Andreas Kling <[email protected]>
+
+ Functions that return "const Color" should simply return "Color".
+
+ Rubber-stamped by Antti Koivisto.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::rendererBackgroundColor):
+ * rendering/RenderLayerBacking.h:
+ * rendering/RenderTable.h:
+ (WebCore::RenderTable::bgColor):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::colorIncludingFallback):
+ (WebCore::RenderStyle::visitedDependentColor):
+ * rendering/style/RenderStyle.h:
+
2011-10-07 Pavel Feldman <[email protected]>
Web Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (96946 => 96947)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-10-07 16:35:29 UTC (rev 96946)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-10-07 16:42:54 UTC (rev 96947)
@@ -757,7 +757,7 @@
return renderer()->hasBackground();
}
-const Color RenderLayerBacking::rendererBackgroundColor() const
+Color RenderLayerBacking::rendererBackgroundColor() const
{
// FIXME: share more code here
if (renderer()->node() && renderer()->node()->isDocumentNode()) {
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.h (96946 => 96947)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.h 2011-10-07 16:35:29 UTC (rev 96946)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.h 2011-10-07 16:42:54 UTC (rev 96947)
@@ -185,7 +185,7 @@
void updateImageContents();
bool rendererHasBackground() const;
- const Color rendererBackgroundColor() const;
+ Color rendererBackgroundColor() const;
void updateBackgroundColor();
bool hasNonCompositingDescendants() const;
Modified: trunk/Source/WebCore/rendering/RenderTable.h (96946 => 96947)
--- trunk/Source/WebCore/rendering/RenderTable.h 2011-10-07 16:35:29 UTC (rev 96946)
+++ trunk/Source/WebCore/rendering/RenderTable.h 2011-10-07 16:42:54 UTC (rev 96947)
@@ -84,7 +84,7 @@
return style()->isLeftToRightDirection() ? borderEnd() : borderStart();
}
- const Color bgColor() const { return style()->visitedDependentColor(CSSPropertyBackgroundColor); }
+ Color bgColor() const { return style()->visitedDependentColor(CSSPropertyBackgroundColor); }
LayoutUnit outerBorderBefore() const;
LayoutUnit outerBorderAfter() const;
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (96946 => 96947)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2011-10-07 16:35:29 UTC (rev 96946)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2011-10-07 16:42:54 UTC (rev 96947)
@@ -1121,7 +1121,7 @@
}
}
-const Color RenderStyle::colorIncludingFallback(int colorProperty) const
+Color RenderStyle::colorIncludingFallback(int colorProperty) const
{
Color result;
EBorderStyle borderStyle = BNONE;
@@ -1177,7 +1177,7 @@
return result;
}
-const Color RenderStyle::visitedDependentColor(int colorProperty) const
+Color RenderStyle::visitedDependentColor(int colorProperty) const
{
Color unvisitedColor = colorIncludingFallback(colorProperty);
if (insideLink() != InsideVisitedLink)
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (96946 => 96947)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2011-10-07 16:35:29 UTC (rev 96946)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2011-10-07 16:42:54 UTC (rev 96947)
@@ -1345,7 +1345,7 @@
unsigned childIndex() const { return m_childIndex; }
void setChildIndex(unsigned index) { m_unique = true; m_childIndex = index; }
- const Color visitedDependentColor(int colorProperty) const;
+ Color visitedDependentColor(int colorProperty) const;
// Initial values for all the properties
static EBorderCollapse initialBorderCollapse() { return BSEPARATE; }
@@ -1525,7 +1525,7 @@
Color textFillColor() const { return rareInheritedData->textFillColor; }
Color textStrokeColor() const { return rareInheritedData->textStrokeColor; }
- const Color colorIncludingFallback(int colorProperty) const;
+ Color colorIncludingFallback(int colorProperty) const;
#if ENABLE(SVG)
Color stopColor() const { return svgStyle()->stopColor(); }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes