Title: [96936] trunk/Source/_javascript_Core
- Revision
- 96936
- Author
- [email protected]
- Date
- 2011-10-07 07:49:45 -0700 (Fri, 07 Oct 2011)
Log Message
[JSC] Disable ThreadRestrictionVerifier for JIT ExecutableMemoryHandles
https://bugs.webkit.org/show_bug.cgi?id=69599
Reviewed by Sam Weinig.
DFG JIT manipulates MetaAllocatorHandles across threads, eg in
allocating JITCode buffers on a background thread to execute a
proxy autoconfiguration PAC file but garbage collecting it in
response to allocation on the main thread. Disabling
ThreadRestrictionVerification until there is a verification scheme
that understands this handoff.
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::allocate):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96935 => 96936)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-07 14:28:40 UTC (rev 96935)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-07 14:49:45 UTC (rev 96936)
@@ -1,3 +1,20 @@
+2011-10-07 Dominic Cooney <[email protected]>
+
+ [JSC] Disable ThreadRestrictionVerifier for JIT ExecutableMemoryHandles
+ https://bugs.webkit.org/show_bug.cgi?id=69599
+
+ Reviewed by Sam Weinig.
+
+ DFG JIT manipulates MetaAllocatorHandles across threads, eg in
+ allocating JITCode buffers on a background thread to execute a
+ proxy autoconfiguration PAC file but garbage collecting it in
+ response to allocation on the main thread. Disabling
+ ThreadRestrictionVerification until there is a verification scheme
+ that understands this handoff.
+
+ * wtf/MetaAllocator.cpp:
+ (WTF::MetaAllocator::allocate):
+
2011-10-06 Filip Pizlo <[email protected]>
DFG should not always speculate that ConvertThis is operating on an object
Modified: trunk/Source/_javascript_Core/wtf/MetaAllocator.cpp (96935 => 96936)
--- trunk/Source/_javascript_Core/wtf/MetaAllocator.cpp 2011-10-07 14:28:40 UTC (rev 96935)
+++ trunk/Source/_javascript_Core/wtf/MetaAllocator.cpp 2011-10-07 14:49:45 UTC (rev 96936)
@@ -153,7 +153,12 @@
#if ENABLE(META_ALLOCATOR_PROFILE)
m_numAllocations++;
#endif
- return adoptRef(new MetaAllocatorHandle(this, start, sizeInBytes));
+
+ MetaAllocatorHandle* handle = new MetaAllocatorHandle(this, start, sizeInBytes);
+ // FIXME: Implement a verifier scheme that groks MetaAllocatorHandles
+ handle->deprecatedTurnOffVerifier();
+
+ return adoptRef(handle);
}
MetaAllocator::Statistics MetaAllocator::currentStatistics()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
