Title: [96877] trunk/Source/WebCore
Revision
96877
Author
[email protected]
Date
2011-10-06 16:58:10 -0700 (Thu, 06 Oct 2011)

Log Message

Return null for the value of IDB key cursors instead of ASSERTing
https://bugs.webkit.org/show_bug.cgi?id=69131

This is in support of the IndexedDB performance improvement here:
http://codereview.chromium.org/7834006/

Reviewed by Tony Chang.

* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::value):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (96876 => 96877)


--- trunk/Source/WebCore/ChangeLog	2011-10-06 23:52:21 UTC (rev 96876)
+++ trunk/Source/WebCore/ChangeLog	2011-10-06 23:58:10 UTC (rev 96877)
@@ -1,3 +1,16 @@
+2011-10-06  David Grogan  <[email protected]>
+
+        Return null for the value of IDB key cursors instead of ASSERTing
+        https://bugs.webkit.org/show_bug.cgi?id=69131
+        
+        This is in support of the IndexedDB performance improvement here:
+        http://codereview.chromium.org/7834006/
+
+        Reviewed by Tony Chang.
+
+        * storage/IDBCursorBackendImpl.cpp:
+        (WebCore::IDBCursorBackendImpl::value):
+
 2011-10-06  Alexey Proskuryakov  <[email protected]>
 
         [Mac] Should be able to scroll embedded PDFs using mouse

Modified: trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp (96876 => 96877)


--- trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp	2011-10-06 23:52:21 UTC (rev 96876)
+++ trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp	2011-10-06 23:58:10 UTC (rev 96877)
@@ -73,7 +73,8 @@
 
 PassRefPtr<SerializedScriptValue> IDBCursorBackendImpl::value() const
 {
-    ASSERT(m_cursorType != IndexKeyCursor);
+    if (m_cursorType == IndexKeyCursor)
+      return SerializedScriptValue::nullValue();
     return SerializedScriptValue::createFromWire(m_cursor->value());
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to