Title: [96816] trunk/Source/WebCore
Revision
96816
Author
[email protected]
Date
2011-10-06 09:22:10 -0700 (Thu, 06 Oct 2011)

Log Message

Web Inspector: extract DOMPresentation, make EventListenersSidebar compile
https://bugs.webkit.org/show_bug.cgi?id=69527

Reviewed by Yury Semikhatsky.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.nodeNameInCorrectCase):
(WebInspector.DOMNode.prototype.moveTo):
(WebInspector.DOMNode.prototype.isXMLNode):
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint):
* inspector/front-end/DOMPresentation.js: Added.
(WebInspector.DOMPresentation.decorateNodeLabel):
(WebInspector.DOMPresentation.linkifyNodeReference):
(WebInspector.DOMPresentation.linkifyNodeById):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
* inspector/front-end/EventListenersSidebarPane.js:
* inspector/front-end/ObjectPropertiesSection.js:
* inspector/front-end/PropertiesSection.js:
* inspector/front-end/Section.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

Modified Paths

Added Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (96815 => 96816)


--- trunk/Source/WebCore/ChangeLog	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/ChangeLog	2011-10-06 16:22:10 UTC (rev 96816)
@@ -1,5 +1,39 @@
 2011-10-06  Pavel Feldman  <[email protected]>
 
+        Web Inspector: extract DOMPresentation, make EventListenersSidebar compile
+        https://bugs.webkit.org/show_bug.cgi?id=69527
+
+        Reviewed by Yury Semikhatsky.
+
+        * WebCore.gypi:
+        * WebCore.vcproj/WebCore.vcproj:
+        * inspector/compile-front-end.sh:
+        * inspector/front-end/DOMAgent.js:
+        (WebInspector.DOMNode.prototype.nodeNameInCorrectCase):
+        (WebInspector.DOMNode.prototype.moveTo):
+        (WebInspector.DOMNode.prototype.isXMLNode):
+        * inspector/front-end/DOMBreakpointsSidebarPane.js:
+        (WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint):
+        * inspector/front-end/DOMPresentation.js: Added.
+        (WebInspector.DOMPresentation.decorateNodeLabel):
+        (WebInspector.DOMPresentation.linkifyNodeReference):
+        (WebInspector.DOMPresentation.linkifyNodeById):
+        * inspector/front-end/ElementsPanel.js:
+        (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
+        * inspector/front-end/EventListenersSidebarPane.js:
+        * inspector/front-end/ObjectPropertiesSection.js:
+        * inspector/front-end/PropertiesSection.js:
+        * inspector/front-end/Section.js:
+        * inspector/front-end/StylesSidebarPane.js:
+        (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
+        (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
+        * inspector/front-end/WebKit.qrc:
+        * inspector/front-end/inspector.html:
+
+2011-10-06  Pavel Feldman  <[email protected]>
+
         Web Inspector: add all Resource panel views to the compilation.
         https://bugs.webkit.org/show_bug.cgi?id=69526
 
@@ -27,6 +61,35 @@
         (WebInspector.ResourcesPanel.prototype.showDatabase):
         * inspector/front-end/TextPrompt.js:
 
+2011-10-06  Pavel Feldman  <[email protected]>
+
+        Web Inspector: add all Resource panel views to the compilation.
+        https://bugs.webkit.org/show_bug.cgi?id=69526
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/compile-front-end.sh:
+        * inspector/front-end/CookieItemsView.js:
+        (WebInspector.CookieItemsView.prototype._contextMenu):
+        (WebInspector.Cookies.cookieMatchesResourceURL):
+        * inspector/front-end/CookiesTable.js:
+        (WebInspector.CookiesTable):
+        (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
+        * inspector/front-end/DOMStorageItemsView.js:
+        (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
+        * inspector/front-end/DataGrid.js:
+        (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid.comparator):
+        (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
+        (WebInspector.DataGrid.createSortableDataGrid):
+        * inspector/front-end/DatabaseQueryView.js:
+        (WebInspector.DatabaseQueryView.prototype._queryFinished):
+        * inspector/front-end/DatabaseTableView.js:
+        (WebInspector.DatabaseTableView.prototype._queryFinished):
+        * inspector/front-end/ResourcesPanel.js:
+        (WebInspector.ResourcesPanel.prototype.reset):
+        (WebInspector.ResourcesPanel.prototype.showDatabase):
+        * inspector/front-end/TextPrompt.js:
+
 2011-10-06  Sheriff Bot  <[email protected]>
 
         Unreviewed, rolling out r96791.

Modified: trunk/Source/WebCore/WebCore.gypi (96815 => 96816)


--- trunk/Source/WebCore/WebCore.gypi	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/WebCore.gypi	2011-10-06 16:22:10 UTC (rev 96816)
@@ -6247,6 +6247,7 @@
             'inspector/front-end/DetailedHeapshotView.js',
             'inspector/front-end/DOMAgent.js',
             'inspector/front-end/DOMBreakpointsSidebarPane.js',
+            'inspector/front-end/DOMPresentationUtils.js',
             'inspector/front-end/DOMStorage.js',
             'inspector/front-end/DOMStorageItemsView.js',
             'inspector/front-end/DOMSyntaxHighlighter.js',

Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (96815 => 96816)


--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-10-06 16:22:10 UTC (rev 96816)
@@ -69261,6 +69261,10 @@
 					>
 				</File>
 				<File
+					RelativePath="..\inspector\front-end\DOMPresentationUtils.js"
+					>
+				</File>
+				<File
 					RelativePath="..\inspector\front-end\DOMBreakpointsSidebarPane.js"
 					>
 				</File>

Modified: trunk/Source/WebCore/inspector/compile-front-end.sh (96815 => 96816)


--- trunk/Source/WebCore/inspector/compile-front-end.sh	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/compile-front-end.sh	2011-10-06 16:22:10 UTC (rev 96816)
@@ -107,14 +107,16 @@
         --js Source/WebCore/inspector/front-end/UIUtils.js \
         --js Source/WebCore/inspector/front-end/View.js \
         --js Source/WebCore/inspector/front-end/WelcomeView.js \
-    --module jsmodule_inspector:24:jsmodule_sdk,jsmodule_ui \
+    --module jsmodule_inspector:26:jsmodule_sdk,jsmodule_ui \
         --js Source/WebCore/inspector/front-end/ConsoleMessage.js \
         --js Source/WebCore/inspector/front-end/ConsoleView.js \
         --js Source/WebCore/inspector/front-end/CookieItemsView.js \
         --js Source/WebCore/inspector/front-end/DatabaseQueryView.js \
         --js Source/WebCore/inspector/front-end/DatabaseTableView.js \
+        --js Source/WebCore/inspector/front-end/DOMPresentationUtils.js \
         --js Source/WebCore/inspector/front-end/DOMStorageItemsView.js \
         --js Source/WebCore/inspector/front-end/ElementsTreeOutline.js \
+        --js Source/WebCore/inspector/front-end/EventListenersSidebarPane.js \
         --js Source/WebCore/inspector/front-end/FontView.js \
         --js Source/WebCore/inspector/front-end/ImageView.js \
         --js Source/WebCore/inspector/front-end/_javascript_ContextManager.js \
@@ -136,11 +138,12 @@
 # To be compiled...
 #
 # [Elements]
-# DOMBreakpointsSidebarPane
+#
 # ElementsPanel
-# EventListenersSidebarPane
+# BreakpointsSidebarPane
 # MetricsSidebarPane
 # StylesSidebarPane
+# DOMBreakpointsSidebarPane
 #
 # [Resources]
 # ResourcesPanel
@@ -156,7 +159,6 @@
 # ScriptFormatterWorker
 # ScriptsPanel
 # WatchExpressionsSidebarPane
-# BreakpointsSidebarPane
 # CallStackSidebarPane
 #
 # [Timeline]

Modified: trunk/Source/WebCore/inspector/front-end/DOMAgent.js (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/DOMAgent.js	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/DOMAgent.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -105,6 +105,11 @@
         return this._nodeName;
     },
 
+    nodeNameInCorrectCase: function()
+    {
+        return this.isXMLNode() ? this.nodeName() : this.nodeName().toLowerCase();
+    },
+
     setNodeName: function(name, callback)
     {
         DOMAgent.setNodeName(this.id, name, callback);
@@ -364,6 +369,11 @@
     moveTo: function(targetNode, anchorNode, callback)
     {
         DOMAgent.moveTo(this.id, targetNode.id, anchorNode ? anchorNode.id : undefined, callback);
+    },
+
+    isXMLNode: function()
+    {
+        return this.ownerDocument && !!this.ownerDocument.xmlVersion;
     }
 }
 

Modified: trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -105,11 +105,11 @@
     {
         var message;
         var typeLabel = this._breakpointTypeLabels[auxData.type];
-        var linkifiedNode = WebInspector.panels.elements.linkifyNodeById(auxData.nodeId);
+        var linkifiedNode = WebInspector.DOMPresentationUtils.linkifyNodeById(auxData.nodeId);
         var substitutions = [typeLabel, linkifiedNode];
         var targetNode = "";
         if (targetNodeId)
-            targetNode = WebInspector.panels.elements.linkifyNodeById(targetNodeId);
+            targetNode = WebInspector.DOMPresentationUtils.linkifyNodeById(targetNodeId);
 
         if (auxData.type === this._breakpointTypes.SubtreeModified) {
             if (auxData.insertion) {
@@ -185,7 +185,7 @@
         var labelElement = document.createElement("span");
         element.appendChild(labelElement);
 
-        var linkifiedNode = WebInspector.panels.elements.linkifyNodeById(node.id);
+        var linkifiedNode = WebInspector.DOMPresentationUtils.linkifyNodeById(node.id);
         linkifiedNode.addStyleClass("monospace");
         labelElement.appendChild(linkifiedNode);
 

Added: trunk/Source/WebCore/inspector/front-end/DOMPresentationUtils.js (0 => 96816)


--- trunk/Source/WebCore/inspector/front-end/DOMPresentationUtils.js	                        (rev 0)
+++ trunk/Source/WebCore/inspector/front-end/DOMPresentationUtils.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -0,0 +1,98 @@
+/*
+ * Copyright (C) 2011 Google Inc.  All rights reserved.
+ * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
+ * Copyright (C) 2008 Matt Lilek <[email protected]>
+ * Copyright (C) 2009 Joseph Pecoraro
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ *     notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ *     notice, this list of conditions and the following disclaimer in the
+ *     documentation and/or other materials provided with the distribution.
+ * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
+ *     its contributors may be used to endorse or promote products derived
+ *     from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+WebInspector.DOMPresentationUtils = {}
+
+WebInspector.DOMPresentationUtils.decorateNodeLabel = function(node, parentElement)
+{
+    var title = node.nodeNameInCorrectCase();
+
+    var nameElement = document.createElement("span");
+    nameElement.textContent = title;
+    parentElement.appendChild(nameElement);
+
+    var idAttribute = node.getAttribute("id");
+    if (idAttribute) {
+        var idElement = document.createElement("span");
+        parentElement.appendChild(idElement);
+
+        var part = "#" + idAttribute;
+        title += part;
+        idElement.appendChild(document.createTextNode(part));
+
+        // Mark the name as extra, since the ID is more important.
+        nameElement.className = "extra";
+    }
+
+    var classAttribute = node.getAttribute("class");
+    if (classAttribute) {
+        var classes = classAttribute.split(/\s+/);
+        var foundClasses = {};
+
+        if (classes.length) {
+            var classesElement = document.createElement("span");
+            classesElement.className = "extra";
+            parentElement.appendChild(classesElement);
+
+            for (var i = 0; i < classes.length; ++i) {
+                var className = classes[i];
+                if (className && !(className in foundClasses)) {
+                    var part = "." + className;
+                    title += part;
+                    classesElement.appendChild(document.createTextNode(part));
+                    foundClasses[className] = true;
+                }
+            }
+        }
+    }
+    parentElement.title = title;
+}
+
+WebInspector.DOMPresentationUtils.linkifyNodeReference = function(node)
+{
+    var link = document.createElement("span");
+    link.className = "node-link";
+    WebInspector.DOMPresentationUtils.decorateNodeLabel(node, link);
+
+    link.addEventListener("click", WebInspector.domAgent.inspectElement.bind(WebInspector.domAgent, node.id), false);
+    link.addEventListener("mouseover", WebInspector.domAgent.highlightDOMNode.bind(WebInspector.domAgent, node.id, ""), false);
+    link.addEventListener("mouseout", WebInspector.domAgent.hideDOMNodeHighlight.bind(WebInspector.domAgent), false);
+
+    return link;
+}
+
+WebInspector.DOMPresentationUtils.linkifyNodeById = function(nodeId)
+{
+    var node = WebInspector.domAgent.nodeForId(nodeId);
+    if (!node)
+        return document.createTextNode(WebInspector.UIString("<node>"));
+    return WebInspector.DOMPresentationUtils.linkifyNodeReference(node);
+}
Property changes on: trunk/Source/WebCore/inspector/front-end/DOMPresentationUtils.js
___________________________________________________________________

Added: svn:eol-style

Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -526,7 +526,7 @@
             var crumbTitle;
             switch (current.nodeType()) {
                 case Node.ELEMENT_NODE:
-                    this.decorateNodeLabel(current, crumb);
+                    WebInspector.DOMPresentationUtils.decorateNodeLabel(current, crumb);
                     break;
 
                 case Node.TEXT_NODE:
@@ -542,7 +542,7 @@
                     break;
 
                 default:
-                    crumbTitle = this.treeOutline.nodeNameToCorrectCase(current.nodeName());
+                    crumbTitle = current.nodeNameInCorrectCase();
             }
 
             if (!crumb.childNodes.length) {
@@ -568,72 +568,6 @@
         this.updateBreadcrumbSizes();
     },
 
-    decorateNodeLabel: function(node, parentElement)
-    {
-        var title = this.treeOutline.nodeNameToCorrectCase(node.nodeName());
-
-        var nameElement = document.createElement("span");
-        nameElement.textContent = title;
-        parentElement.appendChild(nameElement);
-
-        var idAttribute = node.getAttribute("id");
-        if (idAttribute) {
-            var idElement = document.createElement("span");
-            parentElement.appendChild(idElement);
-
-            var part = "#" + idAttribute;
-            title += part;
-            idElement.appendChild(document.createTextNode(part));
-
-            // Mark the name as extra, since the ID is more important.
-            nameElement.className = "extra";
-        }
-
-        var classAttribute = node.getAttribute("class");
-        if (classAttribute) {
-            var classes = classAttribute.split(/\s+/);
-            var foundClasses = {};
-
-            if (classes.length) {
-                var classesElement = document.createElement("span");
-                classesElement.className = "extra";
-                parentElement.appendChild(classesElement);
-
-                for (var i = 0; i < classes.length; ++i) {
-                    var className = classes[i];
-                    if (className && !(className in foundClasses)) {
-                        var part = "." + className;
-                        title += part;
-                        classesElement.appendChild(document.createTextNode(part));
-                        foundClasses[className] = true;
-                    }
-                }
-            }
-        }
-        parentElement.title = title;
-    },
-
-    linkifyNodeReference: function(node)
-    {
-        var link = document.createElement("span");
-        link.className = "node-link";
-        this.decorateNodeLabel(node, link);
-
-        link.addEventListener("click", this.revealAndSelectNode.bind(this, node.id), false);
-        link.addEventListener("mouseover", WebInspector.domAgent.highlightDOMNode.bind(WebInspector.domAgent, node.id, ""), false);
-        link.addEventListener("mouseout", WebInspector.domAgent.hideDOMNodeHighlight.bind(WebInspector.domAgent), false);
-
-        return link;
-    },
-
-    linkifyNodeById: function(nodeId)
-    {
-        var node = WebInspector.domAgent.nodeForId(nodeId);
-        if (!node)
-            return document.createTextNode(WebInspector.UIString("<node>"));
-        return this.linkifyNodeReference(node);
-    },
-
     updateBreadcrumbSizes: function(focusedCrumb)
     {
         if (!this.visible)

Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -110,7 +110,7 @@
 
         this._rootDOMNode = x;
 
-        this._isXMLMimeType = x && !!x.xmlVersion;
+        this._isXMLMimeType = x && x.isXMLNode();
 
         this.update();
     },
@@ -120,11 +120,6 @@
         return this._isXMLMimeType;
     },
 
-    nodeNameToCorrectCase: function(nodeName)
-    {
-        return this.isXMLMimeType ? nodeName : nodeName.toLowerCase();
-    },
-
     selectedDOMNode: function()
     {
         return this._selectedDOMNode;
@@ -1533,7 +1528,7 @@
                 break;
 
             case Node.ELEMENT_NODE:
-                var tagName = this.treeOutline.nodeNameToCorrectCase(node.nodeName());
+                var tagName = node.nodeNameInCorrectCase();
                 if (this._elementCloseTag) {
                     this._buildTagDOM(info.titleDOM, tagName, true, true);
                     info.hasChildren = false;
@@ -1613,7 +1608,7 @@
                 cdataElement.appendChild(document.createTextNode("<![CDATA[" + node.nodeValue() + "]]>"));
                 break;
             default:
-                var defaultElement = info.titleDOM.appendChild(document.createTextNode(this.treeOutline.nodeNameToCorrectCase(node.nodeName()).collapseWhitespace()));
+                var defaultElement = info.titleDOM.appendChild(document.createTextNode(node.nodeNameInCorrectCase().collapseWhitespace()));
         }
 
         return info;

Modified: trunk/Source/WebCore/inspector/front-end/EventListenersSidebarPane.js (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/EventListenersSidebarPane.js	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/EventListenersSidebarPane.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -27,6 +27,10 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/**
+ * @constructor
+ * @extends {WebInspector.SidebarPane}
+ */
 WebInspector.EventListenersSidebarPane = function()
 {
     WebInspector.SidebarPane.call(this, WebInspector.UIString("Event Listeners"));
@@ -128,6 +132,10 @@
 
 WebInspector.EventListenersSidebarPane.prototype.__proto__ = WebInspector.SidebarPane.prototype;
 
+/**
+ * @constructor
+ * @extends {WebInspector.PropertiesSection}
+ */
 WebInspector.EventListenersSection = function(title, nodeId, linkifier)
 {
     this.eventListeners = [];
@@ -176,11 +184,16 @@
 
 WebInspector.EventListenersSection.prototype.__proto__ = WebInspector.PropertiesSection.prototype;
 
+/**
+ * @constructor
+ * @extends {WebInspector.ObjectPropertiesSection}
+ */
 WebInspector.EventListenerBar = function(eventListener, nodeId, linkifier)
 {
+    WebInspector.ObjectPropertiesSection.call(this);
+
     this.eventListener = eventListener;
     this._nodeId = nodeId;
-    WebInspector.ObjectPropertiesSection.call(this);
     this._setNodeTitle();
     this._setFunctionSubtitle(linkifier);
     this.editable = false;
@@ -233,7 +246,7 @@
         }
 
         this.titleElement.removeChildren();
-        this.titleElement.appendChild(WebInspector.panels.elements.linkifyNodeReference(this.eventListener.node));
+        this.titleElement.appendChild(WebInspector.DOMPresentationUtils.linkifyNodeReference(this.eventListener.node));
     },
 
     _setFunctionSubtitle: function(linkifier)

Modified: trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -27,6 +27,7 @@
 /**
  * @constructor
  * @extends {WebInspector.PropertiesSection}
+ * @param {*=} object
  * @param {string=} title
  * @param {string=} subtitle
  * @param {string=} emptyPlaceholder

Modified: trunk/Source/WebCore/inspector/front-end/PropertiesSection.js (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/PropertiesSection.js	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/PropertiesSection.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -30,6 +30,7 @@
 /**
  * @constructor
  * @extends {WebInspector.Section}
+ * @param {string=} subtitle
  */
 WebInspector.PropertiesSection = function(title, subtitle)
 {

Modified: trunk/Source/WebCore/inspector/front-end/Section.js (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/Section.js	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/Section.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -29,6 +29,7 @@
 
 /**
  * @constructor
+ * @param {string=} subtitle
  */
 WebInspector.Section = function(title, subtitle)
 {

Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2011-10-06 16:22:10 UTC (rev 96816)
@@ -388,7 +388,7 @@
         {
             for (var name in styles.styleAttributes) {
                 var attrStyle = { style: styles.styleAttributes[name], editable: false };
-                attrStyle.selectorText = WebInspector.panels.elements.treeOutline.nodeNameToCorrectCase(node.nodeName()) + "[" + name;
+                attrStyle.selectorText = node.nodeNameInCorrectCase() + "[" + name;
                 if (node.getAttribute(name))
                     attrStyle.selectorText += "=" + node.getAttribute(name);
                 attrStyle.selectorText += "]";
@@ -573,7 +573,7 @@
                 var separatorElement = document.createElement("div");
                 separatorElement.className = "styles-sidebar-separator";
                 if (styleRule.node) {
-                    var link = WebInspector.panels.elements.linkifyNodeReference(styleRule.node);
+                    var link = WebInspector.DOMPresentationUtils.linkifyNodeReference(styleRule.node);
                     separatorElement.appendChild(document.createTextNode(WebInspector.UIString("Inherited from") + " "));
                     separatorElement.appendChild(link);
                     if (!sections.inheritedPropertiesSeparatorElement)

Modified: trunk/Source/WebCore/inspector/front-end/WebKit.qrc (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/WebKit.qrc	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/WebKit.qrc	2011-10-06 16:22:10 UTC (rev 96816)
@@ -39,6 +39,7 @@
     <file>DebuggerPresentationModel.js</file>
     <file>DOMAgent.js</file>
     <file>DOMBreakpointsSidebarPane.js</file>
+    <file>DOMPresentationUtils.js</file>
     <file>DOMStorage.js</file>
     <file>DOMStorageItemsView.js</file>
     <file>DOMSyntaxHighlighter.js</file>

Modified: trunk/Source/WebCore/inspector/front-end/inspector.html (96815 => 96816)


--- trunk/Source/WebCore/inspector/front-end/inspector.html	2011-10-06 16:12:03 UTC (rev 96815)
+++ trunk/Source/WebCore/inspector/front-end/inspector.html	2011-10-06 16:22:10 UTC (rev 96816)
@@ -84,6 +84,7 @@
     <script type="text/_javascript_" src=""
     <script type="text/_javascript_" src=""
     <script type="text/_javascript_" src=""
+    <script type="text/_javascript_" src=""
     <script type="text/_javascript_" src=""
     <script type="text/_javascript_" src=""
     <script type="text/_javascript_" src=""
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to