Title: [96575] trunk/Source/WebCore
Revision
96575
Author
[email protected]
Date
2011-10-04 01:37:04 -0700 (Tue, 04 Oct 2011)

Log Message

Web Inspector: add DebuggerPresentationModel and ConsoleView to compilation.
https://bugs.webkit.org/show_bug.cgi?id=69269

Reviewed by Yury Semikhatsky.

* inspector/compile-front-end.sh:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._messagesClicked):
* inspector/front-end/ContentProviders.js:
(WebInspector.StaticContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider.prototype.searchInContent):
* inspector/front-end/ContextMenu.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/HelpScreen.js:
* inspector/front-end/_javascript_ContextManager.js:
(WebInspector.FrameEvaluationContext.prototype.get displayName):
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut):
* inspector/front-end/Resource.js:
(WebInspector.Resource.displayName):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype._didFormatContent):
* inspector/front-end/ShortcutsScreen.js:
* inspector/front-end/StatusBarButton.js:
* inspector/front-end/TextPrompt.js:
* inspector/front-end/externs.js:
(WebInspector.populateHrefContextMenu):
(WebInspector.useLowerCaseMenuTitles):
(WebInspector.ScriptsPanel.this.evaluateInSelectedCallFrame):
(WebInspector.ScriptsPanel.this.getSelectedCallFrameVariables):
(WebInspector.ScriptsPanel):
* inspector/front-end/inspector.js:
* inspector/front-end/utilities.js:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (96574 => 96575)


--- trunk/Source/WebCore/ChangeLog	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/ChangeLog	2011-10-04 08:37:04 UTC (rev 96575)
@@ -1,3 +1,53 @@
+2011-10-03  Pavel Feldman  <[email protected]>
+
+        Web Inspector: add DebuggerPresentationModel and ConsoleView to compilation.
+        https://bugs.webkit.org/show_bug.cgi?id=69269
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/compile-front-end.sh:
+        * inspector/front-end/BreakpointManager.js:
+        (WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleView.prototype._consoleCleared):
+        (WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
+        (WebInspector.ConsoleView.prototype._completions.evaluated):
+        (WebInspector.ConsoleView.prototype._messagesClicked):
+        * inspector/front-end/ContentProviders.js:
+        (WebInspector.StaticContentProvider.prototype.requestContent):
+        (WebInspector.StaticContentProvider.prototype.searchInContent):
+        * inspector/front-end/ContextMenu.js:
+        * inspector/front-end/DebuggerPresentationModel.js:
+        (WebInspector.DebuggerPresentationModel.prototype._addScript):
+        (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
+        (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
+        (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
+        (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
+        (WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
+        (WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
+        (WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
+        (WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
+        * inspector/front-end/HelpScreen.js:
+        * inspector/front-end/_javascript_ContextManager.js:
+        (WebInspector.FrameEvaluationContext.prototype.get displayName):
+        * inspector/front-end/KeyboardShortcut.js:
+        (WebInspector.KeyboardShortcut):
+        * inspector/front-end/Resource.js:
+        (WebInspector.Resource.displayName):
+        * inspector/front-end/ScriptFormatter.js:
+        (WebInspector.ScriptFormatter.prototype._didFormatContent):
+        * inspector/front-end/ShortcutsScreen.js:
+        * inspector/front-end/StatusBarButton.js:
+        * inspector/front-end/TextPrompt.js:
+        * inspector/front-end/externs.js:
+        (WebInspector.populateHrefContextMenu):
+        (WebInspector.useLowerCaseMenuTitles):
+        (WebInspector.ScriptsPanel.this.evaluateInSelectedCallFrame):
+        (WebInspector.ScriptsPanel.this.getSelectedCallFrameVariables):
+        (WebInspector.ScriptsPanel):
+        * inspector/front-end/inspector.js:
+        * inspector/front-end/utilities.js:
+
 2011-10-03  Ryosuke Niwa  <[email protected]>
 
         Mac release build fix after r96561, and Leopard build fix after r96568.

Modified: trunk/Source/WebCore/inspector/compile-front-end.sh (96574 => 96575)


--- trunk/Source/WebCore/inspector/compile-front-end.sh	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/compile-front-end.sh	2011-10-04 08:37:04 UTC (rev 96575)
@@ -44,25 +44,37 @@
         --js Source/WebCore/inspector/front-end/Object.js \
         --js Source/WebCore/inspector/front-end/Settings.js \
         --js Source/WebCore/inspector/front-end/UserMetrics.js \
-    --module jsmodule_sdk:9:jsmodule_common,jsmodule_host \
+    --module jsmodule_sdk:16:jsmodule_common,jsmodule_host \
+        --js Source/WebCore/inspector/front-end/ConsoleModel.js \
+        --js Source/WebCore/inspector/front-end/ContentProviders.js \
+        --js Source/WebCore/inspector/front-end/CookieParser.js \
+        --js Source/WebCore/inspector/front-end/BreakpointManager.js \
         --js Source/WebCore/inspector/front-end/DOMAgent.js \
         --js Source/WebCore/inspector/front-end/DebuggerModel.js \
+        --js Source/WebCore/inspector/front-end/DebuggerPresentationModel.js \
         --js Source/WebCore/inspector/front-end/Script.js \
+        --js Source/WebCore/inspector/front-end/ScriptFormatter.js \
+        --js Source/WebCore/inspector/front-end/RawSourceCode.js \
         --js Source/WebCore/inspector/front-end/RemoteObject.js \
         --js Source/WebCore/inspector/front-end/ResourceCategory.js \
-        --js Source/WebCore/inspector/front-end/CookieParser.js \
-        --js Source/WebCore/inspector/front-end/ConsoleModel.js \
+        --js Source/WebCore/inspector/front-end/ResourceTreeModel.js \
         --js Source/WebCore/inspector/front-end/Resource.js \
         --js Source/WebCore/inspector/front-end/NetworkManager.js \
-    --module jsmodule_misc:11:jsmodule_sdk \
+        --js Source/WebCore/inspector/front-end/UISourceCode.js \
+    --module jsmodule_misc:16:jsmodule_sdk \
         --js Source/WebCore/inspector/front-end/Checkbox.js \
         --js Source/WebCore/inspector/front-end/ContextMenu.js \
         --js Source/WebCore/inspector/front-end/ConsoleMessage.js \
+        --js Source/WebCore/inspector/front-end/ConsoleView.js \
+        --js Source/WebCore/inspector/front-end/HelpScreen.js \
         --js Source/WebCore/inspector/front-end/KeyboardShortcut.js \
+        --js Source/WebCore/inspector/front-end/_javascript_ContextManager.js \
         --js Source/WebCore/inspector/front-end/View.js \
         --js Source/WebCore/inspector/front-end/Placard.js \
         --js Source/WebCore/inspector/front-end/Popover.js \
         --js Source/WebCore/inspector/front-end/SoftContextMenu.js \
+        --js Source/WebCore/inspector/front-end/ShortcutsScreen.js \
+        --js Source/WebCore/inspector/front-end/StatusBarButton.js \
         --js Source/WebCore/inspector/front-end/TabbedPane.js \
         --js Source/WebCore/inspector/front-end/TextPrompt.js \
         --js Source/WebCore/inspector/front-end/TimelineManager.js

Modified: trunk/Source/WebCore/inspector/front-end/BreakpointManager.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/BreakpointManager.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/BreakpointManager.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -59,7 +59,7 @@
             breakpoint.uiSourceCode = uiSourceCode;
             this._materializeBreakpoint(breakpoint);
             if (breakpoint._debuggerLocation)
-                this._breakpointDebuggerLocationChanged(breakpoint, breakpoint._debuggerLocation);
+                this._breakpointDebuggerLocationChanged(breakpoint);
         }
     },
 

Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -32,12 +32,13 @@
 /**
  * @extends {WebInspector.View}
  * @constructor
+ * @param {boolean} hideContextSelector
  */
-WebInspector.ConsoleView = function()
+WebInspector.ConsoleView = function(hideContextSelector)
 {
     WebInspector.View.call(this);
+
     this.element.id = "console-view";
-
     this.messages = [];
 
     this._clearConsoleButton = new WebInspector.StatusBarButton(WebInspector.UIString("Clear console log."), "clear-status-bar-item");
@@ -47,7 +48,7 @@
     this._contextSelectElement.id = "console-context";
     this._contextSelectElement.className = "status-bar-item";
 
-    if (WebInspector.WorkerManager.isWorkerFrontend())
+    if (hideContextSelector)
         this._contextSelectElement.addStyleClass("hidden");
 
     this.messagesElement = document.createElement("div");
@@ -324,9 +325,6 @@
         this.currentGroup = this.topGroup;
         this.topGroup.messagesElement.removeChildren();
 
-        delete this.commandSincePreviousMessage;
-        delete this.previousMessage;
-
         this.dispatchEventToListeners(WebInspector.ConsoleView.Events.ConsoleCleared);
     },
 
@@ -354,7 +352,7 @@
             return;
         }
 
-        if (parseInt(expressionString) == expressionString) {
+        if (parseInt(expressionString, 10) == expressionString) {
             // User is entering float value, do not suggest anything.
             completionsReadyCallback([]);
             return;
@@ -376,11 +374,11 @@
             {
                 var object;
                 if (primitiveType === "string")
-                    object = new String();
+                    object = new String("");
                 else if (primitiveType === "number")
-                    object = new Number();
+                    object = new Number(0);
                 else if (primitiveType === "boolean")
-                    object = new Boolean();
+                    object = new Boolean(false);
                 else
                     object = this;
 
@@ -499,16 +497,8 @@
 
     _messagesClicked: function(event)
     {
-        var link = event.target.enclosingNodeOrSelfWithNodeName("a");
-        if (!link || !link.representedNode) {
-            if (!this.prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)
-                this.prompt.moveCaretToEndOfPrompt();
-            return;
-        }
-
-        WebInspector.updateFocusedNode(link.representedNode.id);
-        event.stopPropagation();
-        event.preventDefault();
+        if (!this.prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)
+            this.prompt.moveCaretToEndOfPrompt();
     },
 
     _registerShortcuts: function()
@@ -572,7 +562,7 @@
 
     evalInInspectedWindow: function(_expression_, objectGroup, includeCommandLineAPI, doNotPauseOnExceptions, returnByValue, callback)
     {
-        if (WebInspector.panels.scripts && WebInspector.panels.scripts.paused) {
+        if (WebInspector.panels.scripts.paused) {
             WebInspector.panels.scripts.evaluateInSelectedCallFrame(_expression_, objectGroup, includeCommandLineAPI, returnByValue, callback);
             return;
         }
@@ -642,6 +632,9 @@
 
 WebInspector.ConsoleView.prototype.__proto__ = WebInspector.View.prototype;
 
+/**
+ * @constructor
+ */
 WebInspector.ConsoleCommand = function(command)
 {
     this.command = command;
@@ -697,6 +690,10 @@
     },
 }
 
+/**
+ * @extends {WebInspector.ConsoleMessageImpl}
+ * @constructor
+ */
 WebInspector.ConsoleCommandResult = function(result, wasThrown, originatingCommand)
 {
     var level = (wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log);
@@ -715,6 +712,9 @@
 
 WebInspector.ConsoleCommandResult.prototype.__proto__ = WebInspector.ConsoleMessageImpl.prototype;
 
+/**
+ * @constructor
+ */
 WebInspector.ConsoleGroup = function(parentGroup)
 {
     this.parentGroup = parentGroup;

Modified: trunk/Source/WebCore/inspector/front-end/ContentProviders.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/ContentProviders.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/ContentProviders.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -186,7 +186,10 @@
 
 WebInspector.ResourceContentProvider.prototype.__proto__ = WebInspector.ContentProvider.prototype;
 
-
+/**
+ * @constructor
+ * @implements {WebInspector.ContentProvider}
+ */
 WebInspector.StaticContentProvider = function(mimeType, content)
 {
     this._mimeType = mimeType;
@@ -197,6 +200,11 @@
     requestContent: function(callback)
     {
         callback(this._mimeType, this._content);
+    },
+
+    searchInContent: function(query, callback)
+    {
+        callback([]);
     }
 }
 

Modified: trunk/Source/WebCore/inspector/front-end/ContextMenu.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/ContextMenu.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/ContextMenu.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -50,6 +50,9 @@
         event.stopPropagation();
     },
 
+    /**
+     * @param {boolean=} disabled
+     */
     appendItem: function(label, handler, disabled)
     {
         var id = this._items.length;
@@ -57,6 +60,9 @@
         this._handlers[id] = handler;
     },
 
+    /**
+     * @param {boolean=} disabled
+     */
     appendCheckboxItem: function(label, handler, checked, disabled)
     {
         var id = this._items.length;

Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -30,6 +30,7 @@
 
 /**
  * @constructor
+ * @extends {WebInspector.Object}
  */
 WebInspector.DebuggerPresentationModel = function()
 {
@@ -104,7 +105,7 @@
 
     _addScript: function(script)
     {
-        var rawSourceCodeId = this._createRawSourceCodeId(script.sourceURL, script.scriptId);
+        var rawSourceCodeId = this._createRawSourceCodeId(script);
         var rawSourceCode = this._rawSourceCode[rawSourceCodeId];
         if (rawSourceCode) {
             rawSourceCode.addScript(script);
@@ -249,7 +250,7 @@
         if (!message.url || !message.isErrorOrWarning() || !message.message)
             return;
 
-        var rawSourceCode = this._rawSourceCodeForScript(message.url);
+        var rawSourceCode = this._rawSourceCodeForScriptWithURL(message.url);
         if (!rawSourceCode)
             return;
 
@@ -355,7 +356,7 @@
             var rawSourceCode;
             var script = WebInspector.debuggerModel.scriptForSourceID(callFrame.location.scriptId);
             if (script)
-                rawSourceCode = this._rawSourceCodeForScript(script.sourceURL, script.scriptId);
+                rawSourceCode = this._rawSourceCodeForScript(script);
             this._presentationCallFrames.push(new WebInspector.PresentationCallFrame(callFrame, i, this, rawSourceCode));
         }
         var details = WebInspector.debuggerModel.debuggerPausedDetails;
@@ -383,29 +384,28 @@
         return this._presentationCallFrames[this._selectedCallFrameIndex];
     },
 
-    _rawSourceCodeForScript: function(sourceURL, scriptId)
+    _rawSourceCodeForScriptWithURL: function(sourceURL)
     {
-        if (!sourceURL) {
-            var script = WebInspector.debuggerModel.scriptForSourceID(scriptId);
-            if (!script)
-                return;
-            sourceURL = script.sourceURL;
-        }
-        return this._rawSourceCode[this._createRawSourceCodeId(sourceURL, scriptId)];
+        return this._rawSourceCode[sourceURL];
     },
 
+    _rawSourceCodeForScript: function(script)
+    {
+        return this._rawSourceCode[this._createRawSourceCodeId(script)];
+    },
+
     _scriptForRawSourceCode: function(rawSourceCode)
     {
         function filter(script)
         {
-            return this._createRawSourceCodeId(script.sourceURL, script.scriptId) === rawSourceCode.id;
+            return this._createRawSourceCodeId(script) === rawSourceCode.id;
         }
         return WebInspector.debuggerModel.queryScripts(filter.bind(this))[0];
     },
 
-    _createRawSourceCodeId: function(sourceURL, scriptId)
+    _createRawSourceCodeId: function(script)
     {
-        return sourceURL || scriptId;
+        return script.sourceURL || script.scriptId;
     },
 
     _debuggerReset: function()
@@ -518,7 +518,7 @@
 
 /**
  * @constructor
- * @extends {WebInspector.ResourceDomainModelBinding}
+ * @implements {WebInspector.ResourceDomainModelBinding}
  */
 WebInspector.DebuggerPresentationModelResourceBinding = function(model)
 {
@@ -529,7 +529,7 @@
 WebInspector.DebuggerPresentationModelResourceBinding.prototype = {
     canSetContent: function(resource)
     {
-        var rawSourceCode = this._presentationModel._rawSourceCodeForScript(resource.url)
+        var rawSourceCode = this._presentationModel._rawSourceCodeForScriptWithURL(resource.url)
         if (!rawSourceCode)
             return false;
         return this._presentationModel.canEditScriptSource(rawSourceCode.sourceMapping.uiSourceCode);
@@ -540,7 +540,7 @@
         if (!majorChange)
             return;
 
-        var rawSourceCode = this._presentationModel._rawSourceCodeForScript(resource.url);
+        var rawSourceCode = this._presentationModel._rawSourceCodeForScriptWithURL(resource.url);
         if (!rawSourceCode) {
             userCallback("Resource is not editable");
             return;

Modified: trunk/Source/WebCore/inspector/front-end/HelpScreen.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/HelpScreen.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/HelpScreen.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -28,6 +28,9 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/**
+ * @constructor
+ */
 WebInspector.HelpScreen = function(title)
 {
     this._element = document.createElement("div");

Modified: trunk/Source/WebCore/inspector/front-end/_javascript_ContextManager.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/_javascript_ContextManager.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_ContextManager.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -28,6 +28,10 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/**
+ * @constructor
+ * @extends {WebInspector.Object}
+ */
 WebInspector._javascript_ContextManager = function(resourceTreeModel, consoleView)
 {
     resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameAdded, this._frameAdded, this);
@@ -68,6 +72,10 @@
 
 WebInspector._javascript_ContextManager.prototype.__proto__ = WebInspector.Object.prototype;
 
+/**
+ * @constructor
+ * @extends {WebInspector.Object}
+ */
 WebInspector.FrameEvaluationContext = function(frame)
 {
     this._frame = frame;
@@ -100,7 +108,7 @@
         if (!this._frame.parentId)
             return "<top frame>";
         var name = this._frame.name || "";
-        var subtitle = new WebInspector.Resource(null, this._frame.url).displayName;
+        var subtitle = WebInspector.Resource.displayName(this._frame.url);
         if (subtitle) {
             if (!name)
                 return subtitle;

Modified: trunk/Source/WebCore/inspector/front-end/KeyboardShortcut.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/KeyboardShortcut.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/KeyboardShortcut.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -32,7 +32,7 @@
  */
 WebInspector.KeyboardShortcut = function()
 {
-};
+}
 
 /**
  * Constants for encoding modifier key set as a bit mask.
@@ -131,6 +131,9 @@
     };
 }
 
+/**
+ * @param {number=} modifiers
+ */
 WebInspector.KeyboardShortcut.shortcutToString = function(key, modifiers)
 {
     return WebInspector.KeyboardShortcut._modifiersToString(modifiers) + WebInspector.KeyboardShortcut._keyName(key);

Modified: trunk/Source/WebCore/inspector/front-end/Resource.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/Resource.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/Resource.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -69,7 +69,7 @@
  * @constructor
  * @extends {WebInspector.Object}
  *
- * @param {NetworkAgent.RequestId} requestId
+ * @param {?NetworkAgent.RequestId} requestId
  * @param {string} url
  * @param {?string} frameId
  * @param {?NetworkAgent.LoaderId} loaderId
@@ -93,6 +93,11 @@
     this.receiveHeadersEnd = 0;
 }
 
+WebInspector.Resource.displayName = function(url)
+{
+    return new WebInspector.Resource(null, url, null, null).displayName;
+}
+
 // Keep these in sync with WebCore::InspectorResource::Type
 WebInspector.Resource.Type = {
     Document:   0,
@@ -165,7 +170,6 @@
     WebInspector.Resource._domainModelBindings[type] = binding;
 }
 
-
 WebInspector.Resource._resourceRevisionRegistry = function()
 {
     if (!WebInspector.Resource._resourceRevisionRegistryObject) {
@@ -836,6 +840,11 @@
         binding.setContent(this, newContent, majorChange, callback);
     },
 
+    /**
+     * @param {string} newContent
+     * @param {Date=} timestamp
+     * @param {boolean=} restoringHistory
+     */
     addRevision: function(newContent, timestamp, restoringHistory)
     {
         var revision = new WebInspector.ResourceRevision(this, this._content, this._contentTimestamp);

Modified: trunk/Source/WebCore/inspector/front-end/ScriptFormatter.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/ScriptFormatter.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/ScriptFormatter.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -67,7 +67,7 @@
         var task = this._tasks.shift();
         var originalContent = task.data.content;
         var formattedContent = event.data.content;
-        var mapping = event.data.mapping;
+        var mapping = event.data["mapping"];
         var sourceMapping = new WebInspector.FormattedSourceMapping(originalContent.lineEndings(), formattedContent.lineEndings(), mapping);
         task.callback(formattedContent, sourceMapping);
     },

Modified: trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -28,6 +28,9 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/**
+ * @constructor
+ */
 WebInspector.ShortcutsScreen = function()
 {
     this._sections = {};
@@ -90,10 +93,13 @@
         }
         parent.appendChild(table);
     }
-};
+}
 
 WebInspector.shortcutsScreen = new WebInspector.ShortcutsScreen();
 
+/**
+ * @constructor
+ */
 WebInspector.ShortcutsSection = function(name)
 {
     this.name = name;
@@ -162,4 +168,4 @@
     {
         return this._lines.length + 2; // add some space for header
     }
-};
+}

Modified: trunk/Source/WebCore/inspector/front-end/StatusBarButton.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/StatusBarButton.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/StatusBarButton.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -28,6 +28,11 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/**
+ * @extends {WebInspector.Object}
+ * @constructor
+ * @param {Array.<string>=} states
+ */
 WebInspector.StatusBarButton = function(title, className, states)
 {
     this.element = document.createElement("button");

Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -28,6 +28,7 @@
 
 /**
  * @constructor
+ * @param {boolean=} omitHistory
  */
 WebInspector.TextPrompt = function(element, completions, stopCharacters, omitHistory)
 {

Modified: trunk/Source/WebCore/inspector/front-end/externs.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/externs.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/externs.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -111,3 +111,38 @@
 WebInspector.networkResourceById = function(requestId)
 {
 }
+
+/**
+ * @param {WebInspector.ContextMenu} contextMenu
+ * @param {Node} contextNode
+ * @param {Event} event
+ */
+WebInspector.populateHrefContextMenu = function(contextMenu, contextNode, event)
+{
+}
+
+/**
+ * @return {boolean}
+ */
+WebInspector.useLowerCaseMenuTitles = function()
+{
+}
+
+WebInspector.panels = {};
+
+/**
+ * @constructor
+ */
+WebInspector.ScriptsPanel = function()
+{
+    /** @param {...*} var_args */     
+    this.evaluateInSelectedCallFrame = function(var_args) {}
+    /** @param {...*} var_args */     
+    this.getSelectedCallFrameVariables = function(var_args) {}
+    this.paused = false;
+}
+
+/**
+ * @type {?WebInspector.ScriptsPanel}
+ */
+WebInspector.panels.scripts = null;

Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/inspector.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -510,7 +510,7 @@
     this.console.addEventListener(WebInspector.ConsoleModel.Events.RepeatCountUpdated, this._updateErrorAndWarningCounts, this);
 
     this.drawer = new WebInspector.Drawer();
-    this.consoleView = new WebInspector.ConsoleView();
+    this.consoleView = new WebInspector.ConsoleView(WebInspector.WorkerManager.isWorkerFrontend());
 
     this.networkManager = new WebInspector.NetworkManager();
     this.resourceTreeModel = new WebInspector.ResourceTreeModel();

Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (96574 => 96575)


--- trunk/Source/WebCore/inspector/front-end/utilities.js	2011-10-04 07:21:48 UTC (rev 96574)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js	2011-10-04 08:37:04 UTC (rev 96575)
@@ -250,6 +250,9 @@
     return selectionRange.startContainer === this || selectionRange.startContainer.isDescendant(this);
 }
 
+/**
+ * @param {string=} className
+ */
 Element.prototype.createChild = function(elementName, className)
 {
     var element = this.ownerDocument.createElement(elementName);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to