Title: [96161] trunk/Tools
Revision
96161
Author
[email protected]
Date
2011-09-27 15:04:21 -0700 (Tue, 27 Sep 2011)

Log Message

webkit-patch doesn't like UTF-8 characters in reviewers names
https://bugs.webkit.org/show_bug.cgi?id=63452

Patch by Tom Zakrajsek <[email protected]> on 2011-09-27
Reviewed by Eric Seidel.

* Scripts/webkit-patch:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (96160 => 96161)


--- trunk/Tools/ChangeLog	2011-09-27 21:47:30 UTC (rev 96160)
+++ trunk/Tools/ChangeLog	2011-09-27 22:04:21 UTC (rev 96161)
@@ -1,3 +1,12 @@
+2011-09-27  Tom Zakrajsek  <[email protected]>
+
+        webkit-patch doesn't like UTF-8 characters in reviewers names
+        https://bugs.webkit.org/show_bug.cgi?id=63452
+
+        Reviewed by Eric Seidel.
+
+        * Scripts/webkit-patch:
+
 2011-09-27  Adam Barth  <[email protected]>
 
         garden-o-matic examine buttons shows both expected and unexpected failures

Modified: trunk/Tools/Scripts/webkit-patch (96160 => 96161)


--- trunk/Tools/Scripts/webkit-patch	2011-09-27 21:47:30 UTC (rev 96160)
+++ trunk/Tools/Scripts/webkit-patch	2011-09-27 22:04:21 UTC (rev 96161)
@@ -1,4 +1,5 @@
 #!/usr/bin/env python
+# Copyright (c) 2011 Code Aurora Forum. All rights reserved.
 # Copyright (c) 2010 Google Inc. All rights reserved.
 # Copyright (c) 2009 Apple Inc. All rights reserved.
 # Copyright (C) 2010 Chris Jerdonek ([email protected])
@@ -35,7 +36,14 @@
 import os
 import signal
 import sys
+import codecs
 
+# By default, sys.stdout assumes ascii encoding.  Since our messages can
+# contain unicode strings (as with some peoples' names) we need to apply
+# the utf-8 codec to prevent throwing and exception.
+# Not having this was the cause of https://bugs.webkit.org/show_bug.cgi?id=63452.
+sys.stdout = codecs.lookup('utf-8')[-1](sys.stdout)
+
 from webkitpy.common.system.logutils import configure_logging
 import webkitpy.python24.versioning as versioning
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to