Title: [96023] trunk
Revision
96023
Author
[email protected]
Date
2011-09-26 16:02:17 -0700 (Mon, 26 Sep 2011)

Log Message

Enable requestAnimationFrame on Windows
https://bugs.webkit.org/show_bug.cgi?id=68397

Reviewed by Simon Fraser.

Source/_javascript_Core: 

Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows

* wtf/Platform.h:

WebKitLibraries: 

Enable REQUEST_ANIMATION_FRAME for Windows

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests: 

Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
is still skipped because it uses showModalDialog which is not supported in DRT on Windows

* platform/win/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (96022 => 96023)


--- trunk/LayoutTests/ChangeLog	2011-09-26 23:02:13 UTC (rev 96022)
+++ trunk/LayoutTests/ChangeLog	2011-09-26 23:02:17 UTC (rev 96023)
@@ -1,3 +1,15 @@
+2011-09-26  Chris Marrin  <[email protected]>
+
+        Enable requestAnimationFrame on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=68397
+
+        Reviewed by Simon Fraser.
+
+        Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
+        is still skipped because it uses showModalDialog which is not supported in DRT on Windows
+
+        * platform/win/Skipped:
+
 2011-09-26  Ryosuke Niwa  <[email protected]>
 
         editing/selection/select-bidi-run.html timeouts on non-Mac platforms

Modified: trunk/LayoutTests/platform/win/Skipped (96022 => 96023)


--- trunk/LayoutTests/platform/win/Skipped	2011-09-26 23:02:13 UTC (rev 96022)
+++ trunk/LayoutTests/platform/win/Skipped	2011-09-26 23:02:17 UTC (rev 96023)
@@ -1244,9 +1244,8 @@
 # DRT does not obey addURLToRedirect
 http/tests/loading/cross-origin-XHR-willLoadRequest.html
 
-# Request ENABLE(REQUEST_ANIMATION_FRAME) support
-fast/animation
-inspector/timeline/timeline-animation-frame.html
+# Uses showModalDialog (https://bugs.webkit.org/show_bug.cgi?id=53675)
+fast/animation/request-animation-frame-during-modal.html
 
 # This port doesn't support v8 i18n extension.
 fast/js/i18n-bindings-locale.html

Modified: trunk/Source/_javascript_Core/ChangeLog (96022 => 96023)


--- trunk/Source/_javascript_Core/ChangeLog	2011-09-26 23:02:13 UTC (rev 96022)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-26 23:02:17 UTC (rev 96023)
@@ -1,3 +1,14 @@
+2011-09-26  Chris Marrin  <[email protected]>
+
+        Enable requestAnimationFrame on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=68397
+
+        Reviewed by Simon Fraser.
+
+        Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows
+
+        * wtf/Platform.h:
+
 2011-09-26  Noel Gordon  <[email protected]>
 
         [Chromium] Remove DFGAliasTracker.h references from gyp project files

Modified: trunk/Source/_javascript_Core/wtf/Platform.h (96022 => 96023)


--- trunk/Source/_javascript_Core/wtf/Platform.h	2011-09-26 23:02:13 UTC (rev 96022)
+++ trunk/Source/_javascript_Core/wtf/Platform.h	2011-09-26 23:02:17 UTC (rev 96023)
@@ -1099,8 +1099,9 @@
 #define WTF_USE_AVFOUNDATION 1
 #endif
 
-#if PLATFORM(MAC) || PLATFORM(GTK)
+#if PLATFORM(MAC) || PLATFORM(GTK) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO))
 #define WTF_USE_REQUEST_ANIMATION_FRAME_TIMER 1
+#define WTF_USE_REQUEST_ANIMATION_FRAME_TIMER 1
 #endif
 
 #endif /* WTF_Platform_h */

Modified: trunk/Source/WebCore/DerivedSources.cpp (96022 => 96023)


--- trunk/Source/WebCore/DerivedSources.cpp	2011-09-26 23:02:13 UTC (rev 96022)
+++ trunk/Source/WebCore/DerivedSources.cpp	2011-09-26 23:02:17 UTC (rev 96023)
@@ -273,6 +273,7 @@
 #include "JSRange.cpp"
 #include "JSRangeException.cpp"
 #include "JSRect.cpp"
+#include "JSRequestAnimationFrameCallback.cpp"
 #include "JSRGBColor.cpp"
 #include "JSScreen.cpp"
 #include "JSScriptProfile.cpp"

Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (96022 => 96023)


--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-09-26 23:02:13 UTC (rev 96022)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2011-09-26 23:02:17 UTC (rev 96023)
@@ -13174,6 +13174,62 @@
 				>
 			</File>
 			<File
+				RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSRequestAnimationFrameCallback.cpp"
+				>
+				<FileConfiguration
+					Name="Debug|Win32"
+					ExcludedFromBuild="true"
+					>
+					<Tool
+						Name="VCCLCompilerTool"
+					/>
+				</FileConfiguration>
+				<FileConfiguration
+					Name="Release|Win32"
+					ExcludedFromBuild="true"
+					>
+					<Tool
+						Name="VCCLCompilerTool"
+					/>
+				</FileConfiguration>
+				<FileConfiguration
+					Name="Debug_Cairo_CFLite|Win32"
+					ExcludedFromBuild="true"
+					>
+					<Tool
+						Name="VCCLCompilerTool"
+					/>
+				</FileConfiguration>
+				<FileConfiguration
+					Name="Release_Cairo_CFLite|Win32"
+					ExcludedFromBuild="true"
+					>
+					<Tool
+						Name="VCCLCompilerTool"
+					/>
+				</FileConfiguration>
+				<FileConfiguration
+					Name="Debug_All|Win32"
+					ExcludedFromBuild="true"
+					>
+					<Tool
+						Name="VCCLCompilerTool"
+					/>
+				</FileConfiguration>
+				<FileConfiguration
+					Name="Production|Win32"
+					ExcludedFromBuild="true"
+					>
+					<Tool
+						Name="VCCLCompilerTool"
+					/>
+				</FileConfiguration>
+			</File>
+			<File
+				RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSRequestAnimationFrameCallback.h"
+				>
+			</File>
+			<File
 				RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSRGBColor.cpp"
 				>
 				<FileConfiguration
@@ -48162,6 +48218,14 @@
 				>
 			</File>
 			<File
+				RelativePath="..\dom\ScriptedAnimationController.cpp"
+				>
+			</File>
+			<File
+				RelativePath="..\dom\ScriptedAnimationController.h"
+				>
+			</File>
+			<File
 				RelativePath="..\dom\ScriptElement.cpp"
 				>
 				<FileConfiguration
@@ -63697,6 +63761,18 @@
 					</FileConfiguration>
 				</File>
 				<File
+					RelativePath="..\bindings\js\JSRequestAnimationFrameCallbackCustom.cpp"
+					>
+					<FileConfiguration
+						Name="Debug|Win32"
+						ExcludedFromBuild="true"
+						>
+						<Tool
+							Name="VCCLCompilerTool"
+						/>
+					</FileConfiguration>
+				</File>
+				<File
 					RelativePath="..\bindings\js\JSScriptProfileNodeCustom.cpp"
 					>
 					<FileConfiguration
@@ -69065,11 +69141,11 @@
 					>
 				</File>
 				<File
-					RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
+					RelativePath="..\inspector\front-end\_javascript_Formatter.js"
 					>
 				</File>
 				<File
-					RelativePath="..\inspector\front-end\_javascript_Formatter.js"
+					RelativePath="..\inspector\front-end\UglifyJS\_javascript_Formatter.js"
 					>
 				</File>
 				<File

Modified: trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp (96022 => 96023)


--- trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp	2011-09-26 23:02:13 UTC (rev 96022)
+++ trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp	2011-09-26 23:02:17 UTC (rev 96023)
@@ -127,6 +127,7 @@
 #include "JSPeerConnectionCustom.cpp"
 #include "JSPluginElementFunctions.cpp"
 #include "JSProcessingInstructionCustom.cpp"
+#include "JSRequestAnimationFrameCallbackCustom.cpp"
 #include "JSSQLResultSetRowListCustom.cpp"
 #include "JSSQLTransactionCustom.cpp"
 #include "JSSQLTransactionSyncCustom.cpp"

Modified: trunk/WebKitLibraries/ChangeLog (96022 => 96023)


--- trunk/WebKitLibraries/ChangeLog	2011-09-26 23:02:13 UTC (rev 96022)
+++ trunk/WebKitLibraries/ChangeLog	2011-09-26 23:02:17 UTC (rev 96023)
@@ -1,3 +1,14 @@
+2011-09-26  Chris Marrin  <[email protected]>
+
+        Enable requestAnimationFrame on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=68397
+
+        Reviewed by Simon Fraser.
+
+        Enable REQUEST_ANIMATION_FRAME for Windows
+
+        * win/tools/vsprops/FeatureDefines.vsprops:
+
 2011-09-24  Adam Barth  <[email protected]>
 
         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)

Modified: trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops (96022 => 96023)


--- trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops	2011-09-26 23:02:13 UTC (rev 96022)
+++ trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops	2011-09-26 23:02:17 UTC (rev 96023)
@@ -9,9 +9,14 @@
 	>
   <Tool
 		Name="VCCLCompilerTool"
-		PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_MUTATION_OBSERVERS);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)"
+		PreprocessorDefinitions="$(ENABLE_REQUEST_ANIMATION_FRAME);$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_MUTATION_OBSERVERS);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)"
 	/>
   <UserMacro
+		Name="ENABLE_REQUEST_ANIMATION_FRAME"
+		Value="ENABLE_REQUEST_ANIMATION_FRAME"
+		PerformEnvironmentSet="true"
+	/>
+    <UserMacro
 		Name="ENABLE_3D_CANVAS"
 		Value=""
 		PerformEnvironmentSet="true"
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to