Title: [95943] trunk/Tools
- Revision
- 95943
- Author
- aro...@apple.com
- Date
- 2011-09-26 05:15:28 -0700 (Mon, 26 Sep 2011)
Log Message
Remove two failing WebKitAPITest tests
The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
Reviewed by Anders Carlsson.
* WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
MainFrameAfterClose tests.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (95942 => 95943)
--- trunk/Tools/ChangeLog 2011-09-26 12:15:14 UTC (rev 95942)
+++ trunk/Tools/ChangeLog 2011-09-26 12:15:28 UTC (rev 95943)
@@ -1,3 +1,14 @@
+2011-09-23 Adam Roben <aro...@apple.com>
+
+ Remove two failing WebKitAPITest tests
+
+ The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
+
+ Reviewed by Anders Carlsson.
+
+ * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
+ MainFrameAfterClose tests.
+
2011-09-25 Adam Barth <aba...@webkit.org>
Finish removing PLATFORM(BREWMP) by removing associated code
Modified: trunk/Tools/WebKitAPITest/tests/WebViewDestruction.cpp (95942 => 95943)
--- trunk/Tools/WebKitAPITest/tests/WebViewDestruction.cpp 2011-09-26 12:15:14 UTC (rev 95942)
+++ trunk/Tools/WebKitAPITest/tests/WebViewDestruction.cpp 2011-09-26 12:15:28 UTC (rev 95943)
@@ -114,17 +114,6 @@
finishWebViewDestructionTest(webView, 0);
}
-// Tests that releasing a WebView without calling IWebView::close or DestroyWindow doesn't leak. <http://webkit.org/b/33162>
-TEST(WebViewDestruction, NoCloseOrDestroyViewWindow)
-{
- COMPtr<IWebView> webView;
- HostWindow window;
- HWND viewWindow;
- createAndInitializeWebView(webView, window, viewWindow);
-
- finishWebViewDestructionTest(webView, viewWindow);
-}
-
// Tests that calling IWebView::close without calling DestroyWindow, then releasing a WebView doesn't crash. <http://webkit.org/b/32827>
TEST(WebViewDestruction, CloseWithoutDestroyViewWindow)
{
@@ -214,19 +203,4 @@
finishWebViewDestructionTest(webView, viewWindow);
}
-// Tests that calling IWebView::mainFrame after calling IWebView::close doesn't crash. <http://webkit.org/b/32868>
-TEST(WebViewDestruction, MainFrameAfterClose)
-{
- COMPtr<IWebView> webView;
- HostWindow window;
- HWND viewWindow;
- createAndInitializeWebView(webView, window, viewWindow);
-
- TEST_ASSERT(SUCCEEDED(webView->close()));
- COMPtr<IWebFrame> mainFrame;
- TEST_ASSERT(SUCCEEDED(webView->mainFrame(&mainFrame)));
-
- finishWebViewDestructionTest(webView, viewWindow);
-}
-
} // namespace WebKitAPITest
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
