Title: [95499] trunk/Tools
- Revision
- 95499
- Author
- [email protected]
- Date
- 2011-09-19 17:38:09 -0700 (Mon, 19 Sep 2011)
Log Message
check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
https://bugs.webkit.org/show_bug.cgi?id=68391
Reviewed by Darin Adler.
* Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (95498 => 95499)
--- trunk/Tools/ChangeLog 2011-09-20 00:35:41 UTC (rev 95498)
+++ trunk/Tools/ChangeLog 2011-09-20 00:38:09 UTC (rev 95499)
@@ -1,3 +1,13 @@
+2011-09-19 David Levin <[email protected]>
+
+ check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
+ https://bugs.webkit.org/show_bug.cgi?id=68391
+
+ Reviewed by Darin Adler.
+
+ * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
+
2011-09-19 Alexis Menard <[email protected]>
Style checker should not check public Qt WK2 API for parameter_name.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (95498 => 95499)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-09-20 00:35:41 UTC (rev 95498)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-09-20 00:38:09 UTC (rev 95499)
@@ -3403,6 +3403,8 @@
check_for_function_lengths(clean_lines, line, function_state, error)
if search(r'\bNOLINT\b', raw_lines[line]): # ignore nolint lines
return
+ if match(r'\s*\b__asm\b', raw_lines[line]): # Ignore asm lines as they format differently.
+ return
check_function_definition(filename, file_extension, clean_lines, line, function_state, error)
check_pass_ptr_usage(clean_lines, line, function_state, error)
check_for_multiline_comments_and_strings(clean_lines, line, error)
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (95498 => 95499)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-09-20 00:35:41 UTC (rev 95498)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-09-20 00:38:09 UTC (rev 95499)
@@ -615,6 +615,11 @@
class CppStyleTest(CppStyleTestBase):
+ def test_asm_lines_ignored(self):
+ self.assert_lint(
+ '__asm mov [registration], eax',
+ '')
+
# Test get line width.
def test_get_line_width(self):
self.assertEquals(0, cpp_style.get_line_width(''))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
