Title: [95441] trunk/Tools
- Revision
- 95441
- Author
- [email protected]
- Date
- 2011-09-19 11:03:06 -0700 (Mon, 19 Sep 2011)
Log Message
Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812
Patch by Kristóf Kosztyó <[email protected]> on 2011-09-19
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (95440 => 95441)
--- trunk/Tools/ChangeLog 2011-09-19 18:00:45 UTC (rev 95440)
+++ trunk/Tools/ChangeLog 2011-09-19 18:03:06 UTC (rev 95441)
@@ -1,3 +1,13 @@
+2011-09-19 Kristóf Kosztyó <[email protected]>
+
+ Buildbot marks a nrwt bot red when tests are missing results
+ https://bugs.webkit.org/show_bug.cgi?id=64812
+
+ Reviewed by Ryosuke Niwa.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+
2011-09-19 Jessie Berlin <[email protected]>
Sites that use history pushState or replaceState are recorded in history in Private Browsing
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (95440 => 95441)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-09-19 18:00:45 UTC (rev 95440)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-09-19 18:03:06 UTC (rev 95441)
@@ -147,6 +147,9 @@
if result_type != retry_result_type:
actual.append(keywords[retry_result_type])
num_flaky += 1
+ # FIXME: break MISSING results into a different category
+ elif 'MISSING' in actual:
+ num_flaky += 1
else:
num_regressions += 1
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (95440 => 95441)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2011-09-19 18:00:45 UTC (rev 95440)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2011-09-19 18:03:06 UTC (rev 95441)
@@ -715,7 +715,7 @@
tests_included=True, filesystem=fs, new_results=True)
file_list = fs.written_files.keys()
file_list.remove('/tmp/layout-test-results/tests_run0.txt')
- self.assertEquals(res, 2)
+ self.assertEquals(res, 0)
self.assertFalse(out.empty())
self.assertEqual(len(file_list), 4)
self.assertBaselines(file_list, "/failures/unexpected/missing_text", [".txt"], err)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
