Title: [95256] trunk/Source
- Revision
- 95256
- Author
- e...@google.com
- Date
- 2011-09-15 18:54:35 -0700 (Thu, 15 Sep 2011)
Log Message
[chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
https://bugs.webkit.org/show_bug.cgi?id=68204
Reviewed by James Robinson.
Add CRASH calls to determine which assumptions are being violated.
Source/WebCore:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitTo):
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (95255 => 95256)
--- trunk/Source/WebCore/ChangeLog 2011-09-16 01:32:32 UTC (rev 95255)
+++ trunk/Source/WebCore/ChangeLog 2011-09-16 01:54:35 UTC (rev 95256)
@@ -1,3 +1,15 @@
+2011-09-15 Adrienne Walker <e...@google.com>
+
+ [chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
+ https://bugs.webkit.org/show_bug.cgi?id=68204
+
+ Reviewed by James Robinson.
+
+ Add CRASH calls to determine which assumptions are being violated.
+
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+ (WebCore::CCLayerTreeHost::commitTo):
+
2011-09-15 Mark Hahnenberg <mhahnenb...@apple.com>
Unzip initialization lists and constructors in JSCell hierarchy (7/7)
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (95255 => 95256)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2011-09-16 01:32:32 UTC (rev 95255)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2011-09-16 01:54:35 UTC (rev 95256)
@@ -112,6 +112,10 @@
TRACE_EVENT("CCLayerTreeHost::commitTo", this, 0);
hostImpl->setSourceFrameNumber(frameNumber());
+ // FIXME: Temporary diagnostic for crbug 96719. This shouldn't happen.
+ if (!contentsTextureManager())
+ CRASH();
+
contentsTextureManager()->reduceMemoryToLimit(TextureManager::reclaimLimitBytes());
contentsTextureManager()->deleteEvictedTextures(hostImpl->context());
Modified: trunk/Source/WebKit/chromium/ChangeLog (95255 => 95256)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-16 01:32:32 UTC (rev 95255)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-16 01:54:35 UTC (rev 95256)
@@ -1,3 +1,15 @@
+2011-09-15 Adrienne Walker <e...@google.com>
+
+ [chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
+ https://bugs.webkit.org/show_bug.cgi?id=68204
+
+ Reviewed by James Robinson.
+
+ Add CRASH calls to determine which assumptions are being violated.
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::composite):
+
2011-09-15 David Levin <le...@chromium.org>
Remove TestWebKitAPI from the chromium build until it is made to work
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (95255 => 95256)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-09-16 01:32:32 UTC (rev 95255)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-09-16 01:54:35 UTC (rev 95256)
@@ -1170,6 +1170,10 @@
if (m_pageOverlay)
m_pageOverlay->update();
+ // FIXME: Temporary diagnostic for crbug 96719. This shouldn't happen.
+ if (!m_layerTreeHost)
+ CRASH();
+
m_layerTreeHost->composite();
#endif
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
