Title: [94869] trunk/Source/WebCore
- Revision
- 94869
- Author
- [email protected]
- Date
- 2011-09-09 11:37:05 -0700 (Fri, 09 Sep 2011)
Log Message
Initialize ExceptionCode in Element::removeAttribute
https://bugs.webkit.org/show_bug.cgi?id=67820
Reviewed by Darin Adler.
Silences valgrind warning reported in http://crbug.com/76490.
No new tests since this would only very occasionally be flaky,
and in the codepath in the valgrind report, the ec is ignored anyway.
* dom/Element.cpp:
(WebCore::Element::removeAttribute): Initialize ec to 0.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94868 => 94869)
--- trunk/Source/WebCore/ChangeLog 2011-09-09 18:21:54 UTC (rev 94868)
+++ trunk/Source/WebCore/ChangeLog 2011-09-09 18:37:05 UTC (rev 94869)
@@ -1,3 +1,18 @@
+2011-09-09 Adam Klein <[email protected]>
+
+ Initialize ExceptionCode in Element::removeAttribute
+ https://bugs.webkit.org/show_bug.cgi?id=67820
+
+ Reviewed by Darin Adler.
+
+ Silences valgrind warning reported in http://crbug.com/76490.
+
+ No new tests since this would only very occasionally be flaky,
+ and in the codepath in the valgrind report, the ec is ignored anyway.
+
+ * dom/Element.cpp:
+ (WebCore::Element::removeAttribute): Initialize ec to 0.
+
2011-09-09 Laszlo Gombos <[email protected]>
[Qt] Remove common.pri
Modified: trunk/Source/WebCore/dom/Element.cpp (94868 => 94869)
--- trunk/Source/WebCore/dom/Element.cpp 2011-09-09 18:21:54 UTC (rev 94868)
+++ trunk/Source/WebCore/dom/Element.cpp 2011-09-09 18:37:05 UTC (rev 94869)
@@ -1520,6 +1520,7 @@
String localName = shouldIgnoreAttributeCase(this) ? name.lower() : name;
if (m_attributeMap) {
+ ec = 0;
m_attributeMap->removeNamedItem(localName, ec);
if (ec == NOT_FOUND_ERR)
ec = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
