Title: [94325] trunk/Tools
- Revision
- 94325
- Author
- [email protected]
- Date
- 2011-09-01 11:57:09 -0700 (Thu, 01 Sep 2011)
Log Message
Remove unused "extension" parameter from rebaseline gardeningserver handler
https://bugs.webkit.org/show_bug.cgi?id=67384
Patch by Adam Barth <[email protected]> on 2011-09-01
Reviewed by James Robinson.
This parameter hasn't done anything in a while.
* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (94324 => 94325)
--- trunk/Tools/ChangeLog 2011-09-01 18:44:26 UTC (rev 94324)
+++ trunk/Tools/ChangeLog 2011-09-01 18:57:09 UTC (rev 94325)
@@ -1,3 +1,16 @@
+2011-09-01 Adam Barth <[email protected]>
+
+ Remove unused "extension" parameter from rebaseline gardeningserver handler
+ https://bugs.webkit.org/show_bug.cgi?id=67384
+
+ Reviewed by James Robinson.
+
+ This parameter hasn't done anything in a while.
+
+ * Scripts/webkitpy/tool/commands/rebaseline.py:
+ * Scripts/webkitpy/tool/servers/gardeningserver.py:
+ * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
+
2011-09-01 Eric Seidel <[email protected]>
Unreviewed.
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py (94324 => 94325)
--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py 2011-09-01 18:44:26 UTC (rev 94324)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py 2011-09-01 18:57:09 UTC (rev 94325)
@@ -57,8 +57,7 @@
class RebaselineTest(AbstractDeclarativeCommand):
name = "rebaseline-test"
help_text = "Rebaseline a single test from a buildbot. (Currently works only with build.chromium.org buildbots.)"
- # FIXME: Remove SUFFIX argument.
- argument_names = "BUILDER_NAME TEST_NAME [SUFFIX]"
+ argument_names = "BUILDER_NAME TEST_NAME"
def _results_url(self, builder_name):
# FIXME: Generalize this command to work with non-build.chromium.org builders.
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py (94324 => 94325)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2011-09-01 18:44:26 UTC (rev 94324)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2011-09-01 18:57:09 UTC (rev 94325)
@@ -154,12 +154,10 @@
def rebaseline(self):
builder = self.query['builder'][0]
test = self.query['test'][0]
- extension = self.query['extension'][0]
self._run_webkit_patch([
'rebaseline-test',
builder,
test,
- extension,
])
self._serve_text('success')
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py (94324 => 94325)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py 2011-09-01 18:44:26 UTC (rev 94324)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py 2011-09-01 18:57:09 UTC (rev 94325)
@@ -183,9 +183,9 @@
self._post_to_path("/rollout?revision=2314&reason=MOCK+rollout+reason", expected_stderr=expected_stderr, expected_stdout=expected_stdout)
def test_rebaseline(self):
- expected_stderr = "MOCK run_command: ['echo', 'rebaseline-test', 'MOCK builder', 'user-scripts/another-test.html', 'txt'], cwd=/mock-checkout\n"
+ expected_stderr = "MOCK run_command: ['echo', 'rebaseline-test', 'MOCK builder', 'user-scripts/another-test.html'], cwd=/mock-checkout\n"
expected_stdout = "== Begin Response ==\nsuccess\n== End Response ==\n"
- self._post_to_path("/rebaseline?builder=MOCK+builder&test=user-scripts/another-test.html&extension=txt", expected_stderr=expected_stderr, expected_stdout=expected_stdout)
+ self._post_to_path("/rebaseline?builder=MOCK+builder&test=user-scripts/another-test.html", expected_stderr=expected_stderr, expected_stdout=expected_stdout)
def test_optimizebaselines(self):
expected_stderr = "MOCK run_command: ['echo', 'optimize-baselines', 'user-scripts/another-test.html'], cwd=/mock-checkout\n"
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
