Title: [94250] trunk/LayoutTests
- Revision
- 94250
- Author
- [email protected]
- Date
- 2011-08-31 16:54:35 -0700 (Wed, 31 Aug 2011)
Log Message
fix bug in flexbox test with offsetWidth/offsetLeft of 0
https://bugs.webkit.org/show_bug.cgi?id=67330
Reviewed by Tony Chang.
* css3/flexbox/resources/flexbox.js:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (94249 => 94250)
--- trunk/LayoutTests/ChangeLog 2011-08-31 23:54:11 UTC (rev 94249)
+++ trunk/LayoutTests/ChangeLog 2011-08-31 23:54:35 UTC (rev 94250)
@@ -1,3 +1,12 @@
+2011-08-31 Ojan Vafai <[email protected]>
+
+ fix bug in flexbox test with offsetWidth/offsetLeft of 0
+ https://bugs.webkit.org/show_bug.cgi?id=67330
+
+ Reviewed by Tony Chang.
+
+ * css3/flexbox/resources/flexbox.js:
+
2011-08-31 Kenji Imasaki <[email protected]>
[Chromium] Update a bug number in test expectation file and skip
Modified: trunk/LayoutTests/css3/flexbox/resources/flexbox.js (94249 => 94250)
--- trunk/LayoutTests/css3/flexbox/resources/flexbox.js 2011-08-31 23:54:11 UTC (rev 94249)
+++ trunk/LayoutTests/css3/flexbox/resources/flexbox.js 2011-08-31 23:54:35 UTC (rev 94250)
@@ -9,13 +9,13 @@
function checkExpectedValues(node, failures)
{
var expectedWidth = node.getAttribute && node.getAttribute("data-expected-width");
- if (node.offsetWidth && expectedWidth) {
+ if (expectedWidth) {
if (node.offsetWidth != parseInt(expectedWidth))
failures.push("Expected " + expectedWidth + " for width, but got " + node.offsetWidth + ". ");
}
var expectedOffset = node.getAttribute && node.getAttribute("data-offset-x");
- if (node.offsetLeft && expectedOffset) {
+ if (expectedOffset) {
if (node.offsetLeft != parseInt(expectedOffset))
failures.push("Expected " + expectedOffset + " for offsetLeft, but got " + node.offsetLeft + ". ");
}
@@ -35,6 +35,6 @@
}
insertAfter(document.createElement("p"), flexbox);
- insertAfter(document.createTextNode(failures.length ? failures.join('<br>') : "PASS"), flexbox);
+ insertAfter(document.createTextNode(failures.length ? failures.join('') : "PASS"), flexbox);
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
