Title: [93926] trunk/Tools
- Revision
- 93926
- Author
- [email protected]
- Date
- 2011-08-26 17:23:11 -0700 (Fri, 26 Aug 2011)
Log Message
garden-o-matic summary view should have pretty commit data information.
https://bugs.webkit.org/show_bug.cgi?id=67069
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (93925 => 93926)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-08-26 23:44:02 UTC (rev 93925)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-08-27 00:23:11 UTC (rev 93926)
@@ -109,12 +109,22 @@
init: function(commitData)
{
var linkToRevision = this._description.appendChild(document.createElement('a'));
- // FIXME: Set href.
- linkToRevision.href = '';
+ linkToRevision.href = ""
+ linkToRevision.target = '_blank';
linkToRevision.textContent = commitData.revision;
- // FIXME: Reviewer could be unknown.
- // FIXME: Provide opportunities to style title/author/reviewer separately.
- this._description.appendChild(document.createTextNode(commitData.title + ' ' + commitData.author + ' (' + commitData.reviewer + ')'));
+ this._addDescriptionPart('title', commitData);
+ this._addDescriptionPart('author', commitData);
+ this._addDescriptionPart('reviewer', commitData);
+ },
+ _addDescriptionPart: function(part, commitData)
+ {
+ var content = commitData[part];
+ if (!content)
+ return;
+
+ var span = this._description.appendChild(document.createElement('span'));
+ span.className = part;
+ span.textContent = content;
}
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (93925 => 93926)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-08-26 23:44:02 UTC (rev 93925)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-08-27 00:23:11 UTC (rev 93926)
@@ -87,7 +87,16 @@
test('SuspiciousCommit', 2, function() {
var suspiciousCommit = new ui.notifications.SuspiciousCommit({revision: 1, title: "title", author: "author", reviewer: "reviewer"});
equal(suspiciousCommit.tagName, 'LI');
- equal(suspiciousCommit.innerHTML, '<div class="description"><a href="" author (reviewer)</div><ul class="actions"><li><button>Roll out</button></li></ul>');
+ equal(suspiciousCommit.innerHTML,
+ '<div class="description">' +
+ '<a href="" target="_blank">1</a>' +
+ '<span class="title">title</span>' +
+ '<span class="author">author</span>' +
+ '<span class="reviewer">reviewer</span>' +
+ '</div>' +
+ '<ul class="actions">' +
+ '<li><button>Roll out</button></li>' +
+ '</ul>');
});
test('TestsFailing', 13, function() {
@@ -186,7 +195,10 @@
'<ul class="causes">' +
'<li>' +
'<div class="description">' +
- '<a href="" author (reviewer)'+
+ '<a href="" target="_blank">1</a>' +
+ '<span class="title">title</span>' +
+ '<span class="author">author</span>' +
+ '<span class="reviewer">reviewer</span>' +
'</div>' +
'<ul class="actions">' +
'<li><button>Roll out</button></li>' +
@@ -223,7 +235,10 @@
'<ul class="causes">' +
'<li>' +
'<div class="description">' +
- '<a href="" author (reviewer)'+
+ '<a href="" target="_blank">1</a>' +
+ '<span class="title">title</span>' +
+ '<span class="author">author</span>' +
+ '<span class="reviewer">reviewer</span>' +
'</div>' +
'<ul class="actions">' +
'<li><button>Roll out</button></li>' +
@@ -265,7 +280,10 @@
'<ul class="causes">' +
'<li>' +
'<div class="description">' +
- '<a href="" author (reviewer)'+
+ '<a href="" target="_blank">1</a>' +
+ '<span class="title">title</span>' +
+ '<span class="author">author</span>' +
+ '<span class="reviewer">reviewer</span>' +
'</div>' +
'<ul class="actions">' +
'<li><button>Roll out</button></li>' +
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css (93925 => 93926)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css 2011-08-26 23:44:02 UTC (rev 93925)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css 2011-08-27 00:23:11 UTC (rev 93926)
@@ -28,6 +28,10 @@
font-size: 14px;
}
+a {
+ color: #333;
+}
+
button {
font-family: 'Open Sans';
border-radius: 2px;
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css (93925 => 93926)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-08-26 23:44:02 UTC (rev 93925)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-08-27 00:23:11 UTC (rev 93926)
@@ -72,13 +72,54 @@
ol.notifications ul.causes>li {
border-top: 1px solid LightGray;
- padding: 10px;
+ padding: 10px 20px 10px 0;
}
ol.notifications>li ul.causes>li>div.description {
padding: 0 10px 0 0;
}
+ ol.notifications>li ul.causes>li>div.description>a {
+ padding: 0 20px 0 10px;
+ border-radius: 4px;
+ }
+
+ ol.notifications>li ul.causes>li:hover>div.description>a {
+ background-color: #555;
+ padding: 5px 10px 5px 10px;
+ margin: 0 10px 0 0;
+ color: White;
+ }
+
+ ol.notifications>li ul.causes>li:hover>div.description>a::after {
+ content: '';
+ width: 0;
+ height: 0;
+ margin-top: 5px;
+ position: absolute;
+ margin-left: 10px;
+ border-top: 5px solid White;
+ border-left: 5px solid #555;
+ border-bottom: 5px solid White;
+ }
+
+ ol.notifications>li ul.causes>li>div.description>span {
+ padding: 0 10px 0 0;
+ display: inline-block;
+ }
+
+ ol.notifications>li ul.causes>li>div.description>span.reviewer {
+ color: Gray;
+ }
+
+ ol.notifications>li ul.causes>li>div.description>span.reviewer::before {
+ content: '(';
+ }
+
+ ol.notifications>li ul.causes>li>div.description>span.reviewer::after {
+ content: ')';
+ }
+
ol.notifications>li ul.causes>li>ul.actions {
}
Modified: trunk/Tools/ChangeLog (93925 => 93926)
--- trunk/Tools/ChangeLog 2011-08-26 23:44:02 UTC (rev 93925)
+++ trunk/Tools/ChangeLog 2011-08-27 00:23:11 UTC (rev 93926)
@@ -1,5 +1,17 @@
2011-08-26 Dimitri Glazkov <[email protected]>
+ garden-o-matic summary view should have pretty commit data information.
+ https://bugs.webkit.org/show_bug.cgi?id=67069
+
+ Reviewed by Adam Barth.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
+
+2011-08-26 Dimitri Glazkov <[email protected]>
+
Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
https://bugs.webkit.org/show_bug.cgi?id=67066
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
