Title: [93919] trunk/Source/WebCore
- Revision
- 93919
- Author
- [email protected]
- Date
- 2011-08-26 15:26:25 -0700 (Fri, 26 Aug 2011)
Log Message
Remove offset hack from GraphicsContextCG setShadow code
https://bugs.webkit.org/show_bug.cgi?id=67052
Reviewed by Simon Fraser.
No new tests - current tests cover it.
* platform/graphics/cg/GraphicsContextCG.cpp:
Removing the offset hack introduced in http://trac.webkit.org/changeset/28714
for an issue with offsets in an old version of CoreGraphics that's long since been fixed.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (93918 => 93919)
--- trunk/Source/WebCore/ChangeLog 2011-08-26 22:23:43 UTC (rev 93918)
+++ trunk/Source/WebCore/ChangeLog 2011-08-26 22:26:25 UTC (rev 93919)
@@ -1,3 +1,16 @@
+2011-08-26 Matthew Delaney <[email protected]>
+
+ Remove offset hack from GraphicsContextCG setShadow code
+ https://bugs.webkit.org/show_bug.cgi?id=67052
+
+ Reviewed by Simon Fraser.
+
+ No new tests - current tests cover it.
+
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ Removing the offset hack introduced in http://trac.webkit.org/changeset/28714
+ for an issue with offsets in an old version of CoreGraphics that's long since been fixed.
+
2011-08-26 Alexey Proskuryakov <[email protected]>
Get rid of frame life support timer
Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (93918 => 93919)
--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2011-08-26 22:23:43 UTC (rev 93918)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2011-08-26 22:26:25 UTC (rev 93919)
@@ -1021,19 +1021,6 @@
// Extreme "blur" values can make text drawing crash or take crazy long times, so clamp
blurRadius = min(blurRadius, narrowPrecisionToCGFloat(1000.0));
- // Work around <rdar://problem/5539388> by ensuring that the offsets will get truncated
- // to the desired integer.
- static const CGFloat extraShadowOffset = narrowPrecisionToCGFloat(1.0 / 128);
- if (xOffset > 0)
- xOffset += extraShadowOffset;
- else if (xOffset < 0)
- xOffset -= extraShadowOffset;
-
- if (yOffset > 0)
- yOffset += extraShadowOffset;
- else if (yOffset < 0)
- yOffset -= extraShadowOffset;
-
// Check for an invalid color, as this means that the color was not set for the shadow
// and we should therefore just use the default shadow color.
if (!color.isValid())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
