Title: [93897] trunk/Source/WebKit2
- Revision
- 93897
- Author
- alexis.men...@openbossa.org
- Date
- 2011-08-26 11:24:48 -0700 (Fri, 26 Aug 2011)
Log Message
[Qt][WK2]REGRESSION(r93784): It made many tests crash
https://bugs.webkit.org/show_bug.cgi?id=66958
Reviewed by Anders Carlsson.
Don't try to make sure the WebContext is deleted, for now the leak
is intended and when multiple processes per context will be supported
this leak should be fixed. This was the cause of DRT crashing on the bot,
the context was deleted after the first test, letting other tests with nothing
but a bad context.
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::~QtWebPageProxy):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (93896 => 93897)
--- trunk/Source/WebKit2/ChangeLog 2011-08-26 18:23:32 UTC (rev 93896)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-26 18:24:48 UTC (rev 93897)
@@ -1,3 +1,19 @@
+2011-08-26 Alexis Menard <alexis.men...@openbossa.org>
+
+ [Qt][WK2]REGRESSION(r93784): It made many tests crash
+ https://bugs.webkit.org/show_bug.cgi?id=66958
+
+ Reviewed by Anders Carlsson.
+
+ Don't try to make sure the WebContext is deleted, for now the leak
+ is intended and when multiple processes per context will be supported
+ this leak should be fixed. This was the cause of DRT crashing on the bot,
+ the context was deleted after the first test, letting other tests with nothing
+ but a bad context.
+
+ * UIProcess/qt/QtWebPageProxy.cpp:
+ (QtWebPageProxy::~QtWebPageProxy):
+
2011-08-26 Anders Carlsson <ander...@apple.com>
Fix handling of keyup events in the new Cocoa text input model
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp (93896 => 93897)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-08-26 18:23:32 UTC (rev 93896)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-08-26 18:24:48 UTC (rev 93897)
@@ -210,7 +210,6 @@
QtWebPageProxy::~QtWebPageProxy()
{
m_webPageProxy->close();
- m_context->disconnectProcess(m_context->process());
// The context is the default one and we're deleting the last QtWebPageProxy.
if (m_context == s_defaultContext) {
ASSERT(s_defaultPageProxyCount > 0);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
