Title: [93652] trunk/Source/WebCore
- Revision
- 93652
- Author
- [email protected]
- Date
- 2011-08-23 16:12:27 -0700 (Tue, 23 Aug 2011)
Log Message
[Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.
https://bugs.webkit.org/show_bug.cgi?id=66635
When mobile theme is in use and application palette is using light
color to display text button text becomes invisible. The reason for
that is that in RenderThemeQt::systemFont() we are using application
pallete while when are painting buttons lightGrayPalette is used.
Calling setPaletteFromPageClientIfExists() takes care of the issue.
Patch by Misha Tyutyunik <[email protected]> on 2011-08-23
Reviewed by Andreas Kling.
Covered by existing tests.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::systemColor):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (93651 => 93652)
--- trunk/Source/WebCore/ChangeLog 2011-08-23 23:10:45 UTC (rev 93651)
+++ trunk/Source/WebCore/ChangeLog 2011-08-23 23:12:27 UTC (rev 93652)
@@ -1,3 +1,21 @@
+2011-08-23 Misha Tyutyunik <[email protected]>
+
+ [Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.
+ https://bugs.webkit.org/show_bug.cgi?id=66635
+
+ When mobile theme is in use and application palette is using light
+ color to display text button text becomes invisible. The reason for
+ that is that in RenderThemeQt::systemFont() we are using application
+ pallete while when are painting buttons lightGrayPalette is used.
+ Calling setPaletteFromPageClientIfExists() takes care of the issue.
+
+ Reviewed by Andreas Kling.
+
+ Covered by existing tests.
+
+ * platform/qt/RenderThemeQt.cpp:
+ (WebCore::RenderThemeQt::systemColor):
+
2011-08-23 Tony Chang <[email protected]>
Add handling of mix-width and max-width for flexitems
Modified: trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp (93651 => 93652)
--- trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp 2011-08-23 23:10:45 UTC (rev 93651)
+++ trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp 2011-08-23 23:12:27 UTC (rev 93652)
@@ -438,6 +438,7 @@
Color RenderThemeQt::systemColor(int cssValueId) const
{
QPalette pal = QApplication::palette();
+ setPaletteFromPageClientIfExists(pal);
switch (cssValueId) {
case CSSValueButtontext:
return pal.brush(QPalette::Active, QPalette::ButtonText).color();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
