Title: [93623] trunk/Tools
- Revision
- 93623
- Author
- [email protected]
- Date
- 2011-08-23 12:27:32 -0700 (Tue, 23 Aug 2011)
Log Message
webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
https://bugs.webkit.org/show_bug.cgi?id=49080
Reviewed by Adam Roben.
Use the string form of pipe open instead (like we do at all other places).
* Scripts/VCSUtils.pm:
(mergeChangeLogs):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (93622 => 93623)
--- trunk/Tools/ChangeLog 2011-08-23 19:21:05 UTC (rev 93622)
+++ trunk/Tools/ChangeLog 2011-08-23 19:27:32 UTC (rev 93623)
@@ -1,3 +1,15 @@
+2011-08-23 Patrick Gansterer <[email protected]>
+
+ webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
+ https://bugs.webkit.org/show_bug.cgi?id=49080
+
+ Reviewed by Adam Roben.
+
+ Use the string form of pipe open instead (like we do at all other places).
+
+ * Scripts/VCSUtils.pm:
+ (mergeChangeLogs):
+
2011-08-23 Adam Barth <[email protected]>
garden-o-matic summary should be able to examine failures
Modified: trunk/Tools/Scripts/VCSUtils.pm (93622 => 93623)
--- trunk/Tools/Scripts/VCSUtils.pm 2011-08-23 19:21:05 UTC (rev 93622)
+++ trunk/Tools/Scripts/VCSUtils.pm 2011-08-23 19:27:32 UTC (rev 93623)
@@ -1696,7 +1696,7 @@
rename($fileMine, "$fileMine.save");
rename($fileOlder, "$fileOlder.save");
} else {
- open(DIFF, "-|", qw(diff -u -a --binary), $fileOlder, $fileMine) or die $!;
+ open(DIFF, "diff -u -a --binary \"$fileOlder\" \"$fileMine\" |") or die $!;
$patch = <DIFF>;
close(DIFF);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
