Title: [93620] trunk/Source/WebKit2
- Revision
- 93620
- Author
- [email protected]
- Date
- 2011-08-23 11:46:33 -0700 (Tue, 23 Aug 2011)
Log Message
[Qt][WK2] Fix an awful memory leak introduced in r92376.
https://bugs.webkit.org/show_bug.cgi?id=65528
Reviewed by Benjamin Poulain.
The non-virtual destructor would create a leak of the tile update buffer because
the NodeUpdateSetTexture's QImage member destructor wouldn't be called.
* UIProcess/qt/SGAgent.h:
(WebKit::NodeUpdate::~NodeUpdate):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (93619 => 93620)
--- trunk/Source/WebKit2/ChangeLog 2011-08-23 18:42:52 UTC (rev 93619)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-23 18:46:33 UTC (rev 93620)
@@ -1,3 +1,16 @@
+2011-08-23 Jocelyn Turcotte <[email protected]>
+
+ [Qt][WK2] Fix an awful memory leak introduced in r92376.
+ https://bugs.webkit.org/show_bug.cgi?id=65528
+
+ Reviewed by Benjamin Poulain.
+
+ The non-virtual destructor would create a leak of the tile update buffer because
+ the NodeUpdateSetTexture's QImage member destructor wouldn't be called.
+
+ * UIProcess/qt/SGAgent.h:
+ (WebKit::NodeUpdate::~NodeUpdate):
+
2011-08-23 Steve Block <[email protected]>
Remove all mention of removed Android files from build scripts
Modified: trunk/Source/WebKit2/UIProcess/qt/SGAgent.h (93619 => 93620)
--- trunk/Source/WebKit2/UIProcess/qt/SGAgent.h 2011-08-23 18:42:52 UTC (rev 93619)
+++ trunk/Source/WebKit2/UIProcess/qt/SGAgent.h 2011-08-23 18:46:33 UTC (rev 93620)
@@ -66,6 +66,7 @@
NodeUpdate(Type type)
: type(type)
{ }
+ virtual ~NodeUpdate() { }
Type type;
};
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
