Title: [93383] trunk/Tools
- Revision
- 93383
- Author
- [email protected]
- Date
- 2011-08-18 18:58:57 -0700 (Thu, 18 Aug 2011)
Log Message
new-run-webkit-tests hung while acquiring http lock on snow leopard bots
https://bugs.webkit.org/show_bug.cgi?id=64886
Temporarily disable the http locking to work around the issue.
I'm not actually sure if this is going to work or improve things
much.
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/layout_tests/port/mac.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (93382 => 93383)
--- trunk/Tools/ChangeLog 2011-08-19 01:33:07 UTC (rev 93382)
+++ trunk/Tools/ChangeLog 2011-08-19 01:58:57 UTC (rev 93383)
@@ -1,3 +1,16 @@
+2011-08-18 Dirk Pranke <[email protected]>
+
+ new-run-webkit-tests hung while acquiring http lock on snow leopard bots
+ https://bugs.webkit.org/show_bug.cgi?id=64886
+
+ Temporarily disable the http locking to work around the issue.
+ I'm not actually sure if this is going to work or improve things
+ much.
+
+ Reviewed by Ryosuke Niwa.
+
+ * Scripts/webkitpy/layout_tests/port/mac.py:
+
2011-08-18 Tony Chang <[email protected]>
add embedded png checksums to WebKitTestRunner
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (93382 => 93383)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2011-08-19 01:33:07 UTC (rev 93382)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2011-08-19 01:58:57 UTC (rev 93383)
@@ -155,3 +155,20 @@
def show_results_html_file(self, results_filename):
self._run_script('run-safari', ['-NSOpen', results_filename])
+
+ # FIXME: The next two routines turn off the http locking in order
+ # to work around failures on the bots caused when the slave restarts.
+ # See https://bugs.webkit.org/show_bug.cgi?id=64886 for more info.
+ # The proper fix is to make sure the slave is actually stopping NRWT
+ # properly on restart. Note that by removing the lock file and not waiting,
+ # the result should be that if there is a web server already running,
+ # it'll be killed and this one will be started in its place; this
+ # may lead to weird things happening in the other run. However, I don't
+ # think we're (intentionally) actually running multiple runs concurrently
+ # on any Mac bots.
+
+ def acquire_http_lock(self):
+ pass
+
+ def release_http_lock(self):
+ pass
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
