Title: [92739] branches/chromium/835/Source

Diff

Modified: branches/chromium/835/Source/WebCore/html/HTMLSourceElement.cpp (92738 => 92739)


--- branches/chromium/835/Source/WebCore/html/HTMLSourceElement.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/html/HTMLSourceElement.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -57,13 +57,15 @@
 void HTMLSourceElement::insertedIntoTree(bool deep)
 {
     HTMLElement::insertedIntoTree(deep);
-    if (parentNode() && (parentNode()->hasTagName(audioTag) || parentNode()->hasTagName(videoTag)))
+    Element* parent = parentElement();
+    if (parent && parent->isMediaElement())
         static_cast<HTMLMediaElement*>(parentNode())->sourceWasAdded(this);
 }
 
 void HTMLSourceElement::willRemove()
 {
-    if (parentNode() && (parentNode()->hasTagName(audioTag) || parentNode()->hasTagName(videoTag)))
+    Element* parent = parentElement();
+    if (parent && parent->isMediaElement())
         static_cast<HTMLMediaElement*>(parentNode())->sourceWillBeRemoved(this);
     HTMLElement::willRemove();
 }

Modified: branches/chromium/835/Source/WebCore/html/HTMLTrackElement.cpp (92738 => 92739)


--- branches/chromium/835/Source/WebCore/html/HTMLTrackElement.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/html/HTMLTrackElement.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -57,7 +57,8 @@
 void HTMLTrackElement::insertedIntoTree(bool deep)
 {
     HTMLElement::insertedIntoTree(deep);
-    if (parentNode() && (parentNode()->hasTagName(audioTag) || parentNode()->hasTagName(videoTag))) {
+    Element* parent = parentElement();
+    if (parent && parent->isMediaElement()) {
         // TODO(annacc):
         // static_cast<HTMLMediaElement*>(parentNode())->trackWasAdded(this);
     }
@@ -65,7 +66,8 @@
 
 void HTMLTrackElement::willRemove()
 {
-    if (parentNode() && (parentNode()->hasTagName(audioTag) || parentNode()->hasTagName(videoTag))) {
+    Element* parent = parentElement();
+    if (parent && parent->isMediaElement()) {
         // TODO(annacc):
         // static_cast<HTMLMediaElement*>(parentNode())->trackWillBeRemoved(this);
     }

Modified: branches/chromium/835/Source/WebCore/html/shadow/MediaControlElements.cpp (92738 => 92739)


--- branches/chromium/835/Source/WebCore/html/shadow/MediaControlElements.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/html/shadow/MediaControlElements.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -57,7 +57,7 @@
 HTMLMediaElement* toParentMediaElement(Node* node)
 {
     Node* mediaNode = node ? node->shadowAncestorNode() : 0;
-    if (!mediaNode || (!mediaNode->hasTagName(HTMLNames::videoTag) && !mediaNode->hasTagName(HTMLNames::audioTag)))
+    if (!mediaNode || !mediaNode->isElementNode() || !static_cast<Element*>(mediaNode)->isMediaElement())
         return 0;
 
     return static_cast<HTMLMediaElement*>(mediaNode);

Modified: branches/chromium/835/Source/WebCore/page/FrameView.cpp (92738 => 92739)


--- branches/chromium/835/Source/WebCore/page/FrameView.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/page/FrameView.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -2003,7 +2003,7 @@
         static_cast<HTMLPlugInImageElement*>(ownerElement)->updateWidget(CreateAnyWidgetType);
     // FIXME: It is not clear that Media elements need or want this updateWidget() call.
 #if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
-    else if (ownerElement->hasTagName(videoTag) || ownerElement->hasTagName(audioTag))
+    else if (ownerElement->isMediaElement())
         static_cast<HTMLMediaElement*>(ownerElement)->updateWidget(CreateAnyWidgetType);
 #endif
     else

Modified: branches/chromium/835/Source/WebCore/platform/efl/RenderThemeEfl.cpp (92738 => 92739)


--- branches/chromium/835/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -1160,7 +1160,7 @@
 bool RenderThemeEfl::paintMediaMuteButton(RenderObject* object, const PaintInfo& info, const IntRect& rect)
 {
     Node* mediaNode = object->node() ? object->node()->shadowAncestorNode() : 0;
-    if (!mediaNode || (!mediaNode->hasTagName(videoTag) && !mediaNode->hasTagName(audioTag)))
+    if (!mediaNode || !mediaNode->isElementNode() || !static_cast<Element*>(mediaNode)->isMediaElement())
         return false;
 
     HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(mediaNode);

Modified: branches/chromium/835/Source/WebCore/platform/gtk/RenderThemeGtk.cpp (92738 => 92739)


--- branches/chromium/835/Source/WebCore/platform/gtk/RenderThemeGtk.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/platform/gtk/RenderThemeGtk.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -64,7 +64,7 @@
 {
     Node* node = o->node();
     Node* mediaNode = node ? node->shadowAncestorNode() : 0;
-    if (!mediaNode || (!mediaNode->hasTagName(videoTag) && !mediaNode->hasTagName(audioTag)))
+    if (!mediaNode || !mediaNode->isElementNode() || !static_cast<Element*>(mediaNode)->isMediaElement())
         return 0;
 
     return static_cast<HTMLMediaElement*>(mediaNode);

Modified: branches/chromium/835/Source/WebCore/rendering/RenderThemeMac.mm (92738 => 92739)


--- branches/chromium/835/Source/WebCore/rendering/RenderThemeMac.mm	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/rendering/RenderThemeMac.mm	2011-08-10 01:35:54 UTC (rev 92739)
@@ -1792,7 +1792,7 @@
 {
     Node* node = o->node();
     Node* mediaNode = node ? node->shadowAncestorNode() : 0;
-    if (!mediaNode || (!mediaNode->hasTagName(videoTag) && !mediaNode->hasTagName(audioTag)))
+    if (!mediaNode || !mediaNode->isElementNode() || !static_cast<Element*>(mediaNode)->isMediaElement())
         return false;
 
     HTMLMediaElement* mediaElement = static_cast<HTMLMediaElement*>(mediaNode);

Modified: branches/chromium/835/Source/WebCore/rendering/RenderThemeWinCE.cpp (92738 => 92739)


--- branches/chromium/835/Source/WebCore/rendering/RenderThemeWinCE.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/rendering/RenderThemeWinCE.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -479,7 +479,7 @@
     if (!node)
         return 0;
     Node* mediaNode = node->shadowAncestorNode();
-    if (!mediaNode || (!mediaNode->hasTagName(HTMLNames::videoTag) && !mediaNode->hasTagName(HTMLNames::audioTag)))
+    if (!mediaNode || !mediaNode->isElementNode() || !static_cast<Element*>(mediaNode)->isMediaElement())
         return 0;
 
     return static_cast<HTMLMediaElement*>(mediaNode);

Modified: branches/chromium/835/Source/WebKit/mac/WebView/WebFullScreenController.mm (92738 => 92739)


--- branches/chromium/835/Source/WebKit/mac/WebView/WebFullScreenController.mm	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebKit/mac/WebView/WebFullScreenController.mm	2011-08-10 01:35:54 UTC (rev 92739)
@@ -736,7 +736,7 @@
     Node* nextNode = _element.get();
     while (nextNode)
     {
-        if (nextNode->hasTagName(HTMLNames::videoTag)) {
+        if (nextNode->hasTagName(HTMLNames::videoTag) && static_cast<Element*>(nextNode)->isMediaElement()) {
             HTMLMediaElement* element = static_cast<HTMLMediaElement*>(nextNode);
             if (!element->paused() && !element->ended())
                 return YES;

Modified: branches/chromium/835/Source/WebKit/win/WebView.cpp (92738 => 92739)


--- branches/chromium/835/Source/WebKit/win/WebView.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebKit/win/WebView.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -6131,7 +6131,7 @@
 
 void WebView::enterFullscreenForNode(Node* node)
 {
-    if (!node->hasTagName(HTMLNames::videoTag))
+    if (!node->hasTagName(HTMLNames::videoTag) || !node->isElementNode() || !static_cast<Element*>(node)->isMediaElement())
         return;
 
 #if ENABLE(VIDEO)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to