Title: [92170] trunk/Source/WebCore
- Revision
- 92170
- Author
- pfeld...@chromium.org
- Date
- 2011-08-02 02:20:57 -0700 (Tue, 02 Aug 2011)
Log Message
Web Inspector: 404/errors should get a RED visual treatment so easier to identify.
https://bugs.webkit.org/show_bug.cgi?id=65471
Reviewed by Yury Semikhatsky.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
* inspector/front-end/networkLogView.css:
(.network-error-cell):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (92169 => 92170)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 08:46:48 UTC (rev 92169)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 09:20:57 UTC (rev 92170)
@@ -1,5 +1,17 @@
2011-08-02 Pavel Feldman <pfeld...@google.com>
+ Web Inspector: 404/errors should get a RED visual treatment so easier to identify.
+ https://bugs.webkit.org/show_bug.cgi?id=65471
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
+ * inspector/front-end/networkLogView.css:
+ (.network-error-cell):
+
+2011-08-02 Pavel Feldman <pfeld...@google.com>
+
Web Inspector: arrow is a pain to click in console. Drive-by selection reset fix.
https://bugs.webkit.org/show_bug.cgi?id=65467
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (92169 => 92170)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-08-02 08:46:48 UTC (rev 92169)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-08-02 09:20:57 UTC (rev 92170)
@@ -1889,6 +1889,7 @@
else
this._statusCell.setTextAndTitle(WebInspector.UIString("(failed)"));
this._statusCell.addStyleClass("network-dim-cell");
+ this.element.addStyleClass("network-error-row");
return;
}
@@ -1896,15 +1897,20 @@
if (fromCache) {
this._statusCell.setTextAndTitle(WebInspector.UIString("(from cache)"));
this._statusCell.addStyleClass("network-dim-cell");
+ this.element.removeStyleClass("network-error-row");
return;
}
this._statusCell.removeStyleClass("network-dim-cell");
+ this.element.removeStyleClass("network-error-row");
+
if (this._resource.statusCode) {
this._statusCell.appendChild(document.createTextNode(this._resource.statusCode));
this._statusCell.removeStyleClass("network-dim-cell");
this._appendSubtitle(this._statusCell, this._resource.statusText);
this._statusCell.title = this._resource.statusCode + " " + this._resource.statusText;
+ if (this._resource.statusCode >= 400)
+ this.element.addStyleClass("network-error-row");
} else {
if (this._resource.isDataURL() && this._resource.finished)
this._statusCell.setTextAndTitle(WebInspector.UIString("(data url)"));
Modified: trunk/Source/WebCore/inspector/front-end/networkLogView.css (92169 => 92170)
--- trunk/Source/WebCore/inspector/front-end/networkLogView.css 2011-08-02 08:46:48 UTC (rev 92169)
+++ trunk/Source/WebCore/inspector/front-end/networkLogView.css 2011-08-02 09:20:57 UTC (rev 92170)
@@ -375,6 +375,10 @@
color: grey;
}
+.network-error-row {
+ color: rgb(230, 0, 0);
+}
+
/* Dividers */
.network-timeline-grid {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
