Title: [91901] trunk/Source/WebCore
Revision
91901
Author
[email protected]
Date
2011-07-27 21:34:10 -0700 (Wed, 27 Jul 2011)

Log Message

Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
https://bugs.webkit.org/show_bug.cgi?id=65279

Reviewed by Pavel Feldman.

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::open):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (91900 => 91901)


--- trunk/Source/WebCore/ChangeLog	2011-07-28 04:32:39 UTC (rev 91900)
+++ trunk/Source/WebCore/ChangeLog	2011-07-28 04:34:10 UTC (rev 91901)
@@ -1,3 +1,13 @@
+2011-07-27  Vsevolod Vlasov  <[email protected]>
+
+        Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
+        https://bugs.webkit.org/show_bug.cgi?id=65279
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/InspectorPageAgent.cpp:
+        (WebCore::InspectorPageAgent::open):
+
 2011-07-27  Adam Klein  <[email protected]>
 
         [V8] Remove unused m_isWeak member of V8AbstractEventListener

Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (91900 => 91901)


--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2011-07-28 04:32:39 UTC (rev 91900)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2011-07-28 04:34:10 UTC (rev 91901)
@@ -299,6 +299,8 @@
 
 void InspectorPageAgent::open(ErrorString*, const String& url, const bool* const inNewWindow)
 {
+    UserGestureIndicator indicator(DefinitelyProcessingUserGesture);
+
     Frame* mainFrame = m_page->mainFrame();
     Frame* frame;
     if (inNewWindow && *inNewWindow) {
@@ -315,7 +317,6 @@
     } else
         frame = mainFrame;
 
-    UserGestureIndicator indicator(DefinitelyProcessingUserGesture);
     // FIXME: Why does one use mainFrame and the other frame?
     frame->loader()->changeLocation(mainFrame->document()->securityOrigin(), frame->document()->completeURL(url), "", false, false);
 }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to