Title: [91802] trunk/Source/WebCore
- Revision
- 91802
- Author
- [email protected]
- Date
- 2011-07-26 17:25:06 -0700 (Tue, 26 Jul 2011)
Log Message
V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
https://bugs.webkit.org/show_bug.cgi?id=65222
Reviewed by James Robinson.
No new tests - this fixes upcoming audionode.html layout test
* bindings/v8/custom/V8AudioNodeCustom.cpp:
(WebCore::V8AudioNode::connectCallback):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (91801 => 91802)
--- trunk/Source/WebCore/ChangeLog 2011-07-27 00:15:37 UTC (rev 91801)
+++ trunk/Source/WebCore/ChangeLog 2011-07-27 00:25:06 UTC (rev 91802)
@@ -1,5 +1,17 @@
2011-07-26 Chris Rogers <[email protected]>
+ V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
+ https://bugs.webkit.org/show_bug.cgi?id=65222
+
+ Reviewed by James Robinson.
+
+ No new tests - this fixes upcoming audionode.html layout test
+
+ * bindings/v8/custom/V8AudioNodeCustom.cpp:
+ (WebCore::V8AudioNode::connectCallback):
+
+2011-07-26 Chris Rogers <[email protected]>
+
AudioContext is not correctly accounting for hardware resources
https://bugs.webkit.org/show_bug.cgi?id=65217
Modified: trunk/Source/WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp (91801 => 91802)
--- trunk/Source/WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp 2011-07-27 00:15:37 UTC (rev 91801)
+++ trunk/Source/WebCore/bindings/v8/custom/V8AudioNodeCustom.cpp 2011-07-27 00:25:06 UTC (rev 91802)
@@ -41,7 +41,10 @@
if (args.Length() < 1)
return throwError("Not enough arguments", V8Proxy::SyntaxError);
- AudioNode* destinationNode = toNative(args[0]->ToObject());
+ AudioNode* destinationNode = 0;
+ if (V8AudioNode::HasInstance(args[0]))
+ destinationNode = toNative(args[0]->ToObject());
+
if (!destinationNode)
return throwError("Invalid destination node", V8Proxy::SyntaxError);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
