Title: [91624] trunk/Tools
- Revision
- 91624
- Author
- [email protected]
- Date
- 2011-07-22 17:10:09 -0700 (Fri, 22 Jul 2011)
Log Message
Don't match 'DEBUG' when trying to filter BUG modifiers.
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (91623 => 91624)
--- trunk/Tools/ChangeLog 2011-07-23 00:01:57 UTC (rev 91623)
+++ trunk/Tools/ChangeLog 2011-07-23 00:10:09 UTC (rev 91624)
@@ -1,5 +1,11 @@
2011-07-22 Ojan Vafai <[email protected]>
+ Don't match 'DEBUG' when trying to filter BUG modifiers.
+ * TestResultServer/static-dashboards/flakiness_dashboard.html:
+ * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
+
+2011-07-22 Ojan Vafai <[email protected]>
+
Fix issue loading gtests since there's no g_expectations.
Also, make filing a bug file a webkit.org bug, not a crbug since
the link is only shown for layout tests.
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html (91623 => 91624)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-23 00:01:57 UTC (rev 91623)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-23 00:10:09 UTC (rev 91624)
@@ -763,10 +763,9 @@
function filterBugs(modifiers)
{
- var bugs = modifiers.match(/BUG[^\s]*/g);
+ var bugs = modifiers.match(/\bBUG\S*/g);
if (!bugs)
return {bugs: '', modifiers: modifiers};
-
for (var j = 0; j < bugs.length; j++)
modifiers = modifiers.replace(bugs[j], '');
return {bugs: bugs.join(' '), modifiers: collapseWhitespace(trimString(modifiers))};
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js (91623 => 91624)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js 2011-07-23 00:01:57 UTC (rev 91623)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js 2011-07-23 00:10:09 UTC (rev 91624)
@@ -249,12 +249,12 @@
function testFilterBugs()
{
- var filtered = filterBugs('SKIP BUG123 BUGCR123 BUGWK123 SLOW BUG_TONY')
- assertEquals(filtered.modifiers, 'SKIP SLOW');
+ var filtered = filterBugs('SKIP BUG123 BUGCR123 BUGWK123 SLOW BUG_TONY DEBUG')
+ assertEquals(filtered.modifiers, 'SKIP SLOW DEBUG');
assertEquals(filtered.bugs, 'BUG123 BUGCR123 BUGWK123 BUG_TONY');
- filtered = filterBugs('SKIP SLOW')
- assertEquals(filtered.modifiers, 'SKIP SLOW');
+ filtered = filterBugs('SKIP SLOW DEBUG')
+ assertEquals(filtered.modifiers, 'SKIP SLOW DEBUG');
assertEquals(filtered.bugs, '');
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
