Title: [91622] trunk/Tools
- Revision
- 91622
- Author
- [email protected]
- Date
- 2011-07-22 16:58:12 -0700 (Fri, 22 Jul 2011)
Log Message
Fix issue loading gtests since there's no g_expectations.
Also, make filing a bug file a webkit.org bug, not a crbug since
the link is only shown for layout tests.
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.html:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (91621 => 91622)
--- trunk/Tools/ChangeLog 2011-07-22 23:37:51 UTC (rev 91621)
+++ trunk/Tools/ChangeLog 2011-07-22 23:58:12 UTC (rev 91622)
@@ -1,5 +1,13 @@
2011-07-22 Ojan Vafai <[email protected]>
+ Fix issue loading gtests since there's no g_expectations.
+ Also, make filing a bug file a webkit.org bug, not a crbug since
+ the link is only shown for layout tests.
+ * TestResultServer/static-dashboards/dashboard_base.js:
+ * TestResultServer/static-dashboards/flakiness_dashboard.html:
+
+2011-07-22 Ojan Vafai <[email protected]>
+
pull test expectations into the dashboard from wvn.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=65054
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (91621 => 91622)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2011-07-22 23:37:51 UTC (rev 91621)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2011-07-22 23:58:12 UTC (rev 91622)
@@ -466,7 +466,7 @@
// Append JSON script elements.
var g_resultsByBuilder = {};
-var g_expectations = {};
+var g_expectations;
function ADD_RESULTS(builds)
{
for (var builderName in builds) {
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html (91621 => 91622)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-22 23:37:51 UTC (rev 91621)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-22 23:58:12 UTC (rev 91622)
@@ -838,6 +838,9 @@
function parsedExpectations()
{
+ if (!g_expectations)
+ return [];
+
var expectations = [];
var lines = g_expectations.split('\n');
lines.forEach(function(line) {
@@ -1391,14 +1394,14 @@
function createBugHTML(test)
{
var symptom = test.isFlaky ? 'flaky' : 'failing';
- var title = 'Layout Test ' + test.test + ' is ' + symptom;
- var description = 'The following layout test is ' + symptom + ' on ' +
+ var title = encodeURIComponent('Layout Test ' + test.test + ' is ' + symptom);
+ var description = encodeURIComponent('The following layout test is ' + symptom + ' on ' +
'[insert platform]\n\n' + test.test + '\n\nProbable cause:\n\n' +
- '[insert probable cause]';
- return BUG_URL_PREFIX + 'code.google.com/p/chromium/issues/entry?' +
- 'template=Layout%20Test%20Failure&summary=' +
- encodeURIComponent(title) + '&comment=' +
- encodeURIComponent(description) + '" class="file-bug">FILE BUG</a>';
+ '[insert probable cause]');
+
+ var component = encodeURIComponent('Tools / Tests');
+ url = '' + component + '&short_desc=' + title + '&comment=' + description;
+ return '<a href="" + url + '" class="file-bug">FILE BUG</a>';
}
function isCrossBuilderView()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
