Title: [91178] trunk/Source/WebCore
- Revision
- 91178
- Author
- [email protected]
- Date
- 2011-07-18 05:40:35 -0700 (Mon, 18 Jul 2011)
Log Message
Remove RenderObject::addLayers second argument
https://bugs.webkit.org/show_bug.cgi?id=64649
Reviewed by Benjamin Poulain.
No change in behavior.
The code was always passing |this| as the second argument. Thus just
removed the argument for clarity.
* rendering/RenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addLayers): Removed the argument, replaced
by |this|.
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Removed the second argument at those 2 call sites.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (91177 => 91178)
--- trunk/Source/WebCore/ChangeLog 2011-07-18 09:20:16 UTC (rev 91177)
+++ trunk/Source/WebCore/ChangeLog 2011-07-18 12:40:35 UTC (rev 91178)
@@ -1,3 +1,25 @@
+2011-07-18 Julien Chaffraix <[email protected]>
+
+ Remove RenderObject::addLayers second argument
+ https://bugs.webkit.org/show_bug.cgi?id=64649
+
+ Reviewed by Benjamin Poulain.
+
+ No change in behavior.
+
+ The code was always passing |this| as the second argument. Thus just
+ removed the argument for clarity.
+
+ * rendering/RenderObject.h:
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::addLayers): Removed the argument, replaced
+ by |this|.
+
+ * rendering/RenderObjectChildList.cpp:
+ (WebCore::RenderObjectChildList::appendChildNode):
+ (WebCore::RenderObjectChildList::insertChildNode):
+ Removed the second argument at those 2 call sites.
+
2011-07-18 Pavel Feldman <[email protected]>
Web Inspector: do not pause on caught exceptions while typing in the console.
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (91177 => 91178)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2011-07-18 09:20:16 UTC (rev 91177)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2011-07-18 12:40:35 UTC (rev 91178)
@@ -442,12 +442,12 @@
addLayers(curr, parentLayer, newObject, beforeChild);
}
-void RenderObject::addLayers(RenderLayer* parentLayer, RenderObject* newObject)
+void RenderObject::addLayers(RenderLayer* parentLayer)
{
if (!parentLayer)
return;
- RenderObject* object = newObject;
+ RenderObject* object = this;
RenderLayer* beforeChild = 0;
WebCore::addLayers(this, parentLayer, object, beforeChild);
}
Modified: trunk/Source/WebCore/rendering/RenderObject.h (91177 => 91178)
--- trunk/Source/WebCore/rendering/RenderObject.h 2011-07-18 09:20:16 UTC (rev 91177)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2011-07-18 12:40:35 UTC (rev 91178)
@@ -176,7 +176,7 @@
// properly added and removed. Since containership can be implemented by any subclass, and since a hierarchy
// can contain a mixture of boxes and other object types, these functions need to be in the base class.
RenderLayer* enclosingLayer() const;
- void addLayers(RenderLayer* parentLayer, RenderObject* newObject);
+ void addLayers(RenderLayer* parentLayer);
void removeLayers(RenderLayer* parentLayer);
void moveLayers(RenderLayer* oldParent, RenderLayer* newParent);
RenderLayer* findNextLayer(RenderLayer* parentLayer, RenderObject* startPoint, bool checkParent = true);
Modified: trunk/Source/WebCore/rendering/RenderObjectChildList.cpp (91177 => 91178)
--- trunk/Source/WebCore/rendering/RenderObjectChildList.cpp 2011-07-18 09:20:16 UTC (rev 91177)
+++ trunk/Source/WebCore/rendering/RenderObjectChildList.cpp 2011-07-18 12:40:35 UTC (rev 91178)
@@ -160,7 +160,7 @@
RenderLayer* layer = 0;
if (newChild->firstChild() || newChild->hasLayer()) {
layer = owner->enclosingLayer();
- newChild->addLayers(layer, newChild);
+ newChild->addLayers(layer);
}
// if the new child is visible but this object was not, tell the layer it has some visible content
@@ -220,7 +220,7 @@
RenderLayer* layer = 0;
if (child->firstChild() || child->hasLayer()) {
layer = owner->enclosingLayer();
- child->addLayers(layer, child);
+ child->addLayers(layer);
}
// if the new child is visible but this object was not, tell the layer it has some visible content
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
