Title: [89938] trunk/Source/WebCore
- Revision
- 89938
- Author
- [email protected]
- Date
- 2011-06-28 09:48:59 -0700 (Tue, 28 Jun 2011)
Log Message
2011-06-22 Pavel Podivilov <[email protected]>
Reviewed by Yury Semikhatsky.
Web Inspector: use column numbers when linking to script location in timeline and console.
https://bugs.webkit.org/show_bug.cgi?id=63126
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89937 => 89938)
--- trunk/Source/WebCore/ChangeLog 2011-06-28 16:27:46 UTC (rev 89937)
+++ trunk/Source/WebCore/ChangeLog 2011-06-28 16:48:59 UTC (rev 89938)
@@ -1,3 +1,16 @@
+2011-06-22 Pavel Podivilov <[email protected]>
+
+ Reviewed by Yury Semikhatsky.
+
+ Web Inspector: use column numbers when linking to script location in timeline and console.
+ https://bugs.webkit.org/show_bug.cgi?id=63126
+
+ * inspector/front-end/ConsoleView.js:
+ (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
+ * inspector/front-end/TimelinePanel.js:
+ (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
+ (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
+
2011-06-28 Joone Hur <[email protected]>
Reviewed by Martin Robinson.
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleView.js (89937 => 89938)
--- trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-06-28 16:27:46 UTC (rev 89937)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleView.js 2011-06-28 16:48:59 UTC (rev 89938)
@@ -980,7 +980,7 @@
content.appendChild(messageTextElement);
if (frame.url) {
- var urlElement = WebInspector.linkifyResourceAsNode(frame.url, "scripts", frame.lineNumber, "console-message-url");
+ var urlElement = WebInspector.linkifyCallFrameAsNode(frame, "console-message-url");
content.appendChild(urlElement);
}
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (89937 => 89938)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2011-06-28 16:27:46 UTC (rev 89937)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2011-06-28 16:48:59 UTC (rev 89938)
@@ -1021,10 +1021,10 @@
return this.data.width + "\u2009\u00d7\u2009" + this.data.height;
case WebInspector.TimelineAgent.RecordType.TimerInstall:
case WebInspector.TimelineAgent.RecordType.TimerRemove:
- return this.stackTrace ? WebInspector.linkifyResourceAsNode(this.stackTrace[0].url, "scripts", this.stackTrace[0].lineNumber, "", "") : this.data.timerId;
+ return this.stackTrace ? WebInspector.linkifyCallFrameAsNode(this.stackTrace[0], "") : this.data.timerId;
case WebInspector.TimelineAgent.RecordType.ParseHTML:
case WebInspector.TimelineAgent.RecordType.RecalculateStyles:
- return this.stackTrace ? WebInspector.linkifyResourceAsNode(this.stackTrace[0].url, "scripts", this.stackTrace[0].lineNumber, "", "") : null;
+ return this.stackTrace ? WebInspector.linkifyCallFrameAsNode(this.stackTrace[0], "") : null;
case WebInspector.TimelineAgent.RecordType.EvaluateScript:
return this.url ? WebInspector.linkifyResourceAsNode(this.url, "scripts", this.data.lineNumber, "", "") : null;
case WebInspector.TimelineAgent.RecordType.XHRReadyStateChange:
@@ -1124,7 +1124,7 @@
row.appendChild(this._createCell(stackFrame.functionName ? stackFrame.functionName : WebInspector.UIString("(anonymous function)"), "timeline-function-name"));
row.appendChild(this._createCell(" @ "));
var linkCell = document.createElement("td");
- linkCell.appendChild(WebInspector.linkifyResourceAsNode(stackFrame.url, "scripts", stackFrame.lineNumber, "timeline-details"));
+ linkCell.appendChild(WebInspector.linkifyCallFrameAsNode(stackFrame, "timeline-details"));
row.appendChild(linkCell);
framesTable.appendChild(row);
}
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (89937 => 89938)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2011-06-28 16:27:46 UTC (rev 89937)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2011-06-28 16:48:59 UTC (rev 89938)
@@ -1181,7 +1181,7 @@
WebInspector._showAnchorLocation = function(anchor)
{
- var preferedPanel = this.panels[anchor.getAttribute("preferred_panel")];
+ var preferedPanel = this.panels[anchor.getAttribute("preferred_panel") || "resources"];
if (WebInspector._showAnchorLocationInPanel(anchor, preferedPanel))
return true;
if (preferedPanel !== this.panels.resources && WebInspector._showAnchorLocationInPanel(anchor, this.panels.resources))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
