Title: [89933] trunk/Source/WebCore
- Revision
- 89933
- Author
- [email protected]
- Date
- 2011-06-28 08:56:42 -0700 (Tue, 28 Jun 2011)
Log Message
REGRESSION (r89733): fast/text/zero-font-size.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63512
Reviewed by Darin Adler.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformWidthForGlyph): Initialize the advance local variable, because
on Leopard wkGetGlyphTransformedAdvances can return successfully yet not update the variable when
the font size is 0. Presumably, r89733 exposed this by changing the values put on the stack just
before this function is called.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89932 => 89933)
--- trunk/Source/WebCore/ChangeLog 2011-06-28 15:42:04 UTC (rev 89932)
+++ trunk/Source/WebCore/ChangeLog 2011-06-28 15:56:42 UTC (rev 89933)
@@ -1,3 +1,16 @@
+2011-06-28 Dan Bernstein <[email protected]>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION (r89733): fast/text/zero-font-size.html is failing on Leopard
+ https://bugs.webkit.org/show_bug.cgi?id=63512
+
+ * platform/graphics/mac/SimpleFontDataMac.mm:
+ (WebCore::SimpleFontData::platformWidthForGlyph): Initialize the advance local variable, because
+ on Leopard wkGetGlyphTransformedAdvances can return successfully yet not update the variable when
+ the font size is 0. Presumably, r89733 exposed this by changing the values put on the stack just
+ before this function is called.
+
2011-06-27 Alexander Pavlov <[email protected]>
Reviewed by Pavel Feldman.
Modified: trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm (89932 => 89933)
--- trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm 2011-06-28 15:42:04 UTC (rev 89932)
+++ trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm 2011-06-28 15:56:42 UTC (rev 89933)
@@ -399,7 +399,7 @@
float SimpleFontData::platformWidthForGlyph(Glyph glyph) const
{
- CGSize advance;
+ CGSize advance = CGSizeZero;
if (platformData().orientation() == Horizontal || m_isBrokenIdeographFallback) {
NSFont* font = platformData().font();
float pointSize = platformData().m_size;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
