Diff
Modified: trunk/Source/WebCore/ChangeLog (89780 => 89781)
--- trunk/Source/WebCore/ChangeLog 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/ChangeLog 2011-06-27 04:45:43 UTC (rev 89781)
@@ -1,5 +1,37 @@
2011-06-26 Adam Barth <[email protected]>
+ Reviewed by Eric Seidel.
+
+ Add [Optional] attributes where appropriate for addEventListener and removeEventListener
+ https://bugs.webkit.org/show_bug.cgi?id=63417
+
+ This patch doesn't actually change behavior because these interfaces
+ have the LegacyDefaultOptionalArguments attribute. This patch paves
+ the way to removing LegacyDefaultOptionalArguments from some of these
+ interfaces as well as making the project safer for copy-and-pasting
+ these methods into new IDL files that don't have the
+ LegacyDefaultOptionalArguments attribute.
+
+ * bindings/scripts/test/TestObj.idl:
+ * dom/EventTarget.idl:
+ * dom/MediaStream.idl:
+ * dom/MessagePort.idl:
+ * dom/Node.idl:
+ * loader/appcache/DOMApplicationCache.idl:
+ * notifications/Notification.idl:
+ * page/DOMWindow.idl:
+ * page/EventSource.idl:
+ * storage/IDBRequest.idl:
+ * storage/IDBTransaction.idl:
+ * svg/SVGElementInstance.idl:
+ * websockets/WebSocket.idl:
+ * workers/AbstractWorker.idl:
+ * workers/WorkerContext.idl:
+ * xml/XMLHttpRequest.idl:
+ * xml/XMLHttpRequestUpload.idl:
+
+2011-06-26 Adam Barth <[email protected]>
+
Reviewed by Kent Tamura.
m_formElementsWithFormAttribute doesn't ref the objects it holds
Modified: trunk/Source/WebCore/bindings/scripts/test/TestObj.idl (89780 => 89781)
--- trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -96,10 +96,10 @@
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
// 'CallWith' extended attribute
[CallWith=DynamicFrame] void withDynamicFrame();
Modified: trunk/Source/WebCore/dom/EventTarget.idl (89780 => 89781)
--- trunk/Source/WebCore/dom/EventTarget.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/dom/EventTarget.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -29,10 +29,10 @@
] EventTarget {
[OldStyleObjC] void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
[OldStyleObjC] void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event event)
raises(EventException);
};
Modified: trunk/Source/WebCore/dom/MediaStream.idl (89780 => 89781)
--- trunk/Source/WebCore/dom/MediaStream.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/dom/MediaStream.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -39,10 +39,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event event)
raises(EventException);
};
Modified: trunk/Source/WebCore/dom/MessagePort.idl (89780 => 89781)
--- trunk/Source/WebCore/dom/MessagePort.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/dom/MessagePort.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -48,10 +48,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
#endif
Modified: trunk/Source/WebCore/dom/Node.idl (89780 => 89781)
--- trunk/Source/WebCore/dom/Node.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/dom/Node.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -140,10 +140,10 @@
#if !defined(LANGUAGE_OBJECTIVE_C) || !LANGUAGE_OBJECTIVE_C
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event event)
raises(EventException);
#endif
Modified: trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl (89780 => 89781)
--- trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -60,10 +60,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
};
Modified: trunk/Source/WebCore/notifications/Notification.idl (89780 => 89781)
--- trunk/Source/WebCore/notifications/Notification.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/notifications/Notification.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -52,10 +52,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
};
Modified: trunk/Source/WebCore/page/DOMWindow.idl (89780 => 89781)
--- trunk/Source/WebCore/page/DOMWindow.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -340,10 +340,10 @@
// EventTarget interface
[Custom] void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
[Custom] void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
Modified: trunk/Source/WebCore/page/EventSource.idl (89780 => 89781)
--- trunk/Source/WebCore/page/EventSource.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/page/EventSource.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -60,10 +60,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
Modified: trunk/Source/WebCore/storage/IDBRequest.idl (89780 => 89781)
--- trunk/Source/WebCore/storage/IDBRequest.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/storage/IDBRequest.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -56,10 +56,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
};
Modified: trunk/Source/WebCore/storage/IDBTransaction.idl (89780 => 89781)
--- trunk/Source/WebCore/storage/IDBTransaction.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/storage/IDBTransaction.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -51,10 +51,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
};
Modified: trunk/Source/WebCore/svg/SVGElementInstance.idl (89780 => 89781)
--- trunk/Source/WebCore/svg/SVGElementInstance.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/svg/SVGElementInstance.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -90,10 +90,10 @@
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event event)
raises(EventException);
#endif /* defined(LANGUAGE_OBJECTIVE_C) */
Modified: trunk/Source/WebCore/websockets/WebSocket.idl (89780 => 89781)
--- trunk/Source/WebCore/websockets/WebSocket.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/websockets/WebSocket.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -65,10 +65,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
};
Modified: trunk/Source/WebCore/workers/AbstractWorker.idl (89780 => 89781)
--- trunk/Source/WebCore/workers/AbstractWorker.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/workers/AbstractWorker.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -43,10 +43,10 @@
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
};
Modified: trunk/Source/WebCore/workers/WorkerContext.idl (89780 => 89781)
--- trunk/Source/WebCore/workers/WorkerContext.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/workers/WorkerContext.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -69,10 +69,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (89780 => 89781)
--- trunk/Source/WebCore/xml/XMLHttpRequest.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -114,10 +114,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
};
Modified: trunk/Source/WebCore/xml/XMLHttpRequestUpload.idl (89780 => 89781)
--- trunk/Source/WebCore/xml/XMLHttpRequestUpload.idl 2011-06-27 03:43:39 UTC (rev 89780)
+++ trunk/Source/WebCore/xml/XMLHttpRequestUpload.idl 2011-06-27 04:45:43 UTC (rev 89781)
@@ -45,10 +45,10 @@
// EventTarget interface
void addEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
void removeEventListener(in DOMString type,
in EventListener listener,
- in boolean useCapture);
+ in [Optional] boolean useCapture);
boolean dispatchEvent(in Event evt)
raises(EventException);
};
