Title: [89760] trunk/Source/WebCore
- Revision
- 89760
- Author
- [email protected]
- Date
- 2011-06-25 21:04:07 -0700 (Sat, 25 Jun 2011)
Log Message
2011-06-25 Joseph Pecoraro <[email protected]>
Reviewed by Darin Adler.
Fix some minor style issues
https://bugs.webkit.org/show_bug.cgi?id=63391
* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::DrawNodeHighlight):
The explicit WebCore namespace usage can be dropped.
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
Use ASSERT_UNUSED for a parameter that we want to ASSERT
on for a debug build, but is UNUSED in a release build.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89759 => 89760)
--- trunk/Source/WebCore/ChangeLog 2011-06-26 00:39:52 UTC (rev 89759)
+++ trunk/Source/WebCore/ChangeLog 2011-06-26 04:04:07 UTC (rev 89760)
@@ -1,5 +1,21 @@
2011-06-25 Joseph Pecoraro <[email protected]>
+ Reviewed by Darin Adler.
+
+ Fix some minor style issues
+ https://bugs.webkit.org/show_bug.cgi?id=63391
+
+ * inspector/DOMNodeHighlighter.cpp:
+ (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
+ The explicit WebCore namespace usage can be dropped.
+
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::mapLocalToContainer):
+ Use ASSERT_UNUSED for a parameter that we want to ASSERT
+ on for a debug build, but is UNUSED in a release build.
+
+2011-06-25 Joseph Pecoraro <[email protected]>
+
Unreviewed build fix.
Use UNUSED_PARAM on the correct param!
Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (89759 => 89760)
--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2011-06-26 00:39:52 UTC (rev 89759)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2011-06-26 04:04:07 UTC (rev 89760)
@@ -132,7 +132,7 @@
return mainFramePoint - IntPoint();
}
-void drawElementTitle(GraphicsContext& context, Node* node, const IntRect& boundingBox, const IntRect& anchorBox, const FloatRect& overlayRect, WebCore::Settings* settings)
+void drawElementTitle(GraphicsContext& context, Node* node, const IntRect& boundingBox, const IntRect& anchorBox, const FloatRect& overlayRect, Settings* settings)
{
static const int rectInflatePx = 4;
static const int fontHeightPx = 12;
@@ -297,7 +297,7 @@
if (!node->isElementNode())
return;
- WebCore::Settings* settings = containingFrame->settings();
+ Settings* settings = containingFrame->settings();
if (mode == DOMNodeHighlighter::HighlightAll)
drawElementTitle(context, node, boundingBox, titleAnchorBox, overlayRect, settings);
}
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (89759 => 89760)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2011-06-26 00:39:52 UTC (rev 89759)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2011-06-26 04:04:07 UTC (rev 89760)
@@ -141,8 +141,7 @@
// If a container was specified, and was not 0 or the RenderView,
// then we should have found it by now.
ASSERT_ARG(repaintContainer, !repaintContainer || repaintContainer == this);
- ASSERT(!wasFixed || *wasFixed == fixed);
- UNUSED_PARAM(wasFixed);
+ ASSERT_UNUSED(wasFixed, !wasFixed || *wasFixed == fixed);
if (!repaintContainer && useTransforms && shouldUseTransformFromContainer(0)) {
TransformationMatrix t;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
